diff options
| author | fragosti <francesco.agosti93@gmail.com> | 2018-10-30 06:48:45 +0800 | 
|---|---|---|
| committer | fragosti <francesco.agosti93@gmail.com> | 2018-10-30 06:48:45 +0800 | 
| commit | 10e6c3cd906c6625ed0c9ae98d20ef9f32676cbe (patch) | |
| tree | 0f2d0aaf11510fafa84c6bf5821e6c3623a1c07d /packages/asset-buyer | |
| parent | ac72df41883af261b8661cb5f52c01567a6aad62 (diff) | |
| download | dexon-sol-tools-10e6c3cd906c6625ed0c9ae98d20ef9f32676cbe.tar.gz dexon-sol-tools-10e6c3cd906c6625ed0c9ae98d20ef9f32676cbe.tar.zst dexon-sol-tools-10e6c3cd906c6625ed0c9ae98d20ef9f32676cbe.zip | |
feat: remove isValidProvided orders validation
Diffstat (limited to 'packages/asset-buyer')
| -rw-r--r-- | packages/asset-buyer/src/asset_buyer.ts | 1 | ||||
| -rw-r--r-- | packages/asset-buyer/src/utils/assert.ts | 15 | 
2 files changed, 0 insertions, 16 deletions
| diff --git a/packages/asset-buyer/src/asset_buyer.ts b/packages/asset-buyer/src/asset_buyer.ts index 34e2d9639..ed52f2d9d 100644 --- a/packages/asset-buyer/src/asset_buyer.ts +++ b/packages/asset-buyer/src/asset_buyer.ts @@ -56,7 +56,6 @@ export class AssetBuyer {      ): AssetBuyer {          assert.isWeb3Provider('provider', provider);          assert.doesConformToSchema('orders', orders, schemas.signedOrdersSchema); -        assert.areValidProvidedOrders('orders', orders);          assert.assert(orders.length !== 0, `Expected orders to contain at least one order`);          const orderProvider = new BasicOrderProvider(orders);          const assetBuyer = new AssetBuyer(provider, orderProvider, options); diff --git a/packages/asset-buyer/src/utils/assert.ts b/packages/asset-buyer/src/utils/assert.ts index e8cb7f763..7e4eb7175 100644 --- a/packages/asset-buyer/src/utils/assert.ts +++ b/packages/asset-buyer/src/utils/assert.ts @@ -31,21 +31,6 @@ export const assert = {          sharedAssert.isHexString(`${variableName}.takerAssetData`, orderFetcherRequest.takerAssetData);          sharedAssert.isNumber(`${variableName}.networkId`, orderFetcherRequest.networkId);      }, -    areValidProvidedOrders(variableName: string, orders: SignedOrder[]): void { -        if (orders.length === 0) { -            return; -        } -        const makerAssetData = orders[0].makerAssetData; -        const takerAssetData = orders[0].takerAssetData; -        const filteredOrders = _.filter( -            orders, -            order => order.makerAssetData === makerAssetData && order.takerAssetData === takerAssetData, -        ); -        sharedAssert.assert( -            orders.length === filteredOrders.length, -            `Expected all orders in ${variableName} to have the same makerAssetData and takerAssetData.`, -        ); -    },      isValidPercentage(variableName: string, percentage: number): void {          assert.isNumber(variableName, percentage);          assert.assert( | 
