aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorcpm <cpm@FreeBSD.org>2017-09-13 10:27:36 +0800
committercpm <cpm@FreeBSD.org>2017-09-13 10:27:36 +0800
commit67d706635dc7e0da0d5b0d35d7a2203ab2bb8ccc (patch)
tree266846928053e0ac78bd3f562cec4b843a6544e6
parentcaa1cdb1c21db02c5d4966de16d6675f6aeb2b36 (diff)
downloadfreebsd-ports-gnome-67d706635dc7e0da0d5b0d35d7a2203ab2bb8ccc.tar.gz
freebsd-ports-gnome-67d706635dc7e0da0d5b0d35d7a2203ab2bb8ccc.tar.zst
freebsd-ports-gnome-67d706635dc7e0da0d5b0d35d7a2203ab2bb8ccc.zip
deskutils/go-for-it: unbreak build with vala 0.36
/wrkdirs/usr/ports/deskutils/go-for-it/work/Go-For-It-release_v1.5/src/TaskStore.vala:89.22-89.25: error: Argument 1: Cannot pass value to reference or output parameter this.remove (iter); ^^^^ While I'm here, pet portlint, USE_* comes before USES PR: 222036 Submitted by: cpm Approved by: Neel Chauhan <neel@neelc.org> (maintainer)
-rw-r--r--deskutils/go-for-it/Makefile10
-rw-r--r--deskutils/go-for-it/files/patch-src_TaskStore.vala14
2 files changed, 19 insertions, 5 deletions
diff --git a/deskutils/go-for-it/Makefile b/deskutils/go-for-it/Makefile
index 3ab62f905c16..6a96a0e5b078 100644
--- a/deskutils/go-for-it/Makefile
+++ b/deskutils/go-for-it/Makefile
@@ -14,15 +14,15 @@ LICENSE_FILE= ${WRKSRC}/COPYING
BUILD_DEPENDS= valac:lang/vala
LIB_DEPENDS= libnotify.so:devel/libnotify
-USE_GITHUB= yes
-GH_ACCOUNT= mank319
-GH_PROJECT= Go-For-It
-
-GNU_CONFIGURE= yes
USES= cmake gettext pkgconfig
USE_GNOME= cairo glib20 gtk30
+GNU_CONFIGURE= yes
INSTALLS_ICONS= yes
+USE_GITHUB= yes
+GH_ACCOUNT= mank319
+GH_PROJECT= Go-For-It
+
post-install:
${INSTALL_DATA} ${WRKSRC}/data/go-for-it.desktop \
${STAGEDIR}${PREFIX}/share/applications
diff --git a/deskutils/go-for-it/files/patch-src_TaskStore.vala b/deskutils/go-for-it/files/patch-src_TaskStore.vala
new file mode 100644
index 000000000000..febf49197355
--- /dev/null
+++ b/deskutils/go-for-it/files/patch-src_TaskStore.vala
@@ -0,0 +1,14 @@
+--- src/TaskStore.vala.orig 2016-12-18 13:54:36 UTC
++++ src/TaskStore.vala
+@@ -86,7 +86,11 @@ class TaskStore : Gtk.ListStore {
+ public void remove_task (Gtk.TreeIter iter) {
+ bool is_active_task = compare_tasks (iter);
+ var _active_task = active_task;
++#if VALA_0_36
++ this.remove (ref iter);
++#else
+ this.remove (iter);
++#endif
+ if (is_active_task && _active_task == active_task) {
+ active_task = null;
+ refresh_active_task ();