aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorjoe <joe@FreeBSD.org>2001-11-19 09:16:52 +0800
committerjoe <joe@FreeBSD.org>2001-11-19 09:16:52 +0800
commit3ed8e094bd0b90c109b7b92747fc0699e9faf870 (patch)
tree9e9964db505b51335cf68d3665c7f07f3a01f21b
parenta889e6714032340fa3d2005c2eb3a10d0a92b56b (diff)
downloadfreebsd-ports-gnome-3ed8e094bd0b90c109b7b92747fc0699e9faf870.tar.gz
freebsd-ports-gnome-3ed8e094bd0b90c109b7b92747fc0699e9faf870.tar.zst
freebsd-ports-gnome-3ed8e094bd0b90c109b7b92747fc0699e9faf870.zip
Make it clear that the $COMMITCHECK_EXTRA check should return true
if everything is ok.
-rwxr-xr-xCVSROOT/cfg.pm3
-rw-r--r--CVSROOT/cfg_local.pm3
2 files changed, 4 insertions, 2 deletions
diff --git a/CVSROOT/cfg.pm b/CVSROOT/cfg.pm
index c6ac81a94ca3..0979f8d01e98 100755
--- a/CVSROOT/cfg.pm
+++ b/CVSROOT/cfg.pm
@@ -69,7 +69,8 @@ $MINCVSVERSION = "1090900"; # 1.9.9p0
# Additional commit time checks. This is an anonymous subroutine
# that gets called early on in the validation process to see whether
-# the committer is allowed to commit.
+# the committer is allowed to commit. It should return true if
+# everything is ok, otherwise the commit will be terminated.
$COMMITCHECK_EXTRA = "";
diff --git a/CVSROOT/cfg_local.pm b/CVSROOT/cfg_local.pm
index 1cb7e92c79d5..c519f1df2a16 100644
--- a/CVSROOT/cfg_local.pm
+++ b/CVSROOT/cfg_local.pm
@@ -38,7 +38,8 @@ $COMMITCHECK_EXTRA = sub {
chomp $GRP;
unless ( $GRP =~ /^ncvs$/ ) {
print "You do not have group ncvs (commitcheck)!\n";
- #exit 1;
+ exit 1; # We could return false here. But there's
+ # nothing to stop us taking action here instead.
}
return 1;
};