Switch libpololu-avr port to GitHub sources.

The zip files released on the Pololu website confuse portscout
(which thinks there should be a new version every day!) and use a
non-standard directory hierarchy, which requires WRKSRC to be set.
Switching to the GitHub releases (which are created by the same company,
just using GitHub mechanisms) solves both of these problems.

Also, fix some problems pointed out by mat (thanks!) that I ought to have
caught earlier by running `portlint -A`. :(

Approved by:	mat
Differential Revision:	https://reviews.freebsd.org/D7879

3 files changed, 68 insertions, 71 deletions

diff --git a/devel/libpololu-avr/Makefile b/devel/libpololu-avr/Makefile
index af1cf6000474..3493677bd864 100644
--- a/devel/libpololu-avr/Makefile
+++ b/devel/libpololu-avr/Makefile
@@ -3,23 +3,20 @@
 PORTNAME=	libpololu-avr
 PORTVERSION=	151002
 CATEGORIES=	devel
-MASTER_SITES=	http://www.pololu.com/file/download/
-EXTRACT_SUFX=	.zip?file_id=0J1058
 
 MAINTAINER=	jonathan@FreeBSD.org
 COMMENT=	Support libraries for Pololu robots
 
 LICENSE=	MIT
 
-BUILD_DEPENDS=	avr-gcc:devel/avr-gcc \
-		${LOCALBASE}/avr/lib/libc.a:devel/avr-libc
+BUILD_DEPENDS=	${LOCALBASE}/avr/lib/libc.a:devel/avr-libc
+RUN_DEPENDS=	${LOCALBASE}/avr/lib/libc.a:devel/avr-libc
 
-USES=		gmake zip
+USES=		gmake
+USE_GITHUB=	yes
+GH_ACCOUNT=	pololu
 
-PREFIX=		${LOCALBASE}/avr
-
-WRKSRC=		${WRKDIR}/${PORTNAME}
-MAKE_ENV=	LIB=${STAGEDIR}${PREFIX}/lib
+MAKE_ENV=	LIB=${STAGEDIR}${PREFIX}/avr/lib
 ALL_TARGET=	library_files
 
 .include <bsd.port.mk>
diff --git a/devel/libpololu-avr/distinfo b/devel/libpololu-avr/distinfo
index 75bb26ba37ad..81bcbdd4c0d2 100644
--- a/devel/libpololu-avr/distinfo
+++ b/devel/libpololu-avr/distinfo
@@ -1,3 +1,3 @@
-TIMESTAMP = 1463111178
-SHA256 (libpololu-avr-151002.zip?file_id=0J1058) = 206131a5ca094d83917c5c51dc2f99d5278fc13a0bb248e03196b4450902023d
-SIZE (libpololu-avr-151002.zip?file_id=0J1058) = 3101379
+TIMESTAMP = 1473775580
+SHA256 (pololu-libpololu-avr-151002_GH0.tar.gz) = a049f22a0d8437cc7d3f96e6dbeadcac084029c966efda26c8016d4bea67ea7f
+SIZE (pololu-libpololu-avr-151002_GH0.tar.gz) = 356586
diff --git a/devel/libpololu-avr/pkg-plist b/devel/libpololu-avr/pkg-plist
index 4f1317bd156d..150aa4e7b415 100644
--- a/devel/libpololu-avr/pkg-plist
+++ b/devel/libpololu-avr/pkg-plist
@@ -1,59 +1,59 @@
-include/pololu/3pi.h
-include/pololu/OrangutanAnalog.h
-include/pololu/OrangutanAnalog/OrangutanAnalog.h
-include/pololu/OrangutanBuzzer.h
-include/pololu/OrangutanBuzzer/OrangutanBuzzer.h
-include/pololu/OrangutanDigital.h
-include/pololu/OrangutanDigital/OrangutanDigital.h
-include/pololu/OrangutanLCD.h
-include/pololu/OrangutanLCD/OrangutanLCD.h
-include/pololu/OrangutanLEDs.h
-include/pololu/OrangutanLEDs/OrangutanLEDs.h
-include/pololu/OrangutanMotors.h
-include/pololu/OrangutanMotors/OrangutanMotors.h
-include/pololu/OrangutanPulseIn.h
-include/pololu/OrangutanPulseIn/OrangutanPulseIn.h
-include/pololu/OrangutanPushbuttons.h
-include/pololu/OrangutanPushbuttons/OrangutanPushbuttons.h
-include/pololu/OrangutanResources.h
-include/pololu/OrangutanResources/OrangutanResources.h
-include/pololu/OrangutanResources/include/OrangutanModel.h
-include/pololu/OrangutanSPIMaster/OrangutanSPIMaster.h
-include/pololu/OrangutanSVP/OrangutanSVP.h
-include/pololu/OrangutanSerial.h
-include/pololu/OrangutanSerial/OrangutanSerial.h
-include/pololu/OrangutanServos.h
-include/pololu/OrangutanServos/OrangutanServos.h
-include/pololu/OrangutanTime.h
-include/pololu/OrangutanTime/OrangutanTime.h
-include/pololu/OrangutanX2/OrangutanX2.h
-include/pololu/Pololu3pi.h
-include/pololu/Pololu3pi/Pololu3pi.h
-include/pololu/PololuQTRSensors.h
-include/pololu/PololuQTRSensors/PololuQTRSensors.h
-include/pololu/PololuWheelEncoders.h
-include/pololu/PololuWheelEncoders/PololuWheelEncoders.h
-include/pololu/analog.h
-include/pololu/buzzer.h
-include/pololu/digital.h
-include/pololu/encoders.h
-include/pololu/lcd.h
-include/pololu/leds.h
-include/pololu/motors.h
-include/pololu/orangutan
-include/pololu/orangutan.h
-include/pololu/pulsein.h
-include/pololu/pushbuttons.h
-include/pololu/qtr.h
-include/pololu/resources.h
-include/pololu/serial.h
-include/pololu/servos.h
-include/pololu/time.h
-include/pololu/workaround.h
-lib/libpololu_atmega1284p.a
-lib/libpololu_atmega1284p_x2.a
-lib/libpololu_atmega168.a
-lib/libpololu_atmega324p.a
-lib/libpololu_atmega328p.a
-lib/libpololu_atmega48.a
-lib/libpololu_atmega644p.a
+avr/include/pololu/3pi.h
+avr/include/pololu/OrangutanAnalog.h
+avr/include/pololu/OrangutanAnalog/OrangutanAnalog.h
+avr/include/pololu/OrangutanBuzzer.h
+avr/include/pololu/OrangutanBuzzer/OrangutanBuzzer.h
+avr/include/pololu/OrangutanDigital.h
+avr/include/pololu/OrangutanDigital/OrangutanDigital.h
+avr/include/pololu/OrangutanLCD.h
+avr/include/pololu/OrangutanLCD/OrangutanLCD.h
+avr/include/pololu/OrangutanLEDs.h
+avr/include/pololu/OrangutanLEDs/OrangutanLEDs.h
+avr/include/pololu/OrangutanMotors.h
+avr/include/pololu/OrangutanMotors/OrangutanMotors.h
+avr/include/pololu/OrangutanPulseIn.h
+avr/include/pololu/OrangutanPulseIn/OrangutanPulseIn.h
+avr/include/pololu/OrangutanPushbuttons.h
+avr/include/pololu/OrangutanPushbuttons/OrangutanPushbuttons.h
+avr/include/pololu/OrangutanResources.h
+avr/include/pololu/OrangutanResources/OrangutanResources.h
+avr/include/pololu/OrangutanResources/include/OrangutanModel.h
+avr/include/pololu/OrangutanSPIMaster/OrangutanSPIMaster.h
+avr/include/pololu/OrangutanSVP/OrangutanSVP.h
+avr/include/pololu/OrangutanSerial.h
+avr/include/pololu/OrangutanSerial/OrangutanSerial.h
+avr/include/pololu/OrangutanServos.h
+avr/include/pololu/OrangutanServos/OrangutanServos.h
+avr/include/pololu/OrangutanTime.h
+avr/include/pololu/OrangutanTime/OrangutanTime.h
+avr/include/pololu/OrangutanX2/OrangutanX2.h
+avr/include/pololu/Pololu3pi.h
+avr/include/pololu/Pololu3pi/Pololu3pi.h
+avr/include/pololu/PololuQTRSensors.h
+avr/include/pololu/PololuQTRSensors/PololuQTRSensors.h
+avr/include/pololu/PololuWheelEncoders.h
+avr/include/pololu/PololuWheelEncoders/PololuWheelEncoders.h
+avr/include/pololu/analog.h
+avr/include/pololu/buzzer.h
+avr/include/pololu/digital.h
+avr/include/pololu/encoders.h
+avr/include/pololu/lcd.h
+avr/include/pololu/leds.h
+avr/include/pololu/motors.h
+avr/include/pololu/orangutan
+avr/include/pololu/orangutan.h
+avr/include/pololu/pulsein.h
+avr/include/pololu/pushbuttons.h
+avr/include/pololu/qtr.h
+avr/include/pololu/resources.h
+avr/include/pololu/serial.h
+avr/include/pololu/servos.h
+avr/include/pololu/time.h
+avr/include/pololu/workaround.h
+avr/lib/libpololu_atmega1284p.a
+avr/lib/libpololu_atmega1284p_x2.a
+avr/lib/libpololu_atmega168.a
+avr/lib/libpololu_atmega324p.a
+avr/lib/libpololu_atmega328p.a
+avr/lib/libpololu_atmega48.a
+avr/lib/libpololu_atmega644p.a