diff options
author | jbeich <jbeich@FreeBSD.org> | 2015-11-05 09:52:27 +0800 |
---|---|---|
committer | jbeich <jbeich@FreeBSD.org> | 2015-11-05 09:52:27 +0800 |
commit | c2afe7e0e57cc8307a10029aa7a665ef4195a3d9 (patch) | |
tree | b2d7a8d99d621a7b30425000f60bc92add88cfff /devel | |
parent | 482be554235c03507f01e4d589848666123d3a75 (diff) | |
download | freebsd-ports-gnome-c2afe7e0e57cc8307a10029aa7a665ef4195a3d9.tar.gz freebsd-ports-gnome-c2afe7e0e57cc8307a10029aa7a665ef4195a3d9.tar.zst freebsd-ports-gnome-c2afe7e0e57cc8307a10029aa7a665ef4195a3d9.zip |
devel/android-tools-adb: unbreak build on DragonFly
make(1) suffix rules discard original extension as used by bsd.*.mk
which leads to unpredictable behavior if more than one candidate is
found under ${.PATH}. So, partially qualify pathname to avoid
accidentally building libcutils/sockets.c despite SRCS=sockets.cpp
$ echo 'void foo() { }' > a.c
$ echo 'int main() { }' > a.cxx
$ make PROG_CXX=test SRCS=a.cxx NO_MAN= -f /usr/share/mk/bsd.prog.mk
cc -O -pipe -std=gnu99 -c a.c
c++ -O -pipe -o test a.o
/usr/lib/crt1.o: In function `_start':
crt1.c:(.text+0x132): undefined reference to `main'
*** Error code 1
which in adb case leads to (since partial C++ conversion in 6.0.0)
adb.o: In function `handle_packet(apacket*, atransport*)':
adb.cpp:(.text+0x2518): undefined reference to `find_local_socket(unsigned int, unsigned int)'
adb.cpp:(.text+0x2613): undefined reference to `find_local_socket(unsigned int, unsigned int)'
adb.cpp:(.text+0x276a): undefined reference to `find_local_socket(unsigned int, unsigned int)'
adb.cpp:(.text+0x2875): undefined reference to `create_local_service_socket(char const*)'
adb.cpp:(.text+0x288c): undefined reference to `create_remote_socket(unsigned int, atransport*)'
adb.cpp:(.text+0x2a41): undefined reference to `create_remote_socket(unsigned int, atransport*)'
adb_listeners.o: In function `listener_event_func(int, unsigned int, void*)':
adb_listeners.cpp:(.text+0xe2): undefined reference to `create_local_socket(int)'
adb_listeners.cpp:(.text+0xfe): undefined reference to `connect_to_remote(asocket*, char const*)'
adb_listeners.o: In function `ss_listener_event_func(int, unsigned int, void*)':
adb_listeners.cpp:(.text+0x1b1): undefined reference to `create_local_socket(int)'
adb_listeners.cpp:(.text+0x1be): undefined reference to `connect_to_smartsocket(asocket*)'
services.o: In function `host_service_to_socket(char const*, char const*)':
services.cpp:(.text+0x64d): undefined reference to `create_local_socket(int)'
services.cpp:(.text+0x6b7): undefined reference to `create_local_socket(int)'
transport.o: In function `input_thread(void*)':
transport.cpp:(.text+0x1931): undefined reference to `close_all_sockets(atransport*)'
*** [adb] Error code 1
Diffstat (limited to 'devel')
-rw-r--r-- | devel/android-tools-adb/files/Makefile | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/devel/android-tools-adb/files/Makefile b/devel/android-tools-adb/files/Makefile index 62f339bc4b55..4bf841d1fb66 100644 --- a/devel/android-tools-adb/files/Makefile +++ b/devel/android-tools-adb/files/Makefile @@ -20,7 +20,8 @@ SRCS+= console.cpp SRCS+= fdevent.cpp SRCS+= file_sync_client.cpp SRCS+= services.cpp -SRCS+= sockets.cpp +# XXX SuffFindDeps may fail to restore suffix lost in transformation +SRCS+= ../adb/sockets.cpp SRCS+= transport.cpp SRCS+= transport_local.cpp SRCS+= transport_usb.cpp |