Build and install a shared library and its frontend besides static one

by default.

[HEADS UP] The python executable and static library isn't built PIC
anymore even on amd64 and ia64. Please use a shared library instead.

Requested by:	jhay, dd
Tested by:	Charles Swiger <cswiger@mac.com>,
		Tim Middleton <x@Vex.Net>

2 files changed, 51 insertions, 20 deletions

diff --git a/lang/python23/Makefile b/lang/python23/Makefile
index 6916723136ba..0abf42bce5ff 100644
--- a/lang/python23/Makefile
+++ b/lang/python23/Makefile
@@ -7,7 +7,7 @@
 
 PORTNAME=	python
 PORTVERSION=	2.3.3
-PORTREVISION=	2
+PORTREVISION=	3
 CATEGORIES=	lang python ipv6
 MASTER_SITES=	${PYTHON_MASTER_SITES}
 MASTER_SITE_SUBDIR=	${PYTHON_MASTER_SITE_SUBDIR}
@@ -23,6 +23,7 @@ GNU_CONFIGURE=	yes
 CONFIGURE_ARGS=	--with-fpectl
 CONFIGURE_ENV=	OPT="${CFLAGS}"
 MAKE_ENV=	VPATH="${WRKSRC}"
+INSTALLS_SHLIB=	yes
 INSTALL_TARGET=	install
 MAN1=		python.1
 
@@ -31,6 +32,11 @@ PYTHON_VERSION=	python2.3
 PYTHON_NO_DEPENDS=	yes
 USE_REINPLACE=	yes
 
+SHARED_WRKSRC=	${WRKSRC}/build.shared
+PLIST_SUB=	PYVER=${PYTHON_VERSION:S/python//}
+DEMODIR=	${PREFIX}/share/examples/${PYTHON_VERSION}
+TOOLSDIR=	${PREFIX}/share/${PYTHON_VERSION}
+
 #
 # If you don't want to use Python's thread module, you need to set
 # WITHOUT_THREADS.
@@ -59,17 +65,6 @@ CONFIGURE_ARGS+=	--enable-unicode=ucs4
 CONFIGURE_ARGS+=	--without-pymalloc
 .endif
 
-.if defined(BUILD_SHARED)
-CONFIGURE_ARGS+=	--enable-shared
-INSTALLS_SHLIB=		yes
-PLIST_SUB+=		SHARED_ONLY=""
-.else
-PLIST_SUB+=		SHARED_ONLY="@comment "
-.endif
-
-DEMODIR=	${PREFIX}/share/examples/${PYTHON_VERSION}
-TOOLSDIR=	${PREFIX}/share/${PYTHON_VERSION}
-
 .include <bsd.port.pre.mk>
 
 .if ${ARCH} == i386
@@ -77,9 +72,6 @@ PLIST_SUB+=	X86_ONLY=""
 .else
 PLIST_SUB+=	X86_ONLY="@comment "
 .endif
-.if ${ARCH} == amd64 || ${ARCH} == ia64
-CFLAGS+=	-fPIC
-.endif
 .if ${ARCH} == amd64 || ${ARCH} == ia64 || ${ARCH} == sparc64 || ${ARCH} == alpha
 PLIST_SUB+=	32BIT_ONLY="@comment "
 .else
@@ -129,6 +121,31 @@ pre-patch:
 		's,/usr/doc/python-docs-,${PREFIX}/share/doc/python,g' \
 		${WRKSRC}/Lib/pydoc.py
 
+post-configure:
+	@# prepare a subdir for shared build
+.for subdir in Modules Parser Python Objects
+	${MKDIR} ${SHARED_WRKSRC}/${subdir}
+.endfor
+	${SED} -e 's,^\(LDLIBRARY=\).*$$,\1libpython$$(VERSION).so,' \
+		-e 's,^\(BLDLIBRARY=\).*$$,\1-L. -lpython$$(VERSION),' \
+		-e 's,^\(CFLAGSFORSHARED=\).*$$,\1$$(CCSHARED),' \
+		-e 's,^\(Makefile Modules/config.c:.*\)Makefile.pre,\1,' \
+		${WRKSRC}/Makefile > ${SHARED_WRKSRC}/Makefile
+	${LN} -sf ${WRKSRC}/pyconfig.h ${WRKSRC}/Include ${WRKSRC}/Grammar \
+		${SHARED_WRKSRC}/
+	${LN} -sf ${WRKSRC}/Python/getplatform.c ${WRKSRC}/Python/importdl.c \
+		${WRKSRC}/Python/importdl.h \
+		${SHARED_WRKSRC}/Python/
+	${LN} -sf ${WRKSRC}/Modules/makesetup ${WRKSRC}/Modules/Setup* \
+		${WRKSRC}/Modules/*.c ${WRKSRC}/Modules/*.h \
+		${SHARED_WRKSRC}/Modules/
+
+post-build:
+	cd ${SHARED_WRKSRC}; \
+	${SETENV} ${MAKE_ENV} ${MAKE} lib${PYTHON_VERSION}.so python; \
+	${LN} -f lib${PYTHON_VERSION}.so lib${PYTHON_VERSION}.so.1; \
+	${LN} -f python ${PYTHON_VERSION:S/thon/thon-shared/}
+
 pre-install:
 .for platform in ${PLATFORMS}
 	${MKDIR} ${PYTHONPREFIX_LIBDIR}/${platform}
@@ -139,6 +156,18 @@ pre-install:
 .endfor
 
 post-install:
+	@# shared version of executable and library
+	${INSTALL_PROGRAM} ${SHARED_WRKSRC}/lib${PYTHON_VERSION}.so.1 \
+		${PREFIX}/lib
+	cd ${PREFIX}/lib; ${LN} -sf lib${PYTHON_VERSION}.so.1 \
+		lib${PYTHON_VERSION}.so
+	${INSTALL_PROGRAM} \
+		${SHARED_WRKSRC}/${PYTHON_VERSION:S/thon/thon-shared/} \
+		${PREFIX}/bin
+	cd ${PREFIX}/bin; \
+		${LN} -f ${PYTHON_VERSION:S/thon/thon-shared/} python-shared
+
+	@# additional files installing by ports
 	${INSTALL_DATA} ${WRKSRC}/Misc/python-mode.el \
 		${PREFIX}/share/emacs/site-lisp
 	${INSTALL_SCRIPT} ${WRKDIR}/pydoc2.3 ${WRKDIR}/idle2.3 \
diff --git a/lang/python23/pkg-plist b/lang/python23/pkg-plist
index b8b65cfee54a..8c98879909d2 100644
--- a/lang/python23/pkg-plist
+++ b/lang/python23/pkg-plist
@@ -1,9 +1,11 @@
 bin/idle
-bin/idle2.3
+bin/idle%%PYVER%%
 bin/pydoc
-bin/pydoc2.3
+bin/pydoc%%PYVER%%
 bin/python
-bin/%%PYTHON_VERSION%%
+bin/python%%PYVER%%
+bin/python-shared
+bin/python-shared%%PYVER%%
 include/%%PYTHON_VERSION%%/Python.h
 include/%%PYTHON_VERSION%%/abstract.h
 include/%%PYTHON_VERSION%%/bitset.h
@@ -75,8 +77,8 @@ include/%%PYTHON_VERSION%%/tupleobject.h
 include/%%PYTHON_VERSION%%/ucnhash.h
 include/%%PYTHON_VERSION%%/unicodeobject.h
 include/%%PYTHON_VERSION%%/weakrefobject.h
-%%SHARED_ONLY%%lib/lib%%PYTHON_VERSION%%.so
-%%SHARED_ONLY%%lib/lib%%PYTHON_VERSION%%.so.1
+lib/lib%%PYTHON_VERSION%%.so
+lib/lib%%PYTHON_VERSION%%.so.1
 lib/%%PYTHON_VERSION%%/BaseHTTPServer.py
 lib/%%PYTHON_VERSION%%/BaseHTTPServer.pyc
 lib/%%PYTHON_VERSION%%/BaseHTTPServer.pyo