aboutsummaryrefslogtreecommitdiffstats
path: root/misc
diff options
context:
space:
mode:
authorasami <asami@FreeBSD.org>1995-08-29 19:57:40 +0800
committerasami <asami@FreeBSD.org>1995-08-29 19:57:40 +0800
commit1891698702fa4116b75fc7322b1b09c4965f2889 (patch)
treeb25a155b64bd958526ac74b6e61f261b12c9cefc /misc
parent389d073fd5c8df8a20a61938a312da9fea0727f8 (diff)
downloadfreebsd-ports-gnome-1891698702fa4116b75fc7322b1b09c4965f2889.tar.gz
freebsd-ports-gnome-1891698702fa4116b75fc7322b1b09c4965f2889.tar.zst
freebsd-ports-gnome-1891698702fa4116b75fc7322b1b09c4965f2889.zip
Don't trust ncftp's exit status, they are not indicative of whether
the file is fetched or not. Apparently Jordan fixed it a long time ago but it was broken again at import of the new version of ncftp. Which means even if we fix it, it may break again and we may need to fix it again, and (imagination here, please).... Instead, move the file existence check into the for loop for MASTER_SITES/PATCH_SITES and break out with "continue 2" when the file is found. This is actually a cleaner logic than before if you ask me, because instead of assuming the file is fetched on a 0 exit status from ncftp AND checking for the existence of the file after the loop, the check is done exactly once for each iteration and nowhere else.
Diffstat (limited to 'misc')
0 files changed, 0 insertions, 0 deletions