diff options
| author | lioux <lioux@FreeBSD.org> | 2003-03-05 08:11:23 +0800 |
|---|---|---|
| committer | lioux <lioux@FreeBSD.org> | 2003-03-05 08:11:23 +0800 |
| commit | 39e8f200a81243850f7094b02db5eae97b5140e0 (patch) | |
| tree | 6801fa52ec25a90f0b88328ac5fbfa71c7907d8d /multimedia/mplayer | |
| parent | 8edd80b2a203c8a90502f2358fe9a8b3a433d2cd (diff) | |
| download | freebsd-ports-gnome-39e8f200a81243850f7094b02db5eae97b5140e0.tar.gz freebsd-ports-gnome-39e8f200a81243850f7094b02db5eae97b5140e0.tar.zst freebsd-ports-gnome-39e8f200a81243850f7094b02db5eae97b5140e0.zip | |
o Fix outstanding issue with KDE aRts: do not lockup when exitting
- Background: For some reason, mplayer locks up if we cleanup
when exitting by calling arts_free(). Therefore, we trade
risk of memory leakage when using KDE aRts over locking
up.
- Caveat: Memory probably is not witheld after mplayer
exits. I won't say that it IS NOT withheld cause I do not
know what arts_free() does exactly. So, worst case scenario
is probably that we will leak memory for as many files
the user tells mplayer to play but only WHILE mplayer is
running.
o Bump PORTREVISION
Reviewed by: kde (some members)
Diffstat (limited to 'multimedia/mplayer')
| -rw-r--r-- | multimedia/mplayer/Makefile | 2 | ||||
| -rw-r--r-- | multimedia/mplayer/files/patch-libao2-ao_arts.c | 18 |
2 files changed, 19 insertions, 1 deletions
diff --git a/multimedia/mplayer/Makefile b/multimedia/mplayer/Makefile index 0e7e1c59a50e..f4465888e690 100644 --- a/multimedia/mplayer/Makefile +++ b/multimedia/mplayer/Makefile @@ -146,7 +146,7 @@ PORTNAME= mplayer PORTVERSION= 0.90.0.104 -PORTREVISION= 1 +PORTREVISION= 2 CATEGORIES= multimedia audio MASTER_SITES= http://www1.mplayerhq.hu/MPlayer/releases/ \ http://www2.mplayerhq.hu/MPlayer/releases/ \ diff --git a/multimedia/mplayer/files/patch-libao2-ao_arts.c b/multimedia/mplayer/files/patch-libao2-ao_arts.c new file mode 100644 index 000000000000..f66c40661213 --- /dev/null +++ b/multimedia/mplayer/files/patch-libao2-ao_arts.c @@ -0,0 +1,18 @@ +--- libao2/ao_arts.c.orig Fri Dec 27 14:35:07 2002 ++++ libao2/ao_arts.c Mon Mar 3 17:10:38 2003 +@@ -102,8 +102,14 @@ + + static void uninit() + { +- arts_close_stream(stream); ++ if (stream != NULL) { ++ arts_close_stream(stream); ++ stream = NULL; ++ } ++/* XXX - we get "MPlayer interrupted by signal 11 in module: ++ exit_player" unless commented :( + arts_free(); ++*/ + } + + static int play(void* data,int len,int flags) |