diff options
author | tcberner <tcberner@FreeBSD.org> | 2018-11-29 05:13:54 +0800 |
---|---|---|
committer | tcberner <tcberner@FreeBSD.org> | 2018-11-29 05:13:54 +0800 |
commit | fd0e5c1143676073d471c919ca0d9597de10b196 (patch) | |
tree | 0e6f35b1dfe9635d99fc2bc6acd1ef35e1ff8344 /net | |
parent | 32ad6ef5f2f22c77b3b1043bb05b7fcc2d574430 (diff) | |
download | freebsd-ports-gnome-fd0e5c1143676073d471c919ca0d9597de10b196.tar.gz freebsd-ports-gnome-fd0e5c1143676073d471c919ca0d9597de10b196.tar.zst freebsd-ports-gnome-fd0e5c1143676073d471c919ca0d9597de10b196.zip |
net/messagelib: address CVE-2018-19516
messagelib is the library used by KMail to display emails.
messagelib by default displays emails as plain text, but gives the user
an option to "Prefer HTML to plain text" in the settings and if that option
is not enabled there is way to enable HTML display when an email contains HTML.
Some HTML emails can trick messagelib into opening a new browser window when
displaying said email as HTML.
This happens even if the option to allow the HTML emails to access
remote servers is disabled in KMail settings.
This means that the owners of the servers referred in the email can see
in their access logs your IP address.
https://www.kde.org/info/security/advisory-20181128-1.txt
MFH: 2018Q4
Security: c7b1af20-f34f-11e8-9cde-e0d55e2a8bf9
Diffstat (limited to 'net')
-rw-r--r-- | net/messagelib/Makefile | 2 | ||||
-rw-r--r-- | net/messagelib/files/patch-git_347659 | 19 |
2 files changed, 20 insertions, 1 deletions
diff --git a/net/messagelib/Makefile b/net/messagelib/Makefile index 1b2eee62a045..d8422548782b 100644 --- a/net/messagelib/Makefile +++ b/net/messagelib/Makefile @@ -2,7 +2,7 @@ PORTNAME= messagelib DISTVERSION= ${KDE_APPLICATIONS_VERSION} -PORTREVISION= 1 +PORTREVISION= 2 CATEGORIES= net kde kde-applications MAINTAINER= kde@FreeBSD.org diff --git a/net/messagelib/files/patch-git_347659 b/net/messagelib/files/patch-git_347659 new file mode 100644 index 000000000000..97a32cabd4a5 --- /dev/null +++ b/net/messagelib/files/patch-git_347659 @@ -0,0 +1,19 @@ +From 34765909cdf8e55402a8567b48fb288839c61612 Mon Sep 17 00:00:00 2001 +From: Laurent Montel <montel@kde.org> +Date: Fri, 23 Nov 2018 07:37:02 +0100 +Subject: Exclude Refresh from MetaData (Not necessary) + +--- messageviewer/src/messagepartthemes/default/defaultrenderer.cpp.orig 2018-10-31 06:56:07 UTC ++++ messageviewer/src/messagepartthemes/default/defaultrenderer.cpp +@@ -308,6 +308,11 @@ QString processHtml(const QString &htmlSource, QString + return htmlSource; + } + extraHead = s.mid(startIndex + 6 , endIndex - startIndex - 6); ++ //Don't authorize to refresh content. ++ if (s.contains(QStringLiteral("http-equiv=\"REFRESH\""), Qt::CaseInsensitive)) { ++ extraHead.clear(); ++ } ++ + s = s.mid(endIndex + 7).trimmed(); + } + |