Remove painful examples of foo="", with particular prejudice against

constructions that parse out to [ -z "$foo" ] && foo=""

These are bad examples that get copied and pasted into new code, so the
hope is that with less bad examples there will be less need for me to
bring this up in review.

In a few of these files all that were changed were comments so that next
time I search for these patterns I won't trip on the file for no reason.

In a few places, add $FreeBSD$

No functional changes, so no PORTREVISION bumps

9 files changed, 8 insertions, 12 deletions

diff --git a/sysutils/ganglia-monitor-core/files/ganglia.sh.in b/sysutils/ganglia-monitor-core/files/ganglia.sh.in
index 9207440d9a49..724415f2b0c0 100644
--- a/sysutils/ganglia-monitor-core/files/ganglia.sh.in
+++ b/sysutils/ganglia-monitor-core/files/ganglia.sh.in
@@ -18,7 +18,7 @@ gmetasnap_enable="${gmetasnap_enable-NO}"
 gmetasnap_rrddir="/var/db/ganglia/rrds"
 gmetasnap_snapdir="/var/db/ganglia/snaps"
 gmetasnap_snapname="snap"
-# gmetasnap_flags=""
+# gmetasnap_flags=
 gmetasnap_command="%%PREFIX%%/sbin/gmetasnap"
 
 ### gmond ###
diff --git a/sysutils/msyslog/files/msyslogd.sh.in b/sysutils/msyslog/files/msyslogd.sh.in
index ef915048a965..1cdd90a231fd 100644
--- a/sysutils/msyslog/files/msyslogd.sh.in
+++ b/sysutils/msyslog/files/msyslogd.sh.in
@@ -13,7 +13,7 @@
 #
 # Yes, here you can pass arguments to daemon
 #
-# msyslogd_flags=""
+# msyslogd_flags=
 #
 
 . /etc/rc.subr
diff --git a/sysutils/p5-Tail-Stat/files/tstatd.in b/sysutils/p5-Tail-Stat/files/tstatd.in
index fa985d68052f..72ddd33afc28 100644
--- a/sysutils/p5-Tail-Stat/files/tstatd.in
+++ b/sysutils/p5-Tail-Stat/files/tstatd.in
@@ -30,7 +30,6 @@ rcvar=${name}_enable
 load_rc_config ${name}
 
 : ${tstatd_enable="NO"}
-: ${tstatd_profiles=""}
 
 command=%%PREFIX%%/bin/tstatd
 
diff --git a/sysutils/puppet/files/puppetmaster.in b/sysutils/puppet/files/puppetmaster.in
index 9cf60b580000..1f48c01e3b73 100644
--- a/sysutils/puppet/files/puppetmaster.in
+++ b/sysutils/puppet/files/puppetmaster.in
@@ -21,7 +21,6 @@ load_rc_config "${name}"
 : ${puppetmaster_enable="NO"}
 : ${puppetmaster_rundir="%%PUPPET_RUNDIR%%"}
 : ${puppetmaster_flags="--rundir=${puppetmaster_rundir}"}
-: ${puppetmaster_mongrel_ports=""}
 
 command_interpreter="%%PREFIX%%/bin/ruby18"
 command="%%PREFIX%%/bin/puppet"
diff --git a/sysutils/radmind/files/radmind.sh.in b/sysutils/radmind/files/radmind.sh.in
index 97b889f26cfc..d0b0a3d5e327 100644
--- a/sysutils/radmind/files/radmind.sh.in
+++ b/sysutils/radmind/files/radmind.sh.in
@@ -26,7 +26,6 @@ name=radmind
 rcvar=`set_rcvar`
 
 command=%%PREFIX%%/sbin/radmind
-command_args=""
 required_files=%%RADMIND_BASE_DIR%%/config
 
 # set defaults
diff --git a/sysutils/sec/files/sec.in b/sysutils/sec/files/sec.in
index 79a0fe47709c..5e51e53f8e5f 100644
--- a/sysutils/sec/files/sec.in
+++ b/sysutils/sec/files/sec.in
@@ -39,7 +39,6 @@ load_rc_config "${name}"
 [ -z "${sec_enable}" ]       && sec_enable="NO"
 [ -z "${sec_flags}" ]        && sec_flags="-log=/var/log/sec.log"
 [ -z "${sec_configfile}" ]   && sec_configfile="%%PREFIX%%/etc/sec.conf"
-[ -z "${sec_instances}" ]    && sec_instances=""
 
 sec_checkconfig() {
   if [ -z $instance ]
diff --git a/sysutils/torque/files/pbs_mom.sh.in b/sysutils/torque/files/pbs_mom.sh.in
index 79f1c78998c8..54ce27202ceb 100644
--- a/sysutils/torque/files/pbs_mom.sh.in
+++ b/sysutils/torque/files/pbs_mom.sh.in
@@ -1,5 +1,7 @@
 #!/bin/sh
 
+# $FreeBSD$
+#
 # PROVIDE: pbs_mom
 # REQUIRE: 
 #
@@ -22,6 +24,4 @@ load_rc_config $name
 
 : ${pbs_mom_enable="NO"}
 
-command_args=""
-
 run_rc_command "$1"
diff --git a/sysutils/torque/files/pbs_sched.sh.in b/sysutils/torque/files/pbs_sched.sh.in
index 58ee013f4a25..817d8a379146 100644
--- a/sysutils/torque/files/pbs_sched.sh.in
+++ b/sysutils/torque/files/pbs_sched.sh.in
@@ -1,5 +1,7 @@
 #!/bin/sh
 
+# $FreeBSD$
+#
 # PROVIDE: pbs_sched
 # REQUIRE: pbs_server
 #
@@ -22,6 +24,4 @@ load_rc_config $name
 
 : ${pbs_sched_enable="NO"}
 
-command_args=""
-
 run_rc_command "$1"
diff --git a/sysutils/torque/files/pbs_server.sh.in b/sysutils/torque/files/pbs_server.sh.in
index 946e34636be5..be367c7bbcf2 100644
--- a/sysutils/torque/files/pbs_server.sh.in
+++ b/sysutils/torque/files/pbs_server.sh.in
@@ -1,5 +1,7 @@
 #!/bin/sh
 
+# $FreeBSD$
+#
 # PROVIDE: pbs_server
 # REQUIRE: 
 #
@@ -22,6 +24,4 @@ load_rc_config $name
 
 : ${pbs_server_enable="NO"}
 
-command_args=""
-
 run_rc_command "$1"