converters/libiconv:

- Remove const qualifier from iconv(3) to match POSIX:
  http://pubs.opengroup.org/onlinepubs/9699919799/functions/iconv.html
- Patch iconv.h to expose more GNU extensions when LIBICONV_PLUG is
  defined because the base system iconv supports these extensions too.

Add/remove patches to/from ports to call iconv with non-const arguments.

This breaks some ports on FreeBSD 10 because base system iconv.h still has
the const qualifier.  Fix this by letting USES=iconv add a build dependency
on converters/libiconv so ports can use its iconv.h (with LIBICONV_PLUG
defined) instead of the base system iconv.h.

This exposed some ports that link with libiconv when it is available instead
of using libc iconv.  In these cases one of the following changes has been
made:
- patch configure scripts to test for libc iconv first
- add ac_cv_lib_iconv_libiconv=no or similar to CONFIGURE_ARGS to disable
  some configure tests
- converters/wkhtmltopdf: this includes Qt4 so add a patch from devel/qt4
- lang/gcc5-aux: respect CFLAGS and friends during configure such that
  LIBICONV_PLUG is defined in the iconv test, also switch to external
  gettext
- mail/gnarwl: replace patches with CPPFLAGS/LIBS
- multimedia/ffmpeg2theora: remove iconv test from SConstruct and use
  ICONV_LIB in port Makefile instead, also fix a bug in subtitles.c
- net-im/licq: finish conversion to cmake
- net-mgmt/bandwidthd, net-mgmt/icinga, net-mgmt/nagios, net-mgmt/nagios4:
  don't need iconv
- textproc/p5-XML-TinyXML: finish conversion to USES=perl5

Other changes:
- databases/qdbm and slaves: respect CFLAGS and friends, also enable bzip2
  and lzo support
- games/ldmud: respect CFLAGS and friends
- graphics/inventor: replace some patches with MAKE_ARGS/MAKE_ENV to respect
  CFLAGS and friends, also remove FreeBSD/alpha patch and add missing xorg
  dependencies

PR:		199099
Exp-run by:	antoine
Approved by:	portmgr (antoine)

3 files changed, 3 insertions, 29 deletions

diff --git a/x11-wm/icewm/Makefile b/x11-wm/icewm/Makefile
index 2de436724395..7f915c3fea14 100644
--- a/x11-wm/icewm/Makefile
+++ b/x11-wm/icewm/Makefile
@@ -3,7 +3,7 @@
 
 PORTNAME=	icewm
 PORTVERSION=	1.3.8
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	x11-wm
 MASTER_SITES=	SF/${PORTNAME}/${PORTNAME}-${PORTVERSION:R}/${PORTVERSION}
 
@@ -12,7 +12,7 @@ COMMENT=	Window Manager designed for speed, usability and consistency
 
 LICENSE=	GPLv2
 
-USES=		gmake iconv pkgconfig
+USES=		gmake iconv:translit pkgconfig
 USE_XORG=	ice sm x11 xext
 USE_GNOME=	gdkpixbuf2
 GNU_CONFIGURE=	yes
diff --git a/x11-wm/icewm/files/patch-src_ylocale.cc b/x11-wm/icewm/files/patch-src_ylocale.cc
deleted file mode 100644
index d76d2f4ea589..000000000000
--- a/x11-wm/icewm/files/patch-src_ylocale.cc
+++ /dev/null
@@ -1,26 +0,0 @@
---- src/ylocale.cc.orig	2013-11-03 19:58:39.180727369 -0500
-+++ src/ylocale.cc	2013-11-03 19:58:51.540725980 -0500
-@@ -126,8 +126,12 @@ YLocale::~YLocale() {
- iconv_t YLocale::getConverter (const char *from, const char **&to) {
-     iconv_t cd = (iconv_t) -1;
- 
-+    char *myfrom = (char *)malloc(1 + strlen(from));
-+    strcpy(myfrom, from);
-+    char *modptr = strstr(myfrom, "//");
-+    if (NULL != modptr) *modptr = '\0';
-     while (NULL != *to)
--        if ((iconv_t) -1 != (cd = iconv_open(*to, from))) return cd;
-+        if ((iconv_t) -1 != (cd = iconv_open(*to, myfrom))) return cd;
-         else ++to;
- 
-     return (iconv_t) -1;
-@@ -149,7 +153,8 @@ YUChar *YLocale::unicodeString(const YLC
-         return NULL;
- 
-     YUChar * uStr(new YUChar[lLen + 1]);
--    char * inbuf((char *) lStr), * outbuf((char *) uStr);
-+    const char * inbuf((char *) lStr);
-+    char * outbuf((char *) uStr);
-     size_t inlen(lLen), outlen(4 * lLen);
- 
-     if (0 > (int) iconv(instance->toUnicode, &inbuf, &inlen, &outbuf, &outlen))
diff --git a/x11-wm/pekwm/Makefile b/x11-wm/pekwm/Makefile
index 5df718dd0b9e..970fc43d4c2d 100644
--- a/x11-wm/pekwm/Makefile
+++ b/x11-wm/pekwm/Makefile
@@ -21,7 +21,7 @@ CONFIGURE_ARGS+=--enable-shape --enable-xinerama --enable-xrandr \
 		--enable-xft --enable-image-xpm --enable-image-jpeg \
 		--enable-image-png --disable-debug \
 		--disable-pedantic
-CFLAGS+=	-DICONV_CONST -I${LOCALBASE}/include
+CFLAGS+=	-I${LOCALBASE}/include
 LDFLAGS+=	-L${LOCALBASE}/lib ${ICONV_LIB}
 
 .include <bsd.port.mk>