| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
| |
This update addresses CVE-2014-6270.
PR: 193737
Submitted by: timp87 at gmail.com
|
| |
|
|
|
|
|
|
| |
PR: 193737
Submitted by: timp87 at gmail.com
MFH: 2014Q3
|
|
|
|
| |
Sponsored by: Absolight
|
|
|
|
| |
- Replace patch with USES=pathfix
|
| |
|
| |
|
| |
|
|
|
|
| |
- Auto-detect MMX support
|
|
|
|
|
|
|
|
|
| |
to the latest version
Set minimal version to 1.3.7 for now
Differential Revision: D723
Reviewed by: bdrewery
|
|
|
|
|
|
|
|
| |
- New MASTER_SITES
- Update LICENSE*
PR: 193727
Submitted by: takefu@airport.fm (maintainer)
|
|
|
|
|
|
|
|
|
| |
Also the compat NO_INSTALL_MANPAGES shim.
Differential Revision: https://reviews.freebsd.org/D730
Reviewed by: antoine
With hat: portmgr
Sponsored by: Absolight
|
|
|
|
|
|
|
|
|
| |
- improves compatibility with umplayer
- does not require manual config modification for subtitle display
- Bump PORTREVISION
PR: 193675
Submitted by: loox@e-shell.net
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Use USE_LDCONFIG
Overall changes:
- Compile with -fpic instead of -fPIC (potentially smaller code size)
- Add a schematics file for the hardware receiver in FidoCadJ format
- Language and typographical updates to README.md
- Several signed/unsigned/size fixes
Library changes:
- Extract generic third-party code for bits 1..14 from decode_alarm.h into a
new file bits1to14.h
- Convert almost all calculations for decoding the live signal into integer
operations, drop fields 'a', 'frac', and 'maxone' from struct bitinfo.
- New function setclock_ok() in setclock.h
- New functions get_acc_minlen(), add_acc_minlen(), reset_acc_minlen() in
decode_time.h. The accumulated minute length is now a first-class entity.
When decoding the live signal, increment it more precisely than just 1000 ms/s
to prevent drift during bad radio reception.
- New functions dcftime() and isotime() in decode_time.h. Use the latter in
setclock.c
- Check input values of etc/config.txt:
- hw.active_high must be 0 or 1
- hw.freq must be even between 10 and 666666
- Reset the values of bit0 and bit20 if the latter becomes smaller than the
former, show this in the log file using a '!'
- Compact the signal buffer, it now stores 8 pulses per byte instead of just 1.
Client changes:
- Make dcf77pi and dcf77pi-analyze more agnostic of the contents of the
third-party contents
- Update display code of dcf77pi and readpin for the updates to the live signal
decoding
- Show in dcf77pi when the value of bit20 underflows
- Update the code to display the signal buffer in readpin
- Fix readpin to properly clean up when receiving a SIGINT
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
| |
- Remove old libtool patch
- Remove post-patch command that isn't needed with staging
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
- Add INSTALL_TARGET=install-strip
|
| |
|
| |
|
| |
|
|
|
|
| |
- Merge MASTER_SITES and MASTER_SITE_SUBDIR
|
| |
|
|
|
|
|
|
| |
PR: 193717
Reported by: kib@
Fixed by: timp87 (gmail)
|
|
|
|
| |
- Add LICENSE_FILE
|
| |
|
|
|
|
|
|
| |
- Drop specific libmcrypt so version requirement from php53 to fix build
Submitted by: Matthew D. Fuller <fullermd at over-yonder dot net>
|
|
|
|
|
| |
Submitted by: tijl
Sponsored by: Absolight
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
PR: 179116
Submitted by: Kalten (gmx.at)
Xcftools is a set of fast command-line tools for extracting information
from the Gimp's native file format XCF. The tools are designed to allow
efficient use of layered XCF files as sources in a build system that use
'make' and similar tools to manage automatic processing of the graphics.
These tools work independently of the Gimp engine and do not require the
Gimp to even be installed.
|
| |
|
|
|
|
|
| |
PR: 193707
Submitted by: a.ulasov
|
|
|
|
| |
With hat: portmgr
|
|
|
|
|
|
|
| |
have the same CPE identifier
Discussed with: des@
With hat: portmgr
|
|
|
|
|
|
| |
- Add INSTALL_TARGET=install-strip
- Remove MAKE_JOBS_UNSAFE (tested on Redports)
- Use default do-install such that libadf gets installed
|
|
|
|
|
|
|
|
|
|
| |
(this adds the patch itself, which I forgot in the previous commit;
previous commit should've also said: "- simplify Makefile by using
PORTDATA=*)
PR: 193267
Submitted by: John.Marshall@riverwillow.com.au
MFH: 2014Q3
|
| |
|
| |
|
|
|
|
|
|
| |
- Bump dependent ports as .so version has changed
Approved by: portmgr blanket
|
|
|
|
| |
Pointy hat: zi
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
| |
PR: 193267
Submitted by: John.Marshall@riverwillow.com.au
MFH: 2014Q3
|
|
|
|
|
| |
Noticed by: bapt
Sponsored by: Absolight
|
|
|
|
| |
Approved by: portmgr blanket
|
|
|
|
| |
Sponsored by: Absolight
|
|
|
|
| |
Approved by: maintainer
|
|
|
|
|
|
|
| |
Changes:
* Fix improper call to 'msg_warn'. Bad backport from 3.1.
Reported by: sunpoet
|
|
|
|
| |
Approved by: portmgr blanket
|
| |
|
|
|
|
|
|
|
|
|
|
| |
pynagioscheck is a Python framework for Nagios plug-in developers.
pynagioscheck strives to conform to the practices described in the Nagios
Plug-in Development Guidelines and, more importantly, save valuable system
administrator time.
WWW: https://pypi.python.org/pypi/nagioscheck/
|
|
|
|
| |
Approved by: portmgr blanket
|
|
|
|
|
|
| |
is optional and switch to OPTIONS_RADIO.
Sponsored by: Absolight
|
|
|
|
|
| |
Noticed by: bdrewery
Sponsored by: Absolight
|
| |
|
| |
|
|
|
|
| |
USES=libtool
|
|
|
|
|
|
| |
Add USE_LDCONFIG per portlint
Add LICENSE
Utilize PORTVERSION in pkg-plist to limit number of required changes
|
|
|
|
|
|
|
| |
- Reset maintainer due to repeated timeouts
PR: 192987 [1]
Submitted by: yamagi at yamagi.org
|
| |
|
| |
|
|
|
|
| |
Sponsored by: Absolight
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
Sponsored by: Absolight
|
|
|
|
| |
Sponsored by: Absolight
|
|
|
|
| |
Approved by: portmgr blanket
|
|
|
|
|
|
| |
Security update.
MFH: 2014Q3
|
|
|
|
|
|
|
| |
- Update the setup.py patch
- Update the port with USES=python
Approved by: mentors (implicit)
|
|
|
|
| |
MFH: 2014Q3
|
| |
|
|
|
|
|
|
|
| |
runs autoreconf in CONFIGURE_WRKSRC to update configure, Makefile.in and
other build scripts.
Approved by: portmgr (bapt)
|
|
|
|
|
|
| |
Submitted by: Mikhail Tsatsenko <m.tsatsenko@gmail.com>,
Jung-uk Kim <jkim@FreeBSD.org>
Obtained from: svn.redports.org/virtualbox
|
|
|
|
|
|
| |
- Removed patch-lib-facter-zpool_version.rb (accepted by upstream)
Approved by: mentors (implicit)
|
|
|
|
|
|
|
|
| |
(lthack, ltasneededhack and ltverhack) [1]
- Remove support for USE_AUTOTOOLS=libtool and USE_AUTOTOOLS=libltdl
PR: 188978 [1]
Approved by: portmgr (bapt)
|
|
|
|
|
|
|
| |
There are only 60 such ports so there doesn't need to be a separate
keyword or USES for this.
Approved by: portmgr (bapt)
|
|
|
|
|
| |
PR: 193631
Submitted by: <mike.d.ft402@gmail.com>
|
| |
|
| |
|
|
|
|
|
|
|
| |
PR: 193095
Reviewed by: koobs
Approved by: koobs
Review: D487
|
|
|
|
| |
Announcement: http://sphinxsearch.com/blog/2014/09/15/sphinx-2-2-4-release-now-available/
|
|
|
|
|
| |
PR: 187133
Submitted by: lorne (cons.org.nz)
|
|
|
|
|
| |
PR: 193154
Submitted by: Ports Fury
|
|
|
|
|
|
|
| |
Update USE_PYTHON -> USES=python:2.
PR: 193682 [1]
Submitted by: David Siebörger [1]
|
| |
|
|
|
|
|
|
| |
download files from the last site (distcache).
With hat: portmgr
|
|
|
|
| |
Reported by: az@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
specifically powerpc patch file.
Drop patch-ieee-utils-fp-freebsd.c alltogether and change the order
of #ifdefs in the setup to pull in fp-gnuc99.c instead of fp-freebsd.cc
Verified on redports for x86 builds and am bumping port revision.
Suggested by: nathanw
Phabric: https://reviews.freebsd.org/D787
Reviewed by: nathanw
Approved by: bdrewery (mentor)
|
|
|
|
|
|
|
|
|
| |
This plugin gives Dancer the ability to get and store page content in a
memcached server, which in specific configurations could give a
performance boost - particulary on GET requests that incur significant
database calls.
WWW: http://search.cpan.org/dist/Dancer-Plugin-Memcached/
|
|
|
|
| |
Requested by: adamw
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
<ChangeLog>
*) Security: it was possible to reuse SSL sessions in unrelated contexts
if a shared SSL session cache or the same TLS session ticket key was
used for multiple "server" blocks (CVE-2014-3616).
Thanks to Antoine Delignat-Lavaud.
*) Bugfix: requests might hang if resolver was used and a DNS server
returned a malformed response; the bug had appeared in 1.5.8.
*) Bugfix: requests might hang if resolver was used and a timeout
occurred during a DNS request.
</ChangeLog>
|
| |
|
|
|
|
|
|
|
| |
- Fix i7.sh to conform to new compiler flags.
PR: 193540
Submitted by: maintainer
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changes:
* HTML: Fix NaN showing in a case
* Fix handling of SIGPIPE for cleaning up.
* Improvements to cleanup handling such that recursive errors will not
stop the cleanup process.
* HTML: Add an apache example
* testport: Allow tee(1) more time to flush buffer before killing it off.
* bulk: Remove the use of tee(1)
* bulk: Fix several races leading to "stuck_in_queue" and "Unknown stuck
queue bug".
* jail -m src=: Also copy in the src tree now. .git and .svn are ignored.
* bulk: Fix high CPU usage/spinning when the queue is waiting on the last
jobs to finish.
* Remove use of stripcolors pipe which used far too much CPU.
* bulk: Fix a case where computing deps was not delaying errors until
the end of deps calculation was intended.
|
|
|
|
|
|
|
|
|
| |
Changes:
* Add a check for 3.1 repository and reject the build. 3.0 does not know
how to handle 3.1's repository format. Downgrading is not supported
at this point.
* Allow securelevel>=1 with USE_TMPFS=all
* Add a warning that DEVELOPER=yes is ignored in lieu of bulk -t/testport
|
|
|
|
| |
WWW: http://burnash.github.io/gspread/
|
|
|
|
|
|
|
|
| |
While here:
- Add WWW to pkg-descr
PR: 193663
Submitted by: Nikolay Dachev <nikolay@dachev.info> (maintainer)
|
|
|
|
|
|
|
|
|
|
| |
- This is used by portupgrade and poudriere bulk/testport -i for
install-package.
- The change is not backwards compatible; setting PKGNG_ORIGIN was never
intended. It is only for reading.
With hat: portmgr
Discussed with: bapt
|
|
|
|
|
| |
PR: 193679
Submitted by: Eero Haenninen <fax@nohik.ee> (maintainer)
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
| |
- Bump dependent ports as .so version has changed
Approved by: portmgr blanket
|
|
|
|
| |
Approved by: portmgr blanket
|
|
|
|
| |
Approved by: portmgr blanket
|
| |
|
|
|
|
|
|
|
|
|
|
| |
qemu bug, but the code itself is arguably wrong as well. Apply this patch atop
the tar ball and move on.
Phabric: https://reviews.freebsd.org/D746
Submitted by: nox
Reviewed by: kwm
Approved by: bapt (mentor)
|
|
|
|
|
|
|
|
|
| |
From now on, there will only be one squid port, this one. Squid33 has
been deprecated and will expire on 31 JAN 2015.
PR: 192828
Submitted by: timp87 (gmail)
Contributions: takefu (airport.fm), Dennis Glatting
|
|
|
|
|
| |
The www/squid port, which is also expired, will be upgraded to Squid
version 3.4 rather than removing it.
|
|
|
|
|
| |
PR: 193657
Submitted by: farid@hajji.name
|
| |
|
|
|
|
|
|
|
| |
Currently, FreeBSD defines EXTRACT_CMD as $TAR, but DragonFly does not
have a default value for EXTRACT_CMD. Using $TAR instead of $EXTRACT_CMD
is a No-Op for FreeBSD, but restores the build on DragonFly which got
disrupted as a result of the previous commit.
|
|
|
|
| |
Submitted by: jhale
|
|
|
|
|
|
|
| |
STATIC_LIBEXECINFO value has to track the inclusion of devel/libexecinfo
so use the same test as USES+=execinfo uses and avoid using the
discouraged (and wrong for DragonFly) OSVERSION check. This is really
a follow-up to a previous commit that added USES+=execinfo.
|
|
|
|
|
|
|
| |
- Bump PORTREVISION
PR: 193654
Submitted by: ohartman@zedat.fu-berlin.de
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
<ChangeLog>
--[ Redis 2.8.15 ] Release date: 12 Sep 2014
# UPGRADE URGENCY: LOW for Redis, HIGH for Sentinel.
* [FIX] Sentinel critical bug fixed: the absolute majority was computed in a
wrong way because of a programming error. Now the implementation does
what the specification says and the majority to authorize a failover
(that should not be confused with the ODOWN quorum) is the majority of
*all* the Sentinels ever seen for a given master, regardless of their
current state.
* [FIX] GETRANGE test no longer fails for 32 bit builds (Matt Stancliff).
* [FIX] Limit SCAN latency when the hash table is in an odd state (very few
populted buckets because rehashing is in progress). (Xiaost and
Salvatore Sanfilippo)
* [NEW] Redis is now able to load truncated AOF files without requiring a
redis-check-aof utility run. The default now is to load truncated
(but apparently not corrupted) AOFs, you can change this in redis.conf.
(Salvatore Sanfilippo).
* [NEW] Sentinel: ability to announce itself with an arbitrary IP/port to work
in the context of natted networks. However this is probably still
not enough since there is no equivalent mechanism for slaves listed
in the master INFO output. (Dara Kong and Salvatore Sanfilippo)
</ChangeLog>
|
| |
|
|
|
|
|
| |
PR: 193214
Submitted by: Oleksii Tsai <oleksii.tsai@googlemail.com>
|
|
|
|
|
| |
PR: 161359
Pointed out by: jhale
|
|
|
|
|
|
| |
have them.
PR: 176805
|
|
|
|
|
|
|
|
|
|
| |
Not bumping the PORTREVISION as this is only applied to ARM builds.
Phabric: https://reviews.freebsd.org/D756
PR: 181318
Submitted by: mikael.urankar@gmail.com
Reviewed by: kwm@
Approved by: bdrewery (mentor)
|
|
|
|
|
| |
Poked by: bapt
Sponsored by: Absolight
|
|
|
|
| |
PR: 193667
|
|
|
|
| |
Approved by: portmgr blanket
|
|
|
|
| |
Approved by: portmgr blanket
|
|
|
|
| |
Approved by: portmgr blanket
|
|
|
|
| |
Approved by: portmgr blanket
|
|
|
|
| |
- Bump dependent ports as .so version has changed
|
|
|
|
| |
Approved by: portmgr blanket
|
|
|
|
| |
Approved by: portmgr blanket
|
|
|
|
| |
Approved by: portmgr blanket
|
|
|
|
|
|
| |
- Bump dependent ports as .so version has changed
Approved by: portmgr blanket
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the port Makefile, into a stage-qa error. All ports that would trigger
this error have been converted. Many thanks to all people involved in
this, especially Dmitry Marakasov (amdmi3) who handled most ports.
At this moment over 2200 ports have USES=libtool and over 20000 library
dependencies between packages have been removed.
This also marks the point where :keepla is no longer special. It is now
only needed if a port uses *.la files at run-time.
QA-run by: antoine
Approved by: portmgr (antoine)
|
|
|
|
|
|
| |
- Fix WWW
Approved by: portmgr (blanket)
|
|
|
|
| |
Changes: http://search.cpan.org/dist/Module-Release/Changes
|
| |
|
| |
|
|
|
|
| |
- Use ECHO_CMD
|
|
|
|
| |
- Bump PORTREV
|
|
|
|
|
|
|
| |
- Add LICENSE (GPLv2)
PR: 193238
Submitted by: maintainer
|
|
|
|
|
|
| |
- Style fix.
PR: 180324
|
|
|
|
|
|
|
|
|
|
|
|
| |
doesn't need makefile patching any more
- Remove MASTER_SITES, this is handled by USE_GITHUB
- Fix LICENSE_FILE
- Improve installation
PR: 193580
Submitted by: amdmi3
Approved by: swills (maintainer, via irc)
|
|
|
|
|
|
|
|
|
|
| |
option on amd64 builds.
Yet another armv6 build fix.
Phabric: https://reviews.freebsd.org/D761
Submitted by: mva
Reviewed by: bdrewery (mentor)
|
|
|
|
|
|
|
|
|
| |
Side effect, allows compilation on armv6.
PR: 193218
Submitted by: demon@FreeBSD.org
Reviewed by: bdrewery (mentor)
Approved by: maintainer timeout
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
- Bump PORTREVISION
PR: 161359
Submitted by: phd_kimberlite@yahoo.co.jp
Patch by: cpm@fbsd.es (maintainer)
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
| |
- Clean up / simplify Makefile
- MASTER_SITES: only sourceforge
- Mark port BROKEN on pre-9.x systems for now (build issue)
PR: 193421
Submitted by: 5u623l20@gmail.com (maintainer)
|
|
|
|
|
| |
- Use COPYTREE_SHARE to install include headers
- Add dos2unix so the patch can have svn:eol-style native
|
|
|
|
|
| |
PR: ports/185045, ports/193603
Submitted by: cmt@burggraben.net, Radim Kolar <hsn@sendmail.cz>, Elimar Riesebieter <riesebie@lxtec.de>
|
|
|
|
| |
Approved by: mentors (implicit)
|
|
|
|
|
|
| |
- Fix pkg-descr content and url
Approved by: mentors (implicit)
|
|
|
|
|
|
| |
- Convert to INSTALL_TARGET=install-strip
Reported by: antoine
|
|
|
|
| |
Maintainer timeout.
|
|
|
|
| |
devel/rubygem-sprockets211
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changes:
* any addr and overloads in commoncpp
* cmake abi fix and other apple specific issues
* stream fixes, sflphone recommended changes, and other updates
* key protocol added
* cleaner build for binding without resolver
* cleanup and fixes for commoncpp peering...
* UDPSocket: use ucommon::Socket::address
* Socket::address: add setAny(sockaddr*), setLoopback(sockaddr*)
|
| |
|
| |
|
| |
|
|
|
|
| |
Submitted by: antoine
|
|
|
|
| |
renamed upstream.
|
|
|
|
|
|
| |
conflict with another program called lolcat (games/lolcat). While this isn't my
personal choice of name I go with the change to stay compatible with upstream.
As a nice side effect we can remove the conflict to games/lolcat vice versa.
|
|
|
|
| |
- Bump PORTREVISION for dependency change
|
|
|
|
| |
Submitted by: sunpoet
|
|
|
|
| |
Suggested by: az
|
| |
|
|
|
|
|
|
|
| |
support.
PR: ports/193574
Submitted by: Nikolay Dachev <jadm dachev info>
|
| |
|
|
|
|
|
| |
PR: ports/193574
Submitted by: Nikolay Dachev <nikolay dachev info>
|
|
|
|
|
| |
PR: ports/193574
Submitted by: Nikolay Dachev (nikolay dachev info)
|
| |
|
| |
|
|
|
|
|
| |
PR: 193647
Approved by: khsing.cn@gmail.com (maintainer)
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changes:
- pkg register checks conflicts before installing the files
- do not provide any shlibs if the "no_provide_shlib" annotation is set
- fix invalid free() in keywords arguments parsing
- Add ability to select usage of IPv4/IPv6 via config, repository config or command line
- some documentation fixes and improvements
- If one of -P, -I or -R is not explicitly given on the command line, do
not emit error messages while searching for a mechanism to find data
about the latest available ports.
- Rework automatic directory deletion
|
|
|
|
|
| |
- Convert USE_PYTHON=yes -> USES=python:3.2+ (new version requires 3.x only)
- Take maintainership
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
- Bump portrevision as some files were not packaged with intended owner
|
| |
|
| |
|
|
|
|
|
| |
- Shebangfix
- Allow staging as a regular user
|
| |
|
| |
|
|
|
|
|
|
|
| |
- Remove .keep_me files because pkg can handle empty directories
PR: 193621
Submitted by: theis@gmx.at (maintainer)
|
| |
|
|
|
|
| |
- Remove texinfo from RUN_DEPENDS.
|
| |
|
|
|
|
| |
Submitted by: az
|
|
|
|
| |
Approved by: portmgr (bdrewery)
|
|
|
|
| |
- Move RUN_DEPENDS upward
|
| |
|
|
|
|
|
| |
Obtained from: https://github.com/heimdal/heimdal/commit/1846c7a35d1091d3b6140c
56b
|
|
|
|
|
| |
- Fixed validation when a string with more than one slash (/) is passed to
Net::Works::Network->new_from_string.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Fix in CegoQueryHelper::decodeFVL to treat also decodings for
field value list in switched order ( btree or index fvl )
- Fix in CegoAction::execIndexCheck to conform to new object comparison
in CegoDatabaseManager::ObjectRecord
- Fix in CegoTableManager::deleteDataTable to check for inappropriate
AttrCond before executing tablecursor setup
- Fix in CegoDatabaseManager::Object::operator == Index comparisons
corrected ( index can either match uindex, pindex or index, btree
can either match ubtree, pbtree or btree )
Submitted by: Björn Lemke <lemke@lemke-it.com>
|
| |
|
|
|
|
| |
Changelog: https://lucene.apache.org/core/4_10_0/changes/Changes.html
|
| |
|
| |
|
| |
|
|
|
|
| |
- Fix ownership of packaged files
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Add RESTRICTED, LICENSE
- Clean up Makefile
- Retire post-install
- Use pkg-message
- Rename patches according to the naming conventions
PR: 193446
Submitted by: cpm@fbsd.es
Reviewed by: marino, riggs
|