aboutsummaryrefslogtreecommitdiffstats
path: root/Mk/Scripts
Commit message (Collapse)AuthorAgeFilesLines
* checks $WRKSRC for all direct dependencies in the limited-clean-depends:loader2015-07-301-1/+1
| | | | | | | target, like the original CLEAN-DEPENDS-LIMITED in bsd.port.mk Approved by: bapt Differential Revision: https://reviews.freebsd.org/D3233
* Split LIB_DEPENDS and the other _DEPENDS types.mat2015-07-241-6/+15
| | | | | | | | | Reviewed by: bapt, pgolluci Exp-run by: mat Approved by: bapt With hat: portmgr Sponsored by: Absolight Differential Revision: https://reviews.freebsd.org/D3150
* Fix path of libeditbapt2015-07-201-1/+1
|
* Add a QA check on some base libraries (for now only libedit and libarchive)bapt2015-07-201-1/+23
|
* - Add /usr/sbin/dtrace to the list of allowed shebangsamdmi32015-07-151-0/+1
| | | | | | Submitted by: amdmi3 Approved by: portmgr (bapt) Differential Revision: D3070
* - Provide a check/warning/fix for users that upgraded from an older release ↵zi2015-07-071-0/+7
| | | | | | and missed UPDATING 20150213 Approved by: portmgr (bapt)
* Rewite CLEAN-DEPENDS*bapt2015-07-041-0/+50
| | | | | | | | Move inlined shell code into a proper script taking 2 args in arguments: full or limited. The code I more simpler and understandable. The argument allows to factorize the code between CLEAN-DEPENDS-FULL and CLEAN-DEPENDS-LIST While here, make the code accept dependencies without ${PORTSDIR}
* Fix missing variable that got accidentally removed before commitbapt2015-07-021-1/+1
|
* Move all-depends-list to a regular scriptbapt2015-07-021-0/+39
| | | | | | | | The benefice beside being more readable is to allow support for dependency line without ${PORTSDIR} This is also necessary to be able to easily hack on it for FLAVORS/SUBPACKAGE support
* Factorize the function to validate envbapt2015-07-023-26/+17
| | | | | Reviewed by: antoine Differential Revision: https://reviews.freebsd.org/D2966
* Remove disconnected scriptswills2015-07-011-23/+0
|
* Add PATH environment when trying to find libraries this fixes building underbapt2015-07-011-1/+1
| | | | | | | qemu emulation Reported by: Sylvain Garrigues (via #poudriere) Tested by: Sylvain Garrigues (via #poudriere)
* Refactor dependency checks and installationbapt2015-06-291-0/+177
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is an important step to prepare the ports tree for VARIANTS(aka flavours) and subpackage by making the dependency code easier to deal with. Change: - Externalize in a proper shell script the code that was an inlined shell script - Add better validation on the syntaxe used - test after the dependency has been installed that it actually really fulfill the pattern searched (improving QA) - Unify lib-depends with other dependency checks - Make ${PORTSDIR} not mandatory anymore in _DEPENDS lines: aka pattern:${PORTSDIR}/category/port can now be written pattern:category/port /!\ Please to not use this syntax yet! poudriere have received a fix to be able to handle this new syntax (but no new release of poudriere has it yet) portmaster/portupgrade hasn't been checked. if one cares about those last 2 it would be really nice to provide patches to them! - Remove _DEPENDS_ALWAYS it has half broken for a while and did not really make sense. - Keep STRICT_DEPENDS for now it might not be necessary anymore given all the new checks added, but until someone confirms it is worth keeping it. Note that all the env passed are prefixed by 'dp_' to avoid polluting children make Differential Revision: https://reviews.freebsd.org/D2897 Reviewed by: antoine Exp-run by: antoine
* - Add blacklist of files which are not intended to be executed to shebang testamdmi32015-06-041-4/+12
| | | | | | | | - Sort shebang list Differential Revision: D2670 Submitted by: amdmi3 Approved by: portmgr (bapt)
* - Add ${PREFIX}/www to shebang check. We have many shebang problems which ↵amdmi32015-05-211-3/+4
| | | | | | | need to be discovered and fixed in www category. Differential Revision: D2580 Approved by: portmgr (bapt)
* Fix strip check to consider setuid binaries.bdrewery2015-04-301-1/+1
| | | | | | | file(1) returns 'setuid' before the rest of the ELF output. With hat: portmgr Sponsored by: EMC / Isilon Storage Division
* - Display a stage-qa warning when ports use PREFIX/var instead of /vartijl2015-04-211-1/+7
| | | | | | | | | | | | | | | | | | - Add --localstatedir=/var to _LATE_CONFIGURE_ARGS (like --mandir) but not when CONFIGURE_ARGS already sets it. (GNU configure scripts set it to PREFIX/var when PREFIX != /usr.) - Add --localstatedir="${PREFIX}/var" to CONFIGURE_ARGS in some ports so they aren't affected by this change (for now at least). This commit is meant to ensure that new ports don't make the same mistake. - games/acm: the configure script in this port is very old; instead of patching it more, just replace GNU_CONFIGURE with HAS_CONFIGURE. - irc/charybdis: it already used /var but adding --localstatedir=/var changed the behaviour of the configure script; adjust the port to this. PR: 199506 Exp-run by: antoine Approved by: portmgr (antoine)
* - Remove dead function from find-lib.shantoine2015-04-102-20/+2
| | | | | | - Print a message if dependency registration on a package failed With hat: portmgr
* Remove unintended change from r383627bapt2015-04-091-1/+0
|
* Remove USE_GNUSTEP from bsd.port.mkbapt2015-04-091-0/+1
|
* Stop trying to resolv symlinks when looking up for a shlibbapt2015-04-091-21/+1
| | | | | | | file -L is resolving them properly and actual-package-depends.sh is also correctly resolving them Exp-run by: antoine
* Speed up checking for stripped binariesfeld2015-03-241-1/+1
| | | | | | | | Skip ascii files. This significantly speeds up stage-qa on ports with a considerable amount of text files being installed. Differential Revision: https://reviews.freebsd.org/D2121 Approved by: bdrewery
* Make fonts repecting XDGbapt2015-03-221-2/+2
| | | | | | | | | | Xorg is now looking in ${LOCALBASE}/share/fonts by default Xorg now accepts symlinks in etc/X11/fontpath.d (as decribed in Xserver(1)) Large cleanup on lots of font ports All fonts are now properly dynamically generating fonts.dir and fonts.scale instead of sometime overwriting existing ones) All fonts are generating fontconfig's cache Improve consistency in fonts ports
* Remove a debug line from actual-package-dependsantoine2015-03-121-1/+0
| | | | With hat: portmgr
* Rework dependency registrationbapt2015-02-102-0/+134
| | | | | | | | | | | | | Change the way the dependencies are registred so that now it follows the same mechanism as when the *_DEPENDS making the dependency registration system ready to allow multiple packages from the same origin such as flavours and subpackages Also allowing to install twice the same port one built with python33 and the other built with python27 for example. PR: 19702 With help of: antoine Exp-run: portmgr (antoine)
* Don't replace PREFIX anywhere in the plist line, only do it for the beginning.bdrewery2015-01-231-4/+4
| | | | | With hat: portmgr Sponsored by: EMC / Isilon Storage Division
* - Move parse_plist() into a new file, functions.sh.bdrewery2015-01-082-138/+156
| | | | With hat: portmgr
* - Rework check on $makeplist in parse_plist(). The variable was/is always 0 asbdrewery2015-01-081-2/+4
| | | | | | | | the makeplist code does not use parse_plist(). Rename the param to 'parse_comments' to be more clear on what it is for. This is kept for upcoming refactoring. With hat: portmgr
* Limit the scope of variables in parse_plist()bdrewery2015-01-081-0/+2
| | | | With hat: portmgr
* Remove now useless gnomehier, pkg handles automatically the directories wherebapt2014-12-251-6/+2
| | | | | | | | needed making gnomehier entirely useless now. Differential Revision: https://reviews.freebsd.org/D1355 Reviewed by: antoine, kwm Approved by: gnome (kwm)
* - Add three empty dirs that belonged to gnomehier to devel/gconf2,antoine2014-12-231-0/+1
| | | | | | | | this prevents stage violations during build of ports using gconftool-2 - White list etc/gconf/gconf.xml.defaults from stage orphans as gconftool-2 is unpredictable With hat: portmgr
* Don't output a warning if PERL_ARCH does not exist.mat2014-12-231-1/+1
| | | | | With hat: portmgr Sponsored by: Absolight
* Make Perl link all .so it builds with libperl.so.mat2014-12-171-1/+50
| | | | | | | | | | | | | | | | It makes upgrading from one Perl major version to another way easier. For binary package users, it means pkg upgrade will detect the libperl.so.x.yy change, and reinstall the affected packages. For users using ports, it will save rebuild time as it's easier to detect what ports really need to be rebuilt. PR: 195821 Differential Revision: https://reviews.freebsd.org/D1241 Submitted by: mat Reviewed by: antoine, bdrewery Exp-run by: antoine With hat: perl Sponsored by: Absolight
* Fix a false positive home directory leftover for ports with multiple USERSantoine2014-12-021-1/+1
| | | | | | | or with USERS matching another user in UIDs Reported by: adamw (mail/spamassassin) With hat: portmgr
* - During makeplist, emit only empty directories inside prefix andantoine2014-11-051-3/+6
| | | | | | | | | | | directories outside prefix - Whitelisting orphan directories not starting with / is no longer necessary - Adjust missing directories check to use a list of all directories instead of the dirs from make-plist Differential Revision: https://reviews.freebsd.org/D1101 Reviewed by: bapt With hat: portmgr
* - Accept absolute path for @fc, @fontsdir, @fcfontsdir, @shell keywordsak2014-10-091-0/+7
| | | | | Approved by: portmgr (antoine, bapt) Differential Revision: https://reviews.freebsd.org/D721
* info keyword now handles full pathsantoine2014-10-081-1/+4
| | | | With hat: portmgr
* Replace @dirrm/@dirrmtry with @dir in makeplist and leftovers checkantoine2014-10-072-12/+12
| | | | | | Differential Revision: https://reviews.freebsd.org/D901 Reviewed by: bapt With hat: portmgr
* - Allow LINUXBASE for shebangs.bdrewery2014-10-041-0/+1
| | | | | | PR: 193878 Submitted by: Jan Beich <jbeich@vfemail.net> With hat: portmgr
* check-plist no longer needs to check for directories owned by dependencies.bdrewery2014-10-041-51/+2
| | | | | | | | | pkg-1.3.8's auto directory handling makes this a non-issue. We should add a new check to warn of possibly needing @dir for empty dirs though. With hat: portmgr
* Garbage collect dependency mtree check removed in r368803bdrewery2014-10-041-31/+0
|
* Do not report directories in plist as orphansantoine2014-09-221-1/+0
| | | | With hat: portmgr
* adjust check_stagedir.sh to take in account %%KEY%%@dirrm*bapt2014-09-221-1/+1
|
* Update to 1.3.8 Changes:bapt2014-09-222-4/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Plist parser do not accept modes like o+w g+s u+r - @owner/@group with no argument reset the default ownership to root/wheel - Plug regression tests into the release mechanism as mandatory - Allow url in repository configuration to be overriden by another configuration file - If one of -P, -I or -R is not explicitly given on the command line do not emit error messages while searching for a mechanism to find data about the latest available ports. - External keywords can now take arguments - Directories under PREFIX are automatically handled and removed if needed - MTREE are not packaged anymore neither extracted on final installation - OS major checking (to determine if pkg is running on an upgraded base system) uses the same mechanism as ABI detection instead of relying on UNAME_r which can have false positivie on jails - Add @dir keyword for plist which is used to package explicitly directories (directories with non root/wheel or outside prefix) and empty directories (@dirrm and @dirrmtry are now considered as deprecated) - root/wheel are now considered as the default user/group when creating a package except @owner/@group are used to change that behaviour - Import newer version of libucl which improves error messages in case of problem parsing manifest or configuration files - Fix pkg register so it checks for conflicts before actually copying files on to the filesystem - pkg now support a new no_provide_lib annotation to preventing automatic populating of provided libs (useful for packages bundling libraries like wine) - Improve documentations - Ability to select usage of IPv4/IPv6 via config, repository config or command line - Lots of bug fixes Side effects: - Convert to install-mtree target into a no-op target Add empty directories to plist of ports that needs them to run: - share/aclocal to devel/automake and devel/automake14 - share/applications to devel/desktop-file-utils - share/xml share/sgml to textproc/xmlcatmgr - Prevent check-plist to issue warnings about some @dir* - Adjist check_leftovers.sh to not take in account anything related to mtree - Bump the default required version of pkg to 1.3.8
* Fix typoantoine2014-09-181-1/+1
| | | | With hat: portmgr
* Turn the installation of *.la files, without some form of USES=libtool intijl2014-09-161-3/+3
| | | | | | | | | | | | | | | the port Makefile, into a stage-qa error. All ports that would trigger this error have been converted. Many thanks to all people involved in this, especially Dmitry Marakasov (amdmi3) who handled most ports. At this moment over 2200 ports have USES=libtool and over 20000 library dependencies between packages have been removed. This also marks the point where :keepla is no longer special. It is now only needed if a port uses *.la files at run-time. QA-run by: antoine Approved by: portmgr (antoine)
* Make check-stagedir.sh aware of (owner,group,perm) syntax for keywordsantoine2014-09-021-0/+4
| | | | | | Differential Revision: https://reviews.freebsd.org/D712 Reviewed by: bapt With hat: portmgr
* - Make it possible to use sample keyword with a full pathantoine2014-09-021-3/+9
| | | | | | | | - Prefer @dirrmtry over @unexec rmdir in makeplist Differential Revision: https://reviews.freebsd.org/D705 Reviewed by: bapt With hat: portmgr
* Remove support for pkg_installbapt2014-09-011-32/+7
| | | | | | | | Merge back bsd.pkgng.mk into bsd.port.mk Add a note about @stopdaemon not being supported anymore With hat: portmgr Differential Revision: https://reviews.freebsd.org/D693
* Ignore references to stagedir in .fmt and .log files generated for tex formatsantoine2014-08-301-0/+2
| | | | | | | | | | Those are harmless (records from which file they were generated from) and removing them would require ugly hacks according to hrs@ PR: ports/192933 Differential Revision: https://reviews.freebsd.org/D684 Reviewed by: bapt, hrs With hat: portmgr
* Check that the plist doesn't reference the stage dir during stage-qaantoine2014-08-261-1/+1
| | | | | | | | | | ====> Running Q/A tests (stage-qa) Error: '/usr/ports/www/claroline/work/.PLIST.mktmp' is referring to /usr/ports/www/claroline/work/stage *** Error code 1 Differential Revision: https://reviews.freebsd.org/D685 Reviewed by: bdrewery With hat: portmgr
* - Add the same workaround for ignoring PREFIX/info removal when PREFIX !=bdrewery2014-08-191-0/+8
| | | | | | LOCALBASE, as check-stagedir has. With hat: portmgr
* Advise trying INSTALL_TARGET=install-strip before ${STRIP_CMD}antoine2014-08-181-1/+1
| | | | | | Phabric: D477 Reviewed by: bdrewery With hat: portmgr
* - Fix 'make check-plist' incorrectly considering all installed packages asbdrewery2014-08-121-5/+7
| | | | | | | run dependencies if the port being checked has no RUN_DEPENDS. This could cause false-positive "Possibly owned by dependency" warnings. With hat: portmgr
* - Fix check-plist so that its 'files in plist but missing from STAGEDIR' checkbdrewery2014-07-251-5/+12
| | | | | | | | | does not incorrectly ignore plist items in %%DOCSDIR%% and %%EXAMPLESDIR%%. It was incorrectly ignoring these items when %%PORTDOCS%% or %%PORTEXAMPLES%% was missing. This manifested as a failure in 'make package' later when pkg(8) detected the missing files. With hat: portmgr
* Do not report parent directories of LOCALBASE as orphansantoine2014-07-011-0/+8
| | | | | Reported and tested by: gerald With hat: portmgr
* Do not report files @commented by multiple options as orphansantoine2014-06-211-1/+1
| | | | With hat: portmgr
* Mk/Scripts/qa.sh: add /bin/tcsh as a valid shebang.rene2014-06-171-0/+1
| | | | | Phabric: D231 Approved by: portmgr (antoine)
* fix a typodaichi2014-06-131-1/+1
|
* Add an @shell keyword to handle adding and remove a shell path in /etc/shellbapt2014-06-121-1/+1
| | | | | | | | Bump port revision of all ports that were doing it wrong prior to the keyword CR: D208 Reviewed by: antoine With hat: portmgr
* Add more files to orphans white list:antoine2014-05-201-0/+7
| | | | | | | | | | | | | - .DS_Store files - some VCS related files Note: it's still recommended to not extract/install those files if they are not needed PR: ports/189859 Submitted by: adamw (first version) Reviewed by: bapt With hat: portmgr
* - %D is based on @cwd, not PREFIX; Fix false-postives when using pkg_installbdrewery2014-05-181-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | and @cwd has changed away from PREFIX: plist: @cwd / @dirrmtry var/spool/dma ====> Checking for pkg-plist issues (check-plist) ===> Parsing plist DIR '/usr/local/etc/dma' CWD: /usr/local DIR '/usr/local/var/spool/dma' CWD: DIR 'share/licenses/dma-v0.9,1' CWD: /usr/local DIR '/usr/local/share/licenses' CWD: /usr/local ===> Checking for items in STAGEDIR missing from pkg-plist Error: Orphaned: @unexec rmdir "/var/spool/dma" >/dev/null 2>&1 || : ===> Checking for directories owned by MTREEs ===> Checking for directories handled by dependencies ===> Checking for items in pkg-plist which are not in STAGEDIR Error: Missing: @dirrmtry var/spool/dma ===> Error: Plist issues found. With hat: portmgr Reported by: erwin
* - Fix check-plist showing @sample dest files as orphans and also showing inbdrewery2014-05-171-1/+8
| | | | | | | makeplist. Reported by: droso With hat: portmgr
* - Move security-check.awk to Mk/Scripts where it is more proper these days.bdrewery2014-05-101-0/+100
| | | | With hat: portmgr
* - Fix regression handling files with spaces from r350006.bdrewery2014-05-101-21/+40
| | | | | | | | | | | | Separate file(1) and stat(1) output by a newline and read each line individually to avoid losing spaces. - Use <<-EOF with heredocs to avoid bad indent - Add some more comments - Quote filenames in output so it is less unclear Spotted by: mandree Reviewed by: antoine With hat: portmgr
* Let stage-qa detect .la libraries and warn that a port needs USES=libtool.tijl2014-05-061-1/+12
| | | | | PR: ports/189255 Approved by: portmgr (antoine)
* - Ignore MTREE owned PREFIX and PREFIX/info removal for now.bdrewery2014-05-041-1/+11
| | | | | | | | The removal of PREFIX/info may be a bug in bsd.port.mk and needs more testing. With hat: portmgr Reported by: gerald
* - Always ignore /root/.ccache. Missed with r352918bdrewery2014-05-041-1/+1
| | | | With hat: portmgr
* - Fix check-stagedir causing staging violating. Quote all directory namesbdrewery2014-04-251-2/+5
| | | | | | | | | when doing plist checks. This could leak out if an unsupported format was used such as 'rmdir -p' or 'rmdir dir1 dir2 dir3' With hat: portmgr Reported by: antoine Pointyhat to: bdrewery
* - Fix false-positive orphanned dir when '@unexec rmdir -p' is used.bdrewery2014-04-251-3/+3
| | | | | Reported by: antoine With hat: portmgr
* - Refactor a bit into functionsbdrewery2014-04-251-234/+290
| | | | With hat: portmgr
* check-plist: Don't error if GNOME_MTREE_FILE is missing, which can happenbdrewery2014-04-241-1/+1
| | | | | | | in nox11 ports that USE_GNOME. With hat: portmgr Reported by: swills
* - Handle plist containing @unexec /bin/rmdirantoine2014-04-241-5/+5
| | | | | | - Handle directories ending with digits With hat: portmgr
* - Fix handling of "@comment @cwd" so it does not reset real @cwd; onlybdrewery2014-04-231-7/+37
| | | | | | | | change the cwd for commented lines (such as %%OPTION%%file). Reset it back to the normal on the first non-commented line. - Sort files after stripping out @comment With hat: portmgr
* Fix directory keywords handlingantoine2014-04-221-1/+1
| | | | | Reviewed by: bdrewery With hat: portmgr
* - For pkg run-depends dir listing, consider deps recursively.bdrewery2014-04-221-7/+21
| | | | | | | | | pkg_install already did this. - Speedup the pkg_install run-depends listing by processing unique packages. With hat: portmgr Reported by: antoine
* Fill orphans white list with files regenerated by installation scripts:antoine2014-04-221-1/+16
| | | | | | | | | - info directories - fonts.dir and fonts.scale - desktop database - mime database With hat: portmgr
* - Do not advise to strip non FreeBSD binaries [1]antoine2014-04-221-4/+4
| | | | | | | - Shorten messages Requested and tested by: xmj [1] With hat: portmgr
* - Split MTREE check into its own checkbdrewery2014-04-221-5/+17
| | | | | | | | | | | | | | | | | | | - Split dependency-owned check its own and make into a non-fatal warning. This is not black-and-white. Python/Rubygem ports cleanup the lib dir for every installed package, and for python/ruby-gems too. This is fine, the extensions should not clean them up then; the error is valid here. However, there's other frameworks which don't cleanup in the master package and yield unexpected results. An example is that php does not cleanup etc/php itself. Only extensions do. So if an extension depends on another extension it will complain that the dependent extension owns etc/php, so we remove from bsd.php.mk, now it's a leftover. The proper place is in the php port itself, but it's unknown how many other cases there are like this. So for now make this non-fatal and into a warning. This is all mostly moot once pkg auto handles directories anyhow. With hat: portmgr Discussed with: antoine
* - Sort directories by Lexicographical Depth-First order (find -ds)bdrewery2014-04-221-7/+27
| | | | With hat: portmgr
* Fix plist_sub_sed_sort.sh when value contains spacesantoine2014-04-211-1/+1
|
* - Rename check-orphans to check-plist. Keep the old for backwards-compat.bdrewery2014-04-193-47/+232
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Bug fixes: makeplist/check-plist: - Fix showing directories owned by RUN_DEPENDS/LIB_DEPENDS [1] - Use proper "rmdir PATH" syntax, not "rmdir >/dev/null... PATH" which pkg will not recognize. - Never consider base /etc/mtree/BSD.usr.dist or LOCLABASE Templates/BSD.local.dist as needing @dirrm handling. check-plist: - Fix showing PORTDOCS/PORTEXAMPLES files when the OPTIONS are not set. makeplist will still suggest them. - Fix showing files installed through unselected OPTIONS as orphans, by considering "@comment file" to be ignored. [2] - Fix @sample, @fc, @fcfontsdir, @fontsdir support - Fix return status when orphans are found to be non-zero - Add note when PREFIX=!LOCALBASE - Be more clear when orphans/no orphans are found. - Add a whitelist mechanism for globally approved ignores. - Add *.bak/*.orig to orphan whitelist for now. - Fix false-positive with dirs installed to /, such as with archivers/dpkg creating /var/db/dpkg - Fix false-positive with @dirrm ending in /, such as with ports-mgmt/poudriere with a @dirrmtry share/zsh/ - There are likely still some false-positives. I fixed as many as I could find. Please let me know of others. * One in particular that is not easily fixable is installing a file into a directory owned by another port where that other port is not a run-time dependency. So the leaf port may create all of the parent dirs and never clean them up. Cleaning them up is not proper unless no other package is depending on them. This will be addressed by pkg(8) once pkg_install is EOL, or sooner. - Consider @dirrm of directories owned by run-time dependencies, or /etc/mtree/* or Templates/BSD.local.dist (at LOCALBASE) as fatal errors. These should not be removed in the plist. @comment lines are not considered for this; they will not ignore an error. ===> Checking for directories owned by dependencies or MTREEs Error: Owned by dependency: @dirrmtry share/locale/af/LC_MESSAGES Error: Owned by dependency: @dirrmtry share/locale/af Error: Owned by dependency: @dirrmtry %%PERL5_MAN3%% - Detect files in plist that do not exist in the stagedir. Pkgng already did this, but now we have it unified with this check. @comment lines are not considered for this; they will not ignore an error. ===> Checking for items in pkg-plist which are not in STAGEDIR Error: Missing: foo Error: Missing: @dirrmtry bar - Change orphaned output due to several new errors introduced: ===> Checking for items in STAGEDIR missing from pkg-plist Error: Orphaned: foo - Send errors to stderr check_leftovers.sh: - Prefer longer values for PLIST_SUB. bsd.options.mk: - Fix NOPORTDOCS/WITHOUT_NLS/NOPORTEXAMPLES not unsetting their respective OPTIONS. - Mark NOPORTDOCS/NOPORTEXAMPLES deprecated and hook them into the OPTIONS_WARNING to tell users the new format. - check-stagedir.sh refactoring: - Switch to using new PLIST_SUB_SED - Use ! instead of , in sed(1) regex to allow files/dirs with ',' - Rework PORTEXAMPLES/PORTDOCS handling so it acts on PLIST_SUB_SED'd value and not absolutes. Also simplify the regex for these a bit to allow reuse. - No longer need DOCSDIRS/EXAMPLESDIR in env - Wrap long lines - Unset some vars in env when they are done being used to free space for larger sed vars - Cleanup redundant sed regexes - Add a Scripts/plist_sub_sed_sort.sh to prefer longer values when substituting over shorter values. - To make check-plist ignore a file *as an orphan* do one of the following: 1. Install it 2. post-install: ${RM} ${STAGEDIR}file 3. Put the file behind an OPTION with a PLIST_SUB: %%OPTION%%file 4. Add to plist as a @comment [2]: @comment file @comment @dirrmtry dir Reviewed by: mat (much earlier version) Discussed with: mat, antoine, bapt, swills (various bits) With hat: portmgr PR: ports/185561 [1] Reported By: Alexander Yerenkow <yerenkow@gmail.com> [1] Tested with: pkg and pkg_install Reported by: many (false-positives) [2] This is a partial solution, we may still need a plist.ignore too. It doesn't make much sense to add files in main pkg-plist we don't care about, but maybe it does since you'll see and reconsider them being ignored someday. @comment is used as all the OPTION PLIST_SUB deactivations use @comment instead of something like @ignore.
* - Fix HOMEDIR handling to not exclude all directories for ports without USERSbdrewery2014-04-171-1/+1
| | | | | Reported by: antoine With hat: portmgr
* - Document PLIST_SUB_SED= will disable PLIST_SUB hintsbdrewery2014-04-171-6/+21
| | | | | | | | - Avoid a redundant 'test -d' - Properly show %%PORTEXAMPLES%% %%PORTDOCS%% where needed - Avoid some forking for always-ignored files With hat: portmgr
* - Add script for handling leftover processing by poudriere/tinderbox.bdrewery2014-04-171-0/+139
| | | | | | | | | | | | | | | | | | | | | | | | This will contain all approved/whitelisted leftovers in a single reference. It will also allow us to update the whitelist without needing a new release of poudriere/tinderbox and forcing users to update those tools. Usage: env PORTSDIR=... check_leftovers.sh category/port stdin: - missing-file + new-file M modified-file reason... stdout: same -/+/M format, but with files substituted, without approved whitelisted files, and hides any directories already in plist. - Add /var/qmail/queue to the list of whitelisted directories just as /var/mail is. This queue directory contains mails in flight and may receive or have mail removed during an upgrade. Obtained from: Mostly poudriere Reviewed by: antoine With hat: portmgr
* Do not advise to strip ELF relocatables, usually it is harmfulantoine2014-04-131-1/+3
| | | | With hat: portmgr
* Reduce the number of false positives reported by the shebang qa checkantoine2014-04-131-19/+45
| | | | | | | by looking only at files and symlinks in bin, sbin and libexec Reviewed by: bdrewery With hat: portmgr
* - Make shebang a warning for now, too many false-positives in files webdrewery2014-04-111-2/+2
| | | | | | | | do not care about. antoine@ is working on a better solution for this. With hat: portmgr
* Allow to properly run make check-orphans and make makeplist for gnome portsbapt2014-04-111-1/+5
|
* Rewrite the sharedmimeinfo qa check so that it doesn't produce a falseantoine2014-04-091-4/+11
| | | | | | | positive on misc/shared-mime-info With help from: bdrewery With hat: portmgr
* - stage-qa: Fix absolute symlink check to look at target not fully resolvedbdrewery2014-04-031-1/+1
| | | | | | | | path. Now tested on both good and bad symlinks. Reported by: antoine Pointyhat to: bdrewery With hat: portmgr
* - Fix fatal checks not exiting with non-zero [1]bdrewery2014-04-031-16/+46
| | | | | | | | | | | | This means that files referrencing stagedir or linked to stagedir will now be fatal errors as intended. - Stop polluting global namespace with IFS changes - Speedup find(1) -exec usage by execing far less - Ignore known false-positive/harmless stagedir files in paths() [2] Reported by: eadler [1] Discussed with: antoine [2] With hat: portmgr
* Remove quotes around values we get in PLIST_SUB. [1]mat2014-02-251-2/+2
| | | | | | | While there, don't replace 1 char entries in PLIST_SUB. Noticed by: amdmi3 [1] Sponsored by: Absolight
* Try and force people to check the plist makeplist generates.mat2014-02-101-0/+1
| | | | | | With hat: portmgr Reviewed by: bapt Sponsored by: Absolight
* - Do not check for ${WRKDIR} in staged files, there are lots of falseantoine2014-01-291-7/+5
| | | | | | | | positives as some .o files may embed the source path [1] - Only check shebang of files with executable bit set Requested by: bapt [1] With hat: portmgr
* Greatly enhance makeplist to replace all it can find in PLIST_SUB.mat2014-01-281-4/+17
| | | | | With hat: portmgr Sponsored by: Absolight
* Do not show orphans anymore with pkgng for .info filesbapt2014-01-271-0/+5
|
* Fix paths check from qa.shantoine2014-01-101-2/+1
| | | | | | IFS is set to newline so dirs was not correctly splitted Approved by: portmgr (bapt)
* pkgng expect all non ascii code and '%' to be urlencoded in the commentbapt2014-01-071-0/+23
| | | | | Reported by: antoine Tested by: antoine
* /usr/bin/nawk and /bin/csh are valid shebangsbapt2013-12-071-0/+2
|
* Fixup makeplist for directories.mat2013-11-301-1/+1
| | | | | | | | | | | Without, it'll generate : @dirrmtry %%PORTDOCS%%%%DOCSDIR%% With : %%PORTDOCS%%@dirrmtry %%DOCSDIR%% PR: ports/184287 Submitted by: mat Approved by: bapt
* - in qa.sh, properly work with filenames containing blank or tab,mandree2013-11-232-10/+15
| | | | | | | | | | | | | by setting IFS to just LF - in check-stagedir.sh, properly detect unset environmental variables, and list them all - in check-stagedir.sh, also list the full prefix as known, not just its parents PR: 184039 Approved by: portmgr (bapt)
* bsd.stage.mk: Fewer false positives, much faster, easier maintenance.mandree2013-11-012-2/+116
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bugfixes: * @cmd in pkg-plist is now properly handled. - It was previously treated the same as though there was a directory following it, missing the prefix. (ordering matters in case...esac) - Due to the cwd=${PREFIX} inside the while read line loop, state tracking was broken and every new line assumed that cwd were the prefix. * stage-qa no longer complains about unstripped binaries if debugging is active (WITH_DEBUG set && WITHOUT_DEBUG unset). * The compress-man target uses ECHO_MSG, not ECHO_CMD, to print its build step. Additions: * The plist parser now understands @unexec rmdir ... || ... lines, including those with redirections, so that there are no false positives for directories stripped with @unexec rmdir (usually happens on stuff installed outside $PREFIX, as in /var). * The system's root and var mtrees are now also expanded to avoid false @dirrm positives if a port installs directories under /var and has to create parents in the stagedir that are present in a fully installed system (i. e. in the real $PREFIX). * Given that pkg_create is deemed beyond repair with respect to deleting files outside prefix, generate @unexec rmdir statements for such directories, rather than @dirrmtry, to sidestep the problem. Speedups: * the orphan check now generates sorted lists of staged files, and plisted/mtree files, and compares them with comm(1). This saves us the overhead of running one grep process per file and up to two per directory, and defers the actual list processing to a shell utility. Complexity has not changed, but overhead per item has. * the orphan check now uses one file for directories and one file for files mentioned in pkg-plist, so we need not decorate them with "dir " and parse them out any longer. * qa.sh's shebang scanner only looks at the first line of a file, sed is told to exit from the 2nd line. Other Changes: * Split the makeplist/check-orphans logic out of bsd.stage.mk, it is too unwieldy to maintain in make-escaped shell syntax, and permits shell tracing with "SH=sh -x" (including quotes!) * Unify the functions "makeplist" and "check-orphans" in one script. The only difference is that makeplist assumes an empty pkg-plist, whereas check-orphans parses it. * overhaul the mtree extractor, avoiding awk. Reviewed by: bapt Approved by: portmgr (bapt)
* - Add check for suid files and directoriesak2013-10-211-1/+12
| | | | Approved by: portmgr (bapt)
* Recommand to use STRIP_CMD to strip binaries given that it will respect the ↵bapt2013-10-191-1/+1
| | | | WITH_DEBUG option
* - Fix desktopfileutils() and sharedmimeinfo() returning non-zero and causingbdrewery2013-10-111-0/+2
| | | | | | | | | | failure on every port that does not use shared-mime-info or need it. Must return 0 at end of functions or it considers the last command ran as the return code. Reported by: eadler With hat: portmgr
* Add two QA tests for staged ports:antoine2013-10-111-1/+21
| | | | | | | - check for desktop files handling MIME types - check for share MIME-Info database Approved by: portmgr (bapt)
* - Move dialog4ports.sh to more appropriate new directory Mk/Scripts asbdrewery2013-10-101-0/+48
| | | | | | | it is related to infrastructure/framework and a required portmgr- maintained script With hat: portmgr
* First set of Q/A for staged ports.bapt2013-10-091-0/+82
A couple of Q/A tests are done if the DEVELOPER macros is set in make.conf Right now the tests are: - Check if the symlinks are properly created - Check if the binaries are stripped (just warn) - Check if the STAGEDIR or the WORKDIR are referenced in the final files - Check if the ports provide script with bad shebangs.
generated by cgit (git 2.34.1) at 2024-11-27 21:08:06 +0800