The accessors pragma lets you create simple accessors at compile-time.
This saves you from writing them by hand, which tends to result in cut-n-paste
errors and a mess of duplicated code. It can also help you reduce the ammount
of unwanted direct-variable access that may creep into your codebase when
you're feeling lazy. accessors was designed with laziness in mind.
Method-chaining accessors are generated by default. This may be changed in
future versions! If you want backwards compatability use accessors::chained
and wait until the dust settles.
See accessors::classic for accessors that always return the current value if
you don't like method chaining.
WWW: http://search.cpan.org/dist/accessors/
/1999/xhtml'>
Fix Qt5 symbol version scripts to put the catch-all clause first. When2019-01-16T11:13:44+00:00tijltijl@FreeBSD.org2019-01-16T11:13:44+00:000c123abc65c17a023a06fa03c2da7624f5a40a03
a symbol matches multiple clauses the last one takes precedence. If the
catch-all is last it captures everything. In the case of Qt5 libraries
this caused all symbols to have a Qt_5 label while some should have
Qt_5_PRIVATE_API. This only affects lld because GNU ld always gives the
catch-all lowest priority.
Older versions of Qt5Webengine exported some memory allocation symbols from
the bundled Chromium. Version 5.9 stopped exporting these [1] but the
symbols were kept as weak wrappers for the standard allocation functions to
maintain binary compatibility. [2][3] The problem is that the call to the
standard function in these weak wrappers is only resolved to the standard
function if there's a call to this standard function in other parts of
Qt5Webengine, because only then is there a non-weak symbol that takes
precedence over the weak one. If there's no such non-weak symbol the call
in the weak wrapper resolves to the weak wrapper itself creating an infinite
call loop that overflows the stack and causes a crash. Some of the
allocation functions are variants of C++ new and delete and it probably
depends on the compiler whether these variants are used in other parts of
Qt5Webengine.
Remove the weak wrappers (make them Linux specific). This isn't binary
compatible but we are already breaking that with the changes to the symbol
versions.
[1] https://github.com/qt/qtwebengine/commit/5c2cbfccf9aafb547b0b30914c4056abd25942a4
[2] https://github.com/qt/qtwebengine/commit/2ed5054e3a800fa97c2c9e920ba1e6ea4b6ef2a5
[3] https://github.com/qt/qtwebengine/commit/009f5ebb4bd6e50188671e0815a5dae6afe39db5
Bump all ports that depend on Qt5.
PR: 234070
Exp-run by: antoine
Approved by: kde (adridg)
a symbol matches multiple clauses the last one takes precedence. If the
catch-all is last it captures everything. In the case of Qt5 libraries
this caused all symbols to have a Qt_5 label while some should have
Qt_5_PRIVATE_API. This only affects lld because GNU ld always gives the
catch-all lowest priority.
Older versions of Qt5Webengine exported some memory allocation symbols from
the bundled Chromium. Version 5.9 stopped exporting these [1] but the
symbols were kept as weak wrappers for the standard allocation functions to
maintain binary compatibility. [2][3] The problem is that the call to the
standard function in these weak wrappers is only resolved to the standard
function if there's a call to this standard function in other parts of
Qt5Webengine, because only then is there a non-weak symbol that takes
precedence over the weak one. If there's no such non-weak symbol the call
in the weak wrapper resolves to the weak wrapper itself creating an infinite
call loop that overflows the stack and causes a crash. Some of the
allocation functions are variants of C++ new and delete and it probably
depends on the compiler whether these variants are used in other parts of
Qt5Webengine.
Remove the weak wrappers (make them Linux specific). This isn't binary
compatible but we are already breaking that with the changes to the symbol
versions.
[1] https://github.com/qt/qtwebengine/commit/5c2cbfccf9aafb547b0b30914c4056abd25942a4
[2] https://github.com/qt/qtwebengine/commit/2ed5054e3a800fa97c2c9e920ba1e6ea4b6ef2a5
[3] https://github.com/qt/qtwebengine/commit/009f5ebb4bd6e50188671e0815a5dae6afe39db5
Bump all ports that depend on Qt5.
PR: 234070
Exp-run by: antoine
Approved by: kde (adridg)
Port misc/qbrew away from Qt4 to Qt5. While at it, assume maintainership.2018-11-26T21:20:37+00:00adridgadridg@FreeBSD.org2018-11-26T21:20:37+00:0033fe01d19fff253a334d2a2bcd2803ec61e1a9d2
This was discussed over email with David. Upstream is unmaintained, but
it works with these minor patches.
This was discussed over email with David. Upstream is unmaintained, but
it works with these minor patches.
Mark BROKEN: fails to build2018-11-04T14:22:04+00:00antoineantoine@FreeBSD.org2018-11-04T14:22:04+00:00dac0c1ae98936a8257e7fbe3752cab522710fa42
src/beerxmlreader.cpp:257:16: error: no viable conversion from returned value of type 'bool' to function return type 'Recipe'
return false;
^~~~~
Reported by: pkg-fallout
src/beerxmlreader.cpp:257:16: error: no viable conversion from returned value of type 'bool' to function return type 'Recipe'
return false;
^~~~~
Reported by: pkg-fallout
Add DOCS options to ports that should have one.2018-09-10T13:14:50+00:00matmat@FreeBSD.org2018-09-10T13:14:50+00:006baece3b7ae06d93445a0e0ecf02e59541a92a95
Also various fixes related to said option.
PR: 230864
Submitted by: mat
exp-runs by: antoine
Also various fixes related to said option.
PR: 230864
Submitted by: mat
exp-runs by: antoine
Replace bsd.qt.mk by Uses/qt.mk and Uses/qt-dist.mk2018-06-28T17:39:53+00:00tcbernertcberner@FreeBSD.org2018-06-28T17:39:53+00:002a8bcfc8ea71d4438b926a8adc477de360863145
From now on, ports that depend on Qt4 will have to set
USES= qt:4
USE_QT= foo bar
ports depending on Qt5 will use
USES= qt:5
USE_QT= foo bar
PR: 229225
Exp-run by: antoine
Reviewed by: mat
Approved by: portmgr (antoine)
Differential Revision: →https://reviews.freebsd.org/D15540
From now on, ports that depend on Qt4 will have to set
USES= qt:4
USE_QT= foo bar
ports depending on Qt5 will use
USES= qt:5
USE_QT= foo bar
PR: 229225
Exp-run by: antoine
Reviewed by: mat
Approved by: portmgr (antoine)
Differential Revision: →https://reviews.freebsd.org/D15540