diff options
| author | Marco Pesenti Gritti <marco@it.gnome.org> | 2003-05-21 18:08:25 +0800 |
|---|---|---|
| committer | Marco Pesenti Gritti <mpeseng@src.gnome.org> | 2003-05-21 18:08:25 +0800 |
| commit | 45a14654f55a8d6270fe483e2fdd40b88c246275 (patch) | |
| tree | 7fb67f1d12ee14e487e7fb630059af500a44d24f | |
| parent | 8ed5b305fdbaa74d7389ac9eb3baf209709296b1 (diff) | |
| download | gsoc2013-epiphany-45a14654f55a8d6270fe483e2fdd40b88c246275.tar.gz gsoc2013-epiphany-45a14654f55a8d6270fe483e2fdd40b88c246275.tar.zst gsoc2013-epiphany-45a14654f55a8d6270fe483e2fdd40b88c246275.zip | |
Do not free memory is not a good idea
2003-05-21 Marco Pesenti Gritti <marco@it.gnome.org>
* embed/ephy-favicon-cache.c: (ephy_favicon_cache_save):
Do not free memory is not a good idea
* lib/ephy-node-db.c: (ephy_node_db_set_name):
Free it two times is even worst
| -rw-r--r-- | ChangeLog | 10 | ||||
| -rw-r--r-- | embed/ephy-favicon-cache.c | 2 | ||||
| -rw-r--r-- | lib/ephy-node-db.c | 3 |
3 files changed, 13 insertions, 2 deletions
@@ -1,3 +1,13 @@ +2003-05-21 Marco Pesenti Gritti <marco@it.gnome.org> + + * embed/ephy-favicon-cache.c: (ephy_favicon_cache_save): + + Do not free memory is not a good idea + + * lib/ephy-node-db.c: (ephy_node_db_set_name): + + Free it two times is even worst + 2003-05-20 Marco Pesenti Gritti <marco@it.gnome.org> * lib/ephy-dnd.c: (ephy_dnd_drag_data_get), diff --git a/embed/ephy-favicon-cache.c b/embed/ephy-favicon-cache.c index 6ae56c3f9..5488a9451 100644 --- a/embed/ephy-favicon-cache.c +++ b/embed/ephy-favicon-cache.c @@ -254,6 +254,8 @@ ephy_favicon_cache_save (EphyFaviconCache *eb) ephy_node_thaw (eb->priv->icons); xmlSaveFormatFile (eb->priv->xml_file, doc, 1); + + xmlFreeDoc (doc); } static void diff --git a/lib/ephy-node-db.c b/lib/ephy-node-db.c index 366b55365..86913d93c 100644 --- a/lib/ephy-node-db.c +++ b/lib/ephy-node-db.c @@ -81,8 +81,7 @@ ephy_node_db_set_name (EphyNodeDb *db, const char *name) if (ephy_node_databases == NULL) { - ephy_node_databases = g_hash_table_new_full - (g_str_hash, g_str_equal, g_free, NULL); + ephy_node_databases = g_hash_table_new (g_str_hash, g_str_equal); } g_hash_table_insert (ephy_node_databases, db->priv->name, db); |