aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorChristian Persch <chpe@cvs.gnome.org>2006-12-18 03:19:09 +0800
committerChristian Persch <chpe@src.gnome.org>2006-12-18 03:19:09 +0800
commit33b81fc6775af261ecc5ae50034a9a9307905f09 (patch)
tree574e593ccd381422b1652890601d8e2e32f3d85d
parentf509a34254a254348465dbe018c6ee9db081193e (diff)
downloadgsoc2013-epiphany-33b81fc6775af261ecc5ae50034a9a9307905f09.tar.gz
gsoc2013-epiphany-33b81fc6775af261ecc5ae50034a9a9307905f09.tar.zst
gsoc2013-epiphany-33b81fc6775af261ecc5ae50034a9a9307905f09.zip
Fix a signal leak. Bug #363837, patch by John Millikin.
2006-12-17 Christian Persch <chpe@cvs.gnome.org> * src/bookmarks/ephy-topic-action.c: (button_deactivate_cb): Fix a signal leak. Bug #363837, patch by John Millikin.
-rw-r--r--ChangeLog6
-rw-r--r--src/bookmarks/ephy-topic-action.c7
2 files changed, 13 insertions, 0 deletions
diff --git a/ChangeLog b/ChangeLog
index a79c7a8f0..084ac488c 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2006-12-17 Christian Persch <chpe@cvs.gnome.org>
+
+ * src/bookmarks/ephy-topic-action.c: (button_deactivate_cb):
+
+ Fix a signal leak. Bug #363837, patch by John Millikin.
+
2006-12-17 Eric Butler <eric@extremeboredom.net>
* src/ephy-embed.h:
diff --git a/src/bookmarks/ephy-topic-action.c b/src/bookmarks/ephy-topic-action.c
index a09fd35ee..9bed16852 100644
--- a/src/bookmarks/ephy-topic-action.c
+++ b/src/bookmarks/ephy-topic-action.c
@@ -296,6 +296,13 @@ button_deactivate_cb (GtkMenuShell *ms,
{
gtk_toggle_button_set_active (GTK_TOGGLE_BUTTON (button), FALSE);
gtk_button_released (GTK_BUTTON (button));
+
+ /*
+ Currently, GObject leaks connection IDs created with
+ g_signal_connect_object ()
+ See glib bug #118536
+ */
+ g_signal_handlers_disconnect_by_func(ms, button_deactivate_cb, button);
}
static void