aboutsummaryrefslogtreecommitdiffstats
path: root/HACKING
diff options
context:
space:
mode:
Diffstat (limited to 'HACKING')
-rw-r--r--HACKING38
1 files changed, 20 insertions, 18 deletions
diff --git a/HACKING b/HACKING
index 433872104..8264d7ae9 100644
--- a/HACKING
+++ b/HACKING
@@ -13,24 +13,26 @@ need to stick to in order to get your patch accepted:
* bla_bla_cb: This is an example comment block
*/
-When submitting a patch or committing to cvs do not forget
-to write a Changelog entry. Please put both a description
-and a reference to the bug (if there is one). Write your entry
-using UTF-8 encoding, and make sure your editor doesn't mangle
-the encoding of the ChangeLog file.
-
-
-Example of an entry:
-
-2004-02-19 Christian Persch <chpe@cvs.gnome.org>
-
- * lib/egg/egg-toolbar-editor.c: (toolbar_removed_cb),
- (egg_toolbar_editor_set_model), (egg_toolbar_editor_class_init),
- (update_actions_list), (egg_toolbar_editor_load_actions):
- * lib/egg/egg-toolbar-editor.h:
-
+SVN Checkin rules:
+
+When committing a patch to svn, you must use a checkin comment that fully
+describes the changes made. If the checkin is related to a bug, reference
+the bug number. Example:
+
When removing a toolbar, make its items available again in the toolbar
editor. (Bug #131182)
-Do NOT commit to this module without permission from me
-(marco@gnome.org)
+Checkin comments MUST use the UTF-8 encoding.
+
+If you forget to check in some changes that belonged in the same commit (e.g. omitted
+a file), you must copy the checkin comment from the previous, incomplete checkin, and
+additionally reference that commit's svn revision number. DO NOT use meaningless checkin
+comments such as "forgotten file" !
+If you make a major mistake in the checkin comment (e.g empty, or you've forgotten to cite
+the bug numbers), you must create a new checkin that touches all files the original checkin
+changed (just using whitespace changes is ok), and in the new checkin comment must note that
+this new checkin fixes the original checkin, referencing it by its SVN revision number.
+
+Do NOT commit to this module without permission from a maintainer. See the MAINTAINERS file
+for who they are.
+