| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
Use the already existing functions we have for print preview also for
printing; fixes a bunch of usability issues.
Bug #609756
Signed-off-by: Xan Lopez <xan@gnome.org>
|
|
|
|
|
|
|
|
|
|
| |
Some sites don't use a sane type attribute in their input tags. So for example
you get input tags without a type, or with multiple types. Offenders are
bugzillas and ohloh.net.
Luckily, WebKit inferres correctly what the input should be so instead of
relying on what the HTML says we rely on what WebKit thinks.
Bug #608740
|
|
|
|
|
|
|
| |
This retrieves a property from a JS object, just like "element.property" in
plain javascript.
Bug #608740
|
|
|
|
|
|
|
|
|
|
|
| |
If we handle shift+click in EphyWebView default handler then we will be
preventing WebKit from getting *any* shift+click event, this breaks shift+click
for extending selection. Removing that however makes shift+click browse to
links just as click would do. The solution is to prevent
policy_decision_required_cb to browse to the clicked link when it includes the
shift modifier.
Bug #610844
|
|
|
|
|
|
|
| |
This fixes a crash reported ad-hoc in
https://bugzilla.gnome.org/show_bug.cgi?id=609753. This is needed
because we may bail out early, and try to free these strings without
having properly initialized them.
|
|
|
|
|
|
|
|
| |
In ephy_web_view_button_press_event we are being too liberal with "&" when
checking for modifiers, we want == so we don't prevent handling elsewhere.
Also explain the function a bit more.
Bug #604950
|
|
|
|
| |
Too wide comments, some indentation.
|
|
|
|
|
|
|
|
|
| |
JSStringGetLength returns the number of UTF8 chars in the string, using this
value results in trimmed strings when they contain UTF8 chars.
The correct function is JSStringGetMaximumUTF8CStringSize that reports the
number of bytes the string requires to be allocated, including null-byte.
Bug #609936
|
|
|
|
|
|
| |
A previous patch to fix it from crashing on NULL strings changed how
the strings are managed in general, so we were using variables
containing garbage in some cases.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Created function ephy_web_view_show_print_preview, which replaces the
old implementation of print preview, which was not working now.
Preview is displayed in an external viewer, so print preview mode does
no longer exist.
All functions of the old implementation of print preview have been
removed, PPViewToolbar was removed also. Also, as EphyWebView has no
more a print preview mode, all functions which checked if a view was
in print preview mode were modified.
Bug #609021
|
|
|
|
| |
Bug #608517
|
| |
|
|
|
|
| |
Since we are not marking windows as popups for now.
|
|
|
|
|
|
|
|
|
|
| |
Some resources might be of the style "page.php?orig=/place/other", this would
make Epiphany crash while saving them because of the invalid characters for the
filename.
To solve this we escape the name of the resources before using it as the
name of the destination file.
Bug #606876
|
|
|
|
|
|
|
|
|
|
| |
In ephy_web_view_save_sub_resources the destination_uri var is passed down to
the GAsyncReadyCallbacks and is freed after all the operations are finished,
however it is named sub_destination_uri in this callbacks. To make it more
obvious that it is the same data we renamed all the ocurrences to
destination_uri.
Bug #606876
|
|
|
|
| |
Bug #606876
|
|
|
|
| |
Bug #605480
|
|
|
|
|
|
| |
Include a mention to the username being saved and the domain where the form is.
Bug #605022
|
| |
|
|
|
|
|
|
|
|
| |
We consider all windows opened by the web page without user
intervention as popups, and allow them to be closed in the same way if
the page so requests.
Bug #599009
|
|
|
|
|
| |
This is so that changes to the item objects do not affect other
WebViews.
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
Fixes crasher in pages with no rel elements.
|
| |
|
| |
|
| |
|
|
|
|
| |
Signed-off-by: Xan Lopez <xan@gnome.org>
|
|
|
|
|
|
|
|
|
| |
This is a "draft" quality implementation. There are some FIXMEs, and a
bunch of caveats, like private profiles not being taken into
consideration, and the user not being asked whether they want to save
the passwords or not.
Bug #582267
|
|
|
|
|
|
| |
Fixes Amazon Add to Wishlist bookmark.
Bug #604489
|
|
|
|
|
|
|
|
|
| |
This shouldn't happen in theory, but the double check fixes a crasher
opening URLs from gmail.
Bug #604375
Signed-off-by: Xan Lopez <xan@gnome.org>
|
|
|
|
| |
Also redundant since we have the same thing in WebKitWebView now.
|
|
|
|
| |
We already have WebKitWebView::icon-loaded, so it's redundant now.
|
|
|
|
|
|
|
|
| |
This restores basic favicon functionality. In the future we will want
to replace our favicon cache with the IconDatabase that is available
in WebKit.
Bug #601859
|
|
|
|
|
|
|
|
| |
Defaults to Google, like it used to.
Bug #604087
Signed-off-by: Xan Lopez <xan@gnome.org>
|
|
|
|
|
|
|
| |
This allows us to perform downloads when the server tells us to do so,
even for types WebKit supports. This fixes downloading GMail attachments.
Bug #598605
|
|
|
|
| |
Connecting to notify::document-type is enough.
|
| |
|
|
|
|
| |
Bug #503852
|
|
|
|
| |
Bug #503852
|
|
|
|
| |
Bug #603324
|
|
|
|
|
|
| |
Partial fix for bug #599757.
Signed-off-by: Xan Lopez <xan@gnome.org>
|
|
|
|
|
|
| |
Partial fix for bug #599757.
Signed-off-by: Xan Lopez <xan@gnome.org>
|
|
|
|
| |
Signed-off-by: Xan Lopez <xan@gnome.org>
|
|
|
|
|
|
|
| |
This change makes sure that all characters that are typed make it to
the search query. Thanks to Dan Winship for pointing out the solution.
Bug #596717
|
|
|
|
|
|
|
| |
Also consider localhost being used along with a port, with a path, and
with a domain.
Bug #595690
|
| |
|
|
|
|
|
|
|
| |
When a page fails to load (for example, when the user cancels it) it
won't go through the FINISHED state, which is the only one we are
taking into account to decide if a page is still loading. Use the new
WEBKIT_LOAD_FAILED status (WebKitGTK+ r48719) too.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I've used all the GTK+ 2.17.11 api available, still missing:
GTK_WIDGET_REALIZED (GTK_WIDGET ())
GTK_WIDGET_MAPPED (GTK_WIDGET ())
GTK_ENTRY->im_context
GTK_STATUSBAR->frame
GTK_STATUSBAR->label
GTK_MESSAGE_DIALOG->label
https://bugzilla.gnome.org/show_bug.cgi?id=595791
Signed-off-by: Xan Lopez <xan@gnome.org>
|
| |
|
|
|
|
|
|
|
|
| |
Use '%s Files', instead of '%s/%s Files' as the translatable string to
avoid confusion, and reuse existing mozilla-era translations. Fix the
languages that had already translated the new strings using old po
files as reference. Also add a translator comment to the source file,
for future reference.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There's a few items (like email link) and actions (like bookmark link)
missing or not working because of missing information in the
WebKitHitTestResult object, but most of the stuff is working.
For some reason the g-ir-scanner is not picking up the correct type
name for WebKitHitTestResult (it uses WebKitHitTestResult instead of
WebKit.HitTestResult), so the introspection support is broken unless
that error is fixed manually. Looking into that ...
Bug #562617
|
|
|
|
| |
Bug #562611
|
|
|
|
|
|
|
|
|
|
|
| |
Otherwise the typed address would get stuck if you tried to load a
page while another was already loading, ie:
- Load URL.
- While it's loading, Ctrl+L, type something else, Enter.
- The new page will load, but the typed address won't be replaced with
the full address as usual. This is particularly bad when you type a
few letters and complete the URL in the dropdown.
|
|
|
|
|
|
| |
The whole thing just had one functionality at this point as far as I
can see: prevent the typed address from being wiped out when a page
is loading. Simplify the code to do just that.
|
| |
|
|
|
|
|
| |
This allows Epiphany itself, and extensions to treat keys that are not
handled by the WebView for in-page search purposes.
|
|
|
|
| |
Just return the status we set when loading.
|
|
|
|
|
|
|
| |
Use a regular expression and SoupURI to figure out if we should search
the string that was typed, or load it as an URI.
Bug #583795
|
|
|
|
|
| |
Much more clear, and avoids confusions with the WebKitWebView function
with similar name.
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
EphyLink is called repeatedly when opening URLs, so normalizing the
address there all the time is pointless. Also, we don't go through
here in all cases, so we need to add the normalization in the
ephy_web_view_load_request function too; this fixes opening URLs like
"foo.com" from the command line, for example.
|
| |
|
|
|
|
|
|
|
| |
This is a workaround for webkit bug
https://bugs.webkit.org/show_bug.cgi?id=26409.
FIRST_VISUALLY_NON_EMPTY_LAYOUT might be emitted after LOAD_FINISHED, so
we just ignore any status change once LOAD_FINISHED has been set
|
|
|
|
|
| |
The bf list now refs newly added items, mostly for the convenience of
bindings.
|
|
|
|
| |
Not many chances it will work.
|
| |
|
|
|
|
|
|
| |
Get rid of our 'load-status' property, and just keep the API semantics
of the ephy_web_view_get_load_status function using the
WebKitWebView's 'load-status' property.
|
|
|
|
|
|
|
|
|
| |
We now use WebKitWebView's 'progress' property directly.
The "opening about:blank blinks the entry" bug is back because for
some reason a) webkit reports a 10% progress for that URL b) get_uri
reports NULL until 100% is loaded for only that page, so blacklisting
by URI is not possible either.
|
| |
|
| |
|
|
|
|
|
|
|
| |
EphyWebView.
Those two embed classes are pretty much dummy leftovers, so it should be
easier to remove them now.
|
| |
|
| |
|
|
|
|
| |
Just part of the gradual progress to get rid of the Embed interface.
|
|
|
|
|
|
| |
As the first API adition to out WebKitWebView subclass, we allow
Epiphany code to use a WebKitNetworkRequest to load pages. This way we
can use the full request information, not just the URI.
|
|
This is an object inheriting from WebKitWebView, and will be used to
house most of the functionality we move from EphyEmbed.
|