| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
There were two paths checking for modified forms and downloads on tab
closing. Instead of duplication code, make EphyEmbedContainer
impl_remove_child trigger ::tab-close-request on EphyNotebook.
https://bugzilla.gnome.org/show_bug.cgi?id=669736
|
|
|
|
|
|
|
|
| |
This is still not enough to make it work, the menu shows empty in
private mode, but the code change is obviously correct. See bug
https://bugzilla.gnome.org/show_bug.cgi?id=647986
https://bugzilla.gnome.org/show_bug.cgi?id=669740
|
|
|
|
|
|
| |
Fixes the uncertain loading state of new windows.
https://bugzilla.gnome.org/show_bug.cgi?id=669130
|
|
|
|
|
|
|
| |
The web-browser icon for the normal/private mode, or the corresponding
Web Application icon.
https://bugzilla.gnome.org/show_bug.cgi?id=669182
|
|
|
|
|
|
| |
Also add proper conversion error handling where needed.
https://bugzilla.gnome.org/show_bug.cgi?id=658028
|
|
|
|
|
|
|
| |
Create 10 fixed GtkActions that react to the alt+# accelerators.
Based on code from gedit-window.c.
https://bugzilla.gnome.org/show_bug.cgi?id=668702
|
| |
|
| |
|
|
|
|
|
|
| |
Back/Forward sensitivity only depends on one factor (whether you can
actually go back or forward), so there is no need to use the ephy
action helper method. This allows to simplify the code quite a bit.
|
|
|
|
| |
It does not seem to do anything.
|
| |
|
|
|
|
|
|
| |
In 99% of the cases we were using it for gtk_window_set_icon_name,
which does nothing in GNOME 3. In the couple of valid use cases, just
use "web-browser" directly.
|
|
|
|
| |
We can kill data/icons now.
|
| |
|
|
|
|
|
| |
Use the symbolic icon for the completion entry, I'm sure Lapo will
approve.
|
| |
|
| |
|
|
|
|
| |
We are not using them.
|
|
|
|
|
|
| |
EphyNotebook was destroying its toplevel when the last tab was
destroyed. I think this is really weird, so move the responsibility to
the window. This will probably break something, I'm sure.
|
|
|
|
| |
It's pretty annoying and hardly useful.
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=666587
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
Add ::is-blank property to EphyWebView and update EphyWindow to sync
some of the page menu actions with it. There's no point in enabling
save/reload/bookmark/etc on about:blank.
https://bugzilla.gnome.org/show_bug.cgi?id=668105
|
|
|
|
|
|
|
| |
Handle every non-web scheme in policy_decision_required_cb with
gtk_show_uri. This enables xmpp:, apt: and similar links to work.
https://bugzilla.gnome.org/show_bug.cgi?id=551857
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=668510
|
| |
|
| |
|
|
|
|
|
| |
It's been #if 0-ed and broken forever too. If someone really wants it
it should probably go into an extension.
|
| |
|
| |
|
|
|
|
|
|
| |
They are not that helpful and are a bit distracting.
https://bugzilla.gnome.org/show_bug.cgi?id=668191
|
|
|
|
|
| |
They have been dead/#if zeroed for a long time without any bugs opened
about it, so I can guess they were not used a lot in their day.
|
| |
|
|
|
|
| |
In particular, don't mention the menus anymore, since they do not exist.
|
| |
|
|
|
|
|
| |
Surely this is not interesting for anyone outside Epiphany? It's not
used in extensions.
|
|
|
|
|
| |
No clue why it was doing that, but seems pointless. I wish I could
make it private but it's used all over the place.
|
|
|
|
|
| |
We don't add widgets to our UI directly from the UI manager, so it's
useless.
|
|
|
|
|
| |
Setting the EphyWindow's location string directly is the kind of crack
that has to be private.
|
| |
|
| |
|
|
|
|
| |
The remaining one kinda makes sense, so leave it alone.
|
| |
|
| |
|
|
|
|
|
| |
ephy_window_set_location and _ephy_window_set_location were
identical. Remove the latter.
|
|
|
|
|
| |
Move another method to ephy-private.h, and stop exporting another one
that is only used internally in EphyWindow.
|
|
|
|
|
|
| |
This should hold methods needed by Epiphany internally but that we do
not want to export. Only a couple of them so far, but we should
probably add a lot more.
|
| |
|
| |
|
|
|
|
|
|
|
| |
We're not a GtkAction anymore, so referencing "proxy" in the code is a
bit misleading.
https://bugzilla.gnome.org/show_bug.cgi?id=668305
|
|
|
|
|
|
|
|
|
| |
We were using priv->proxy, which is a leftover from when this was a
GtkAction, and is actually always NULL. Use the right pointer instead.
Fix location entry failing to properly update the address when switching
tabs.
https://bugzilla.gnome.org/show_bug.cgi?id=668305
|
|
|
|
|
|
| |
So it can be modal.
https://bugzilla.gnome.org/show_bug.cgi?id=668113
|
|
|
|
|
|
| |
Since it's not a GtkAction anymore.
https://bugzilla.gnome.org/show_bug.cgi?id=668206
|
|
|
|
|
|
|
| |
It doesn't really make sense in a world where the location action is
only used on a fixed toolbar, and complicates the code a lot.
https://bugzilla.gnome.org/show_bug.cgi?id=668206
|
|
|
|
|
|
|
|
| |
Instead of a GtkToolItem. A future commit will move the code in
EphyLocationAction not to be a GtkAction, which is why this was a
GtkToolItem in the first place.
https://bugzilla.gnome.org/show_bug.cgi?id=668206
|
| |
|
|
|
|
| |
That way we can drag the app using the toolbar itself.
|
| |
|
| |
|
| |
|
|
|
|
|
| |
It's already accessible from the Print dialog itself, so there's
really no need to duplicate it.
|
|
|
|
|
| |
That was a bad idea. Just store the proxy used for the visibility hack
in the private data too.
|
| |
|
|
|
|
| |
If the binding uses Shift we need to put the letter in uppercase.
|
|
|
|
|
| |
The actions are already in the find toolbar, which is accessible from
the menu, so there's no need to have them there.
|
| |
|
|
|
|
|
| |
So that the WM will use shadows on it as if it was generated from a
menubar.
|
| |
|
| |
|
|
|
|
| |
To aid with styling.
|
|
|
|
| |
To aid styling.
|
|
|
|
| |
And fix a couple of warnings.
|
|
|
|
| |
Yay for sharing code. It also helps theming.
|
| |
|
| |
|
| |
|
|
|
|
| |
Requested by the Design Team.
|
|
|
|
|
| |
Since they are used in context menus too. Re-add those and force the
toolbar buttons to be image-only.
|
| |
|
|
|
|
|
| |
Make a GtkAction subclass that only holds an EphyWindow and nothing
else, and use it throughout. Allows us to kill some duplicated code.
|
|
|
|
| |
They are not in any menu either atm.
|
|
|
|
| |
The focus was staying in the proxy buttons, that's not OK.
|
|
|
|
| |
This way it's easier to access from the theme.
|
|
|
|
| |
It's harder to get the theming right with GtkToolButtons :/
|
|
|
|
| |
Otherwise it's difficult to get the right layout for theming.
|
| |
|
|
|
|
|
|
|
| |
Before we had 'Epiphany' in some places and 'GNOME Web Browser' in
others, try to be consistent and use just 'Web'.
https://bugzilla.gnome.org/show_bug.cgi?id=666587
|
|
|
|
| |
Requested by Lapo. Now we need to fix up the theme.
|
|
|
|
| |
It's a bit more understandable than send-to.
|
|
|
|
|
| |
Otherwise it won't work since it's not in any menu at the moment. That
should change.
|
|
|
|
|
| |
We already pass the app to the window constructor, so no need to do
this again in _init ().
|
| |
|
|
|
|
| |
The default one is not working for some reason...
|
|
|
|
| |
There's no difference between fullscreen and non fullscreen atm.
|
|
|
|
| |
Otherwise fallback to faking it as before.
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=667628
|
| |
|
|
|
|
|
|
| |
Similar to Chrome's wrench menu, but used only (in the future) for
page-related actions. For now we have mechanically moved most stuff
there, now we need to start removing them one by one when appropriate.
|
|
|
|
| |
And remove them from the existing menubar.
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=667634
|
|
|
|
|
|
|
|
|
| |
'Store password' and 'Session recovery' infobars had no mnemonics in
their buttons.
Bug #667238
Signed-off-by: Diego Escalante Urrelo <descalante@igalia.com>
|
| |
|
|
|
|
|
|
|
|
| |
g_setenv() and getenv() are not thread-safe, so we need to make sure
that g_setenv() call in main is done earlier than anything that can
trigger a getenv() call.
https://bugzilla.gnome.org/show_bug.cgi?id=659145
|
| |
|
| |
|
|
|
|
|
|
| |
This reverts commit 9c12735e12a9106cdc68d9555a491642ea791e62.
Turns out it was used :D
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Factor the logic that fakes clicks from a middle click in
EphyMiddleClick(Tool)Button by forwarding a left click to GTK+ when we
receive a middle click. Since ephy_gui_is_middle_click stops working
in this case, add the minimal logic in EphyLinkAction to make it work
again (basically, cache the button that activated the action inside
the action itself).
The EphyMiddleClickable(Tool)Button classes were written by Alexandre
Mazari.
https://bugzilla.gnome.org/show_bug.cgi?id=628364
|
|
|
|
| |
middle click anymore
|
|
|
|
| |
Now we can remove our internal implementation.
|
|
|
|
| |
This is a public function after all.
|
|
|
|
|
|
| |
Since we were only checking the loading status, and it's FALSE by
default, the action would be empty until it was set to loading = TRUE
at least once.
|
|
|
|
|
|
|
| |
In some cases tabs can be added to the window without going through
the EmbedContainer add method (for instance, with DnD of tabs between
windows). Being that the case, set the CID for the statusbar on
notebook's page-added handler, which is always called.
|
| |
|
| |
|
|
|
|
| |
We don't want this either for 3.4, remove it.
|
|
|
|
| |
The menubar will be gone for 3.4, so this will be useless.
|
|
|
|
| |
It's not used anymore.
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
Add a combined action that toggles itself between the two states and
instantiate it from the window. Replace the Reload and Stop buttons
with the combined one in the default toolbar description.
https://bugzilla.gnome.org/show_bug.cgi?id=657655
|
|
|
|
|
|
| |
Store them as "about:" instead, which is the proper kind for loading.
https://bugzilla.gnome.org/show_bug.cgi?id=666206
|
| |
|
| |
|
| |
|
|
|
|
| |
We were warning in way too many more cases than intended.
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
They are unused now.
|
| |
|
|
|
|
| |
The only use in window-commands.c is not superfluous.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows us to stop using EggEditableToolbar here, we just load a
normal toolbar from GtkUIManager in EphyWindow. The special toolbar
actions and methods have been moved to EphyWindow too, mostly in a
mechanical fashion (probably some simplifications are possible).
The code in the bookmarks UI that depended on EphyToolbar has been #if
zeroed instead of porting it, since it will go away in the near future
too.
https://bugzilla.gnome.org/show_bug.cgi?id=664483
|
|
|
|
|
|
| |
The theming was done by Lapo Calamandrei.
https://bugzilla.gnome.org/show_bug.cgi?id=665470
|
| |
|
| |
|
|
|
|
|
| |
To be consistent with our new default behavior, which is to append new
tabs after their parent.
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
Last of the toplevel menus without equivalent in the new design.
|
|
|
|
|
|
| |
There was no implementation, so it was just polluting the codebase. In
the future we probably want a non-optional implementation in the "Page
details" section, using the soup/glib-network APIs.
|
| |
|
|
|
|
|
|
| |
It is not present in the new design. The Alt+<num> accelerators are
dying with it, but it will be pretty easy to bring them back if
needed.
|
|
|
|
|
| |
They are not commonly used and are not present in the new design, so
we can get rid of them.
|
| |
|
|
|
|
|
|
|
|
| |
Hardcode it to be "about:blank". The final step could be completely
remove the rest of the code, but it might be useful for the future
Overview page (if we consider it the new "homepage").
https://bugzilla.gnome.org/show_bug.cgi?id=665469
|
|
|
|
|
|
| |
Later we can remove all the internals to implement the feature.
https://bugzilla.gnome.org/show_bug.cgi?id=665469
|
|
|
|
|
|
|
| |
The UI is gone, but the infrastructure still persists
(EggToolbarModel, etc). Further cleanups are possible.
https://bugzilla.gnome.org/show_bug.cgi?id=664260
|
| |
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=663668
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=664120
|
|
|
|
|
|
| |
We can now get rid of the NetworkManager custom code.
https://bugzilla.gnome.org/show_bug.cgi?id=664096
|
|
|
|
| |
They are not needed anymore.
|
|
|
|
| |
Shows which WebKit version is powering Epiphany.
|
|
|
|
|
|
| |
GtkTable is deprecated.
Bug #661347
|
|
|
|
|
|
|
| |
Build the Cookie Properties dialog with GtkBuilder instead of handcraft
from the past.
Bug #661347
|
| |
|
| |
|
|
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=659103
Signed-off-by: Ionut Biru <ibiru@archlinux.org>
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Session resume will ask to resume the session (opened pages, etc) if
the previous instance crashed. We don't really want this in web app
mode, so skip it. Note that this is not exactly the same than loading
the session, which just restores the previous window sizes and
states. We do want that, but the terminology here could be more clear.
https://bugzilla.gnome.org/show_bug.cgi?id=658739
|
| |
|
| |
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=657624
|
|
|
|
| |
We'll do things properly now.
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=658060
|
|
|
|
|
|
|
| |
Show a confirmation dialog and, in case the user confirms, delete the
old application before saving a new one.
https://bugzilla.gnome.org/show_bug.cgi?id=658060
|
|
|
|
|
|
|
| |
Don't use the filters combobox when it's not really needed nor
meaningful. Specially for save dialogs.
Bug #655713
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=657624
|
|
|
|
|
|
| |
Since it's used in the header file itself. This was working just
because other files including this also were including ephy-node.h
before.
|
| |
|
| |
|
|
|
|
|
|
| |
ephy_web_application_delete
You know, use namespaces correctly and all that.
|
|
|
|
|
|
| |
Plus the necessary code to implement some sort of UI to do this for the
3.2 time frame. Hopefully for 3.4 we'll have a GNOME-wide system to
deal with applications.
|
|
|
|
|
|
|
|
| |
The caching of the GtkEntry was broken, since the toolbar items are
destroyed on switching to/from fullscreen. Update the cache right
after toolbar is rebuilt.
https://bugzilla.gnome.org/show_bug.cgi?id=657936
|
| |
|
|
|
|
| |
Which creates the corresponding Web App.
|
|
|
|
|
| |
This will probably go away in 3.4 when the new dash design is
introduced, but for now it's the best we have.
|
|
|
|
|
| |
If the user tries to navigate to other domain spawn a new process with
"gvfs-open" and the requested URI.
|
|
|
|
|
| |
Using private profile and app mode at the same time does not make
sense.
|
|
|
|
|
| |
We should refactor EphyWindow so that all these UI bits are not even
present in app mode, but for now this will do.
|
|
|
|
|
|
|
|
| |
Allow to save any page as a "Web Application". A new .desktop file
will be created, and added to the Shell as a new application. It will
launch epiphany in application mode, with its own private profile
(inheriting some data from the main profile, like the relevant domain
cookies) and in a new process.
|
|
|
|
|
|
|
| |
Otherwise we can end up with fixed width windows that exceed the display
size when long sentences are displayed.
Bug #649164
|
|
|
|
|
|
|
|
|
| |
GTK+ new UX behavior says we shouldn't set the file chooser directory,
recent directories should be listed (automatically) instead.
Signed-off-by: Xan Lopez <xan@gnome.org>
Bug #655508
|
|
|
|
|
|
|
|
|
|
|
|
| |
Replace local styling (used for the tab close button and embed's status
frame) by a global css sheet loaded at window construction.
This allows tweaking style properties without rebuilding.
The css file is installed in $(pkgdatadir)/epiphany.css.
Signed-off-by: Diego Escalante Urrelo <descalante@igalia.com>
Bug #644805
|
|
|
|
| |
An empty list is simply NULL.
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
When a download finishes but you don't 'activate' it (open or browsing) the
widget stays alive on the downloads-bar, worse, if open or browse actions fail,
the download can't be removed from the bar.
This commit clears finished downloads from the downloads-bar when it is closed
(with the X button). Hiding it will *not* trigger this cleanup.
Bug #653918
|
|
|
|
| |
Bug #653695
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=653031
|
|
|
|
| |
We'll reuse it in the future.
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
| |
For now it's pretty much like a private instance, but:
- A profile directory *must* be passed
- Global passwords and cookies are accessed. In the future we'll
likely restrict cookies to the ones for the web application domain,
which we'll copy from the main cookies file.
|
|
|
|
| |
In preparation to add a new mode for WebApps.
|
|
|
|
| |
We already call gtk_application_add_window
|
|
|
|
| |
Cleaner than doing it in the constructor.
|
|
|
|
|
| |
We already guarantee that the app will stay up by adding the windows
to the GtkApplication, so stop reffing the shell in these callbacks.
|
|
|
|
|
|
|
|
| |
Instead of our own home-grown system.
I think we should subclass window_added in GtkApplication and do there
the session & state stuff and get rid of ephy_session_add_window and
ephy_state_add_window.
|
|
|
|
| |
We can now get rid of the EphyFileHelpers method.
|
|
|
|
|
|
|
|
|
|
|
| |
We want to use EphyApplication from embed/ too, so instead of
following the EphyEmbedShell/EphyShell pattern just fold the code into
the Shell itself. This makes sense since both classes have basically
the same function, and we can easily leave the non-embed code in
EphyShell and move to EphyEmbedShell the bits we want to be global.
The better name would be EphyCoreApplication/EphyApplication for the
resulting object, but we can do this later.
|
|
|
|
|
|
| |
Instead of relying on ephy-file-helpers global method. Down the road
we want to do this everywhere, but first we need some refactoring to
be able to use EphyApplication outside of src/.
|
|
|
|
| |
Based on the private-instance paramater.
|
|
|
|
|
| |
It does not do much at the moment, but we pass the information from
ephy-main.c to the app.
|
|
|
|
| |
It won't be the case in web app mode.
|
|
|
|
| |
We'll want to create our own in main(), this prepares us for that.
|
| |
|
| |
|
|
|
|
| |
They do not make sense on the first/last tab.
|
|
|
|
|
|
|
| |
We are currently exporting ephy-shell which has a dependency on
ephy-application.
Fixes bug #653562
|
|
|
|
|
|
|
| |
We have a global-handler for Ctrl+Page{Up,Down} that is used in some
situations (basically, when the notebook is not focused). It does not
respect the wrap-around GtkSetting though, so the final experience can
be inconsistent.
|
| |
|
|
|
|
|
|
|
| |
ephy_session_queue_command() doesn't take over the strings it
receives, so mark these as const for clarity.
https://bugzilla.gnome.org/show_bug.cgi?id=622903
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=622903
|
|
|
|
|
|
|
| |
We still need to provide equivalent ways to activate epiphany, but we
will use GActions instead.
https://bugzilla.gnome.org/show_bug.cgi?id=622903
|
|
|
|
|
|
| |
Things are done differently in GNOME3.
Bug #647604
|
| |
|
|
|
|
|
| |
This way we don't need a compile-time dependency on NetworkManager,
since we use it through the DBus APIs.
|
|
|
|
| |
It's not optional in GNOME 3
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This replaces the existing dbus-glib activation and uniqueness code.
The changes are kept to the minimum necessary to make all the features
work, but there are still some optimizations possible (like doing most
of the initialization in ephy_application_startup() when we know we
are not remoting). These changes are left for later to avoid making
this patch huge.
Command-line parameter parsing is done in the main method and
parameters are passed to the application through a
EphyApplicationStartupContext structure, which is later passed as a
GVariant to the primare instance. This way we avoid moving the
GOption code out of the place where it's intended to run: in the
main() method.
Based in work by Alexandre Mazari.
https://bugzilla.gnome.org/show_bug.cgi?id=637334
|
|
|
|
|
|
|
|
|
|
| |
Get rid of the EphyNetMonitor code and instead generate a GDBusProxy
subclass that monitors the StateChanged signal and State property in
org.gnome.NetworkManager. This proxy exports these features as
standard GObject signal and property, respectively, so we can use it
directly through the relevant accessors.
https://bugzilla.gnome.org/show_bug.cgi?id=622903
|
|
|
|
| |
Just enough to get rid of ephy-marshal.h
|
|
|
|
|
|
| |
Remove the menubar visibility options from the content context menu
and adds them to the chrome context menu. Invert the meaning of the
option and update the option text.
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Gtk[HV]Box, Gtk[HV]Separator, Gtk[HV]Paned are deprecated in GTK+ 3.2,
so let's use the GtkOrientable interface instead.
GtkBox is likely to dissapear soon too, so a migration to GtkGrid
might be necessary at some point.
https://bugzilla.gnome.org/show_bug.cgi?id=652201
|
| |
|
|
|
|
|
|
| |
When the user right-clicks on a misspelled word a number of possible
corrections will be offered by Epiphany. Selecting one of them will
replace the misspelled word by the suggestion.
|
|
|
|
|
|
| |
Second patch in an attempt to clean up ephy-main.c
https://bugzilla.gnome.org/show_bug.cgi?id=652119
|
|
|
|
|
|
|
| |
This is the first patch in an attempt to simplify epiphany's main()
method, which is quite bulky by now.
https://bugzilla.gnome.org/show_bug.cgi?id=652119
|
|
|
|
|
|
|
| |
Set to zero 'default-border', 'default-outside-border', 'inner-border'
and 'padding' for the GtkButton, following the lead of GEdit.
Bug #648116
|
|
|
|
|
|
|
| |
Depends on WebKitGTK+ being built with spell check support, otherwise
it won't do anything.
Based on a patch by Diego Escalante.
|
|
|
|
|
| |
It was only used to figure out whether to paint the entry background
yellow, so we don't need it anymore.
|
|
|
|
|
| |
Adds unneeded clutter to the entry, we'll just rely on a visible
symbolic lock icon when needed.
|
| |
|