diff options
| author | Fabio Berger <me@fabioberger.com> | 2018-07-22 21:35:15 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2018-07-22 21:35:15 +0800 |
| commit | 06f61949f93eb83ea7d6456f6bbf18cb6f6dab7a (patch) | |
| tree | cfc951c5cd186f9d107868ca2406874f4d67dae0 | |
| parent | 0e72b67865ce7f891283ed9d21bd36cfaab4e645 (diff) | |
| parent | bffffffc95a104bc4794e591940930b89e47decf (diff) | |
| download | dexon-0x-contracts-06f61949f93eb83ea7d6456f6bbf18cb6f6dab7a.tar.gz dexon-0x-contracts-06f61949f93eb83ea7d6456f6bbf18cb6f6dab7a.tar.zst dexon-0x-contracts-06f61949f93eb83ea7d6456f6bbf18cb6f6dab7a.zip | |
Merge pull request #880 from feuGeneA/patch-5
make PR template checklist more useful
| -rw-r--r-- | PULL_REQUEST_TEMPLATE.md | 12 |
1 files changed, 5 insertions, 7 deletions
diff --git a/PULL_REQUEST_TEMPLATE.md b/PULL_REQUEST_TEMPLATE.md index 257c91025..63ef8db3d 100644 --- a/PULL_REQUEST_TEMPLATE.md +++ b/PULL_REQUEST_TEMPLATE.md @@ -18,12 +18,10 @@ ## Checklist: -<!--- Go over all the following points, and put an `x` in all the boxes that apply. --> +<!--- The following points should be used to indicate the progress of your PR. Put an `x` in all the boxes that apply right now, and come back over time and check them off as you make progress. If you're unsure about any of these, don't hesitate to ask. We're here to help! --> -<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - -* [ ] Change requires a change to the documentation. -* [ ] Added tests to cover my changes. +* [ ] Prefixed the title of this PR with `[WIP]` if it is a work in progress. +* [ ] Prefixed the title of this PR with bracketed package name(s) corresponding to the changed package(s). For example: `[sol-cov] Fixed bug`. +* [ ] Added tests to cover my changes, or decided that tests would be too impractical. +* [ ] Updated documentation, or decided that no doc change is needed. * [ ] Added new entries to the relevant CHANGELOG.jsons. -* [ ] Labeled this PR with the 'WIP' label if it is a work in progress. -* [ ] Labeled this PR with the labels corresponding to the changed package. |