aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSteve Klebanoff <steve.klebanoff@gmail.com>2019-01-17 09:12:08 +0800
committerSteve Klebanoff <steve.klebanoff@gmail.com>2019-01-17 09:12:08 +0800
commit92f5ad4f1518b2aaa3f1754b44a3059ac1610e0c (patch)
tree3e5f303cc1a528520c7c3b027e741e4dae2ed899
parentff8250cd3567a276490342a820bf9428257a0c7c (diff)
downloaddexon-0x-contracts-92f5ad4f1518b2aaa3f1754b44a3059ac1610e0c.tar.gz
dexon-0x-contracts-92f5ad4f1518b2aaa3f1754b44a3059ac1610e0c.tar.zst
dexon-0x-contracts-92f5ad4f1518b2aaa3f1754b44a3059ac1610e0c.zip
Use more specific helper method decodeAssetDataOrThrow
-rw-r--r--packages/asset-buyer/src/asset_buyer.ts2
-rw-r--r--packages/instant/src/index.umd.ts7
2 files changed, 4 insertions, 5 deletions
diff --git a/packages/asset-buyer/src/asset_buyer.ts b/packages/asset-buyer/src/asset_buyer.ts
index 4344f070c..ad4b3bb60 100644
--- a/packages/asset-buyer/src/asset_buyer.ts
+++ b/packages/asset-buyer/src/asset_buyer.ts
@@ -193,7 +193,7 @@ export class AssetBuyer {
): Promise<LiquidityForAssetData> {
const shouldForceOrderRefresh =
options.shouldForceOrderRefresh !== undefined ? options.shouldForceOrderRefresh : false;
- assert.isString('assetData', assetData);
+ assetDataUtils.decodeAssetDataOrThrow(assetData);
assert.isBoolean('options.shouldForceOrderRefresh', shouldForceOrderRefresh);
const assetPairs = await this.orderProvider.getAvailableMakerAssetDatasAsync(assetData);
diff --git a/packages/instant/src/index.umd.ts b/packages/instant/src/index.umd.ts
index 5ef2e1695..0acf3f2ad 100644
--- a/packages/instant/src/index.umd.ts
+++ b/packages/instant/src/index.umd.ts
@@ -156,10 +156,9 @@ export const hasLiquidityForAssetDataAsync = async (
const assetBuyerOptions = { networkId };
- const assetBuyer =
- typeof orderSource === 'string'
- ? AssetBuyer.getAssetBuyerForStandardRelayerAPIUrl(bestProvider, orderSource, assetBuyerOptions)
- : AssetBuyer.getAssetBuyerForProvidedOrders(bestProvider, orderSource, assetBuyerOptions);
+ const assetBuyer = _.isString(orderSource)
+ ? AssetBuyer.getAssetBuyerForStandardRelayerAPIUrl(bestProvider, orderSource, assetBuyerOptions)
+ : AssetBuyer.getAssetBuyerForProvidedOrders(bestProvider, orderSource, assetBuyerOptions);
const liquidity = await assetBuyer.getLiquidityForAssetDataAsync(assetData);
return liquidity.ethValueAvailableInWei.gt(new BigNumber(0));