diff options
| author | Amir Bandeali <abandeali1@gmail.com> | 2018-08-29 04:00:49 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2018-08-29 04:00:49 +0800 |
| commit | 14fdb71a716cb95bc1f6933db9057d23f3c41909 (patch) | |
| tree | 9690b583d128f419f292ef78f0a70be260e8babe /CONTRIBUTING.md | |
| parent | 2eab0e30b753fb33729db53d141c8e22017cadec (diff) | |
| download | dexon-0x-contracts-14fdb71a716cb95bc1f6933db9057d23f3c41909.tar.gz dexon-0x-contracts-14fdb71a716cb95bc1f6933db9057d23f3c41909.tar.zst dexon-0x-contracts-14fdb71a716cb95bc1f6933db9057d23f3c41909.zip | |
safeGetPartialAmount (#1035)
* Added Test "Should transfer correct amounts when left order is fully filled and values pass isRoundingErrorCeil but fail isRoundingErrorFloor"
* Added RoundingError exception to reference function for getPartialAmount
* Added RoundingError exception to reference function for getPartialAmount
* Added isRoundingErrorCeil to getPartialAmountCeil reference funtion
* Computed new values for "Should give right maker a better buy price when correct price is not integral" that does not have a rounding error
* Almost all tests for match orders are passing after adding isRoundingErrorCeil check
* WIP commit: Added rounding error checks to getPartialAmount
* WIP commit: Added rounding error checks to getPartialAmount
* Use safe versions of getPartialAmount
* Update Exchange internals tests
* Run linter
* Found new values for "Should transfer correct amounts when right order fill amount deviates from amount derived by `Exchange.fillOrder`"
* Fixed merge conflicts
* Run all tests
* Cleaned up some comments on match Orders tests
* Fix tests for geth
Diffstat (limited to 'CONTRIBUTING.md')
0 files changed, 0 insertions, 0 deletions