aboutsummaryrefslogtreecommitdiffstats
path: root/packages/0x.js/test/utils
diff options
context:
space:
mode:
authorBrandon Millman <brandon.millman@gmail.com>2017-12-18 12:30:14 +0800
committerBrandon Millman <brandon.millman@gmail.com>2017-12-18 12:30:14 +0800
commit4dc6694651a5fba5b4e280f9eb3d5da528057cc2 (patch)
tree08b1f8f2dd310f40bacefe0805d6d2a115616ccd /packages/0x.js/test/utils
parentfe8f2d87c79cb25a7879c2e737dbdd64b7c40f60 (diff)
downloaddexon-0x-contracts-4dc6694651a5fba5b4e280f9eb3d5da528057cc2.tar.gz
dexon-0x-contracts-4dc6694651a5fba5b4e280f9eb3d5da528057cc2.tar.zst
dexon-0x-contracts-4dc6694651a5fba5b4e280f9eb3d5da528057cc2.zip
Move web3 import after subprovider imports in test web3_factory
Diffstat (limited to 'packages/0x.js/test/utils')
-rw-r--r--packages/0x.js/test/utils/web3_factory.ts8
1 files changed, 7 insertions, 1 deletions
diff --git a/packages/0x.js/test/utils/web3_factory.ts b/packages/0x.js/test/utils/web3_factory.ts
index 6f72cec58..7e65a4381 100644
--- a/packages/0x.js/test/utils/web3_factory.ts
+++ b/packages/0x.js/test/utils/web3_factory.ts
@@ -3,7 +3,6 @@
// we are not running in a browser env.
// Filed issue: https://github.com/ethereum/web3.js/issues/844
(global as any).XMLHttpRequest = undefined;
-import * as Web3 from 'web3';
import ProviderEngine = require('web3-provider-engine');
import RpcSubprovider = require('web3-provider-engine/subproviders/rpc');
@@ -12,6 +11,13 @@ import {FakeGasEstimateSubprovider} from './subproviders/fake_gas_estimate_subpr
import {constants} from './constants';
+// HACK: web3 leaks XMLHttpRequest into the global scope and causes requests to hang
+// because they are using the wrong XHR package.
+// importing web3 after subproviders fixes this issue
+// Filed issue: https://github.com/ethereum/web3.js/issues/844
+// tslint:disable-next-line:ordered-imports
+import * as Web3 from 'web3';
+
export const web3Factory = {
create(hasAddresses: boolean = true): Web3 {
const provider = this.getRpcProvider(hasAddresses);