diff options
| author | Jacob Evans <jacob@dekz.net> | 2018-02-24 02:36:16 +0800 |
|---|---|---|
| committer | Jacob Evans <jacob@dekz.net> | 2018-02-27 01:39:46 +0800 |
| commit | eabe96fd194f21b1c670381506b115589a37eff5 (patch) | |
| tree | 3998559ffc4f2dea03871068f73a25d90ffc66f8 /packages/assert | |
| parent | f689d335c0c4042e7ecf3e4636db3434d0dcd7a8 (diff) | |
| download | dexon-0x-contracts-eabe96fd194f21b1c670381506b115589a37eff5.tar.gz dexon-0x-contracts-eabe96fd194f21b1c670381506b115589a37eff5.tar.zst dexon-0x-contracts-eabe96fd194f21b1c670381506b115589a37eff5.zip | |
Check isETHAddressHex before lowercase
Flip the check so assertion happens before lowercase
Diffstat (limited to 'packages/assert')
| -rw-r--r-- | packages/assert/CHANGELOG.md | 4 | ||||
| -rw-r--r-- | packages/assert/src/index.ts | 5 |
2 files changed, 5 insertions, 4 deletions
diff --git a/packages/assert/CHANGELOG.md b/packages/assert/CHANGELOG.md index 23c2c5e56..fff014811 100644 --- a/packages/assert/CHANGELOG.md +++ b/packages/assert/CHANGELOG.md @@ -1,5 +1,9 @@ # CHANGELOG +## v0.1.XX - TBD + + * Remove isETHAddressHex checksum address check and assume address will be lowercased (#373) + ## v0.0.18 - _February 9, 2017_ * Fix publishing issue where .npmignore was not properly excluding undesired content (#389) diff --git a/packages/assert/src/index.ts b/packages/assert/src/index.ts index 7ad574ec7..a9d553487 100644 --- a/packages/assert/src/index.ts +++ b/packages/assert/src/index.ts @@ -33,11 +33,8 @@ export const assert = { ); }, isETHAddressHex(variableName: string, value: string): void { + this.assert(_.isString(value), this.typeAssertionMessage(variableName, 'string', value)); this.assert(addressUtils.isAddress(value), this.typeAssertionMessage(variableName, 'ETHAddressHex', value)); - this.assert( - addressUtils.isAddress(value) && value.toLowerCase() === value, - `Checksummed addresses are not supported. Convert ${variableName} to lower case before passing`, - ); }, doesBelongToStringEnum( variableName: string, |