aboutsummaryrefslogtreecommitdiffstats
path: root/packages/order-utils
diff options
context:
space:
mode:
authorBrandon Millman <brandon.millman@gmail.com>2018-08-17 15:15:52 +0800
committerBrandon Millman <brandon.millman@gmail.com>2018-08-23 06:39:03 +0800
commit3c973ba9f64197fcc1a66f319e3d1aa33d96b6d7 (patch)
treeb53c5e88376bc6cfc52c8d20b645f9c7ceba1812 /packages/order-utils
parent2ef867f398db381ebd8ec715bd108b46d8fa60f3 (diff)
downloaddexon-0x-contracts-3c973ba9f64197fcc1a66f319e3d1aa33d96b6d7.tar.gz
dexon-0x-contracts-3c973ba9f64197fcc1a66f319e3d1aa33d96b6d7.tar.zst
dexon-0x-contracts-3c973ba9f64197fcc1a66f319e3d1aa33d96b6d7.zip
Remove marketSell and add to marketBuy implementation
Diffstat (limited to 'packages/order-utils')
-rw-r--r--packages/order-utils/CHANGELOG.json4
-rw-r--r--packages/order-utils/src/market_utils.ts4
2 files changed, 6 insertions, 2 deletions
diff --git a/packages/order-utils/CHANGELOG.json b/packages/order-utils/CHANGELOG.json
index 86f0da65a..4acb3d233 100644
--- a/packages/order-utils/CHANGELOG.json
+++ b/packages/order-utils/CHANGELOG.json
@@ -14,6 +14,10 @@
"note":
"Update marketUtils api such that all optional parameters are bundled into one optional param and more defaults are provided",
"pr": 954
+ },
+ {
+ "note":
+ "Rename `resultOrders` to `resultFeeOrders` for object returned by `findFeeOrdersThatCoverFeesForTargetOrders` in `marketUtils` api"
}
]
},
diff --git a/packages/order-utils/src/market_utils.ts b/packages/order-utils/src/market_utils.ts
index a0a827546..7eae4c8fc 100644
--- a/packages/order-utils/src/market_utils.ts
+++ b/packages/order-utils/src/market_utils.ts
@@ -84,7 +84,7 @@ export const marketUtils = {
orders: T[],
feeOrders: T[],
opts?: FindFeeOrdersThatCoverFeesForTargetOrdersOpts,
- ): { resultOrders: T[]; remainingFeeAmount: BigNumber } {
+ ): { resultFeeOrders: T[]; remainingFeeAmount: BigNumber } {
assert.doesConformToSchema('orders', orders, schemas.ordersSchema);
assert.doesConformToSchema('feeOrders', feeOrders, schemas.ordersSchema);
// try to get remainingFillableMakerAssetAmounts from opts, if it's not there, use makerAssetAmount values from orders
@@ -137,7 +137,7 @@ export const marketUtils = {
},
);
return {
- resultOrders,
+ resultFeeOrders: resultOrders,
remainingFeeAmount: remainingFillAmount,
};
// TODO: add more orders here to cover rounding