diff options
author | Leonid Logvinov <logvinov.leon@gmail.com> | 2018-02-08 03:38:30 +0800 |
---|---|---|
committer | Leonid Logvinov <logvinov.leon@gmail.com> | 2018-02-08 03:38:30 +0800 |
commit | e6f2c7a382e2e7e940f430f350240cb2f703bdcd (patch) | |
tree | 20fafeb4737dcf79fd66296f4bbcbcef1bbaabdb /packages/website/ts/components | |
parent | 69f5f5e94627458f4eb41f4150cfa3d140658d09 (diff) | |
download | dexon-0x-contracts-e6f2c7a382e2e7e940f430f350240cb2f703bdcd.tar.gz dexon-0x-contracts-e6f2c7a382e2e7e940f430f350240cb2f703bdcd.tar.zst dexon-0x-contracts-e6f2c7a382e2e7e940f430f350240cb2f703bdcd.zip |
Remove networkId from orderJSON
Diffstat (limited to 'packages/website/ts/components')
4 files changed, 2 insertions, 15 deletions
diff --git a/packages/website/ts/components/fill_order.tsx b/packages/website/ts/components/fill_order.tsx index ad3d6bf74..d2c36ff0c 100644 --- a/packages/website/ts/components/fill_order.tsx +++ b/packages/website/ts/components/fill_order.tsx @@ -109,7 +109,6 @@ export class FillOrder extends React.Component<FillOrderProps, FillOrderState> { <FillOrderJSON blockchain={this.props.blockchain} tokenByAddress={this.props.tokenByAddress} - networkId={this.props.networkId} orderJSON={this.state.orderJSON} onFillOrderJSONChanged={this._onFillOrderJSONChanged.bind(this)} /> @@ -136,7 +135,6 @@ export class FillOrder extends React.Component<FillOrderProps, FillOrderState> { <FillOrderJSON blockchain={this.props.blockchain} tokenByAddress={this.props.tokenByAddress} - networkId={this.props.networkId} orderJSON={this.state.orderJSON} onFillOrderJSONChanged={this._onFillOrderJSONChanged.bind(this)} /> @@ -444,12 +442,8 @@ export class FillOrder extends React.Component<FillOrderProps, FillOrderState> { const signature = parsedOrder.signedOrder.ecSignature; const isValidSignature = ZeroEx.isValidSignature(signature.hash, signature, parsedOrder.signedOrder.maker); - if (this.props.networkId !== parsedOrder.metadata.networkId) { - orderJSONErrMsg = `This order was made on another Ethereum network - (id: ${parsedOrder.metadata.networkId}). Connect to this network to fill.`; - parsedOrder = undefined; - } else if (exchangeContractAddr !== parsedOrder.signedOrder.exchangeContractAddress) { - orderJSONErrMsg = 'This order was made using a deprecated 0x Exchange contract.'; + if (exchangeContractAddr !== parsedOrder.signedOrder.exchangeContractAddress) { + orderJSONErrMsg = 'This order was made on another network or using a deprecated Exchange contract'; parsedOrder = undefined; } else if (orderHash !== signature.hash) { orderJSONErrMsg = 'Order hash does not match supplied plaintext values'; diff --git a/packages/website/ts/components/fill_order_json.tsx b/packages/website/ts/components/fill_order_json.tsx index f8e43481a..877b65116 100644 --- a/packages/website/ts/components/fill_order_json.tsx +++ b/packages/website/ts/components/fill_order_json.tsx @@ -12,7 +12,6 @@ import { utils } from 'ts/utils/utils'; interface FillOrderJSONProps { blockchain: Blockchain; tokenByAddress: TokenByAddress; - networkId: number; orderJSON: string; onFillOrderJSONChanged: (event: any) => void; } @@ -43,7 +42,6 @@ export class FillOrderJSON extends React.Component<FillOrderJSONProps, FillOrder const hintSalt = ZeroEx.generatePseudoRandomSalt(); const feeRecipient = constants.NULL_ADDRESS; const hintOrder = utils.generateOrder( - this.props.networkId, exchangeContract, hintSideToAssetToken, hintOrderExpiryTimestamp, diff --git a/packages/website/ts/components/generate_order/generate_order_form.tsx b/packages/website/ts/components/generate_order/generate_order_form.tsx index c9417f5a4..6fe0fa4f3 100644 --- a/packages/website/ts/components/generate_order/generate_order_form.tsx +++ b/packages/website/ts/components/generate_order/generate_order_form.tsx @@ -216,7 +216,6 @@ export class GenerateOrderForm extends React.Component<GenerateOrderFormProps, G orderMakerFee={this.props.hashData.makerFee} orderTakerFee={this.props.hashData.takerFee} orderFeeRecipient={this.props.hashData.feeRecipientAddress} - networkId={this.props.networkId} sideToAssetToken={this.props.sideToAssetToken} tokenByAddress={this.props.tokenByAddress} /> @@ -329,7 +328,6 @@ export class GenerateOrderForm extends React.Component<GenerateOrderFormProps, G try { const signatureData = await this.props.blockchain.signOrderHashAsync(orderHash); const order = utils.generateOrder( - this.props.networkId, exchangeContractAddr, this.props.sideToAssetToken, hashData.orderExpiryTimestamp, diff --git a/packages/website/ts/components/order_json.tsx b/packages/website/ts/components/order_json.tsx index 1b6b32a04..a908f2895 100644 --- a/packages/website/ts/components/order_json.tsx +++ b/packages/website/ts/components/order_json.tsx @@ -20,7 +20,6 @@ interface OrderJSONProps { orderMakerFee: BigNumber; orderTakerFee: BigNumber; orderFeeRecipient: string; - networkId: number; sideToAssetToken: SideToAssetToken; tokenByAddress: TokenByAddress; } @@ -40,7 +39,6 @@ export class OrderJSON extends React.Component<OrderJSONProps, OrderJSONState> { } public render() { const order = utils.generateOrder( - this.props.networkId, this.props.exchangeContractIfExists, this.props.sideToAssetToken, this.props.orderExpiryTimestamp, @@ -162,7 +160,6 @@ You can see and fill it here: ${this.state.shareLink}`); } private _getOrderUrl() { const order = utils.generateOrder( - this.props.networkId, this.props.exchangeContractIfExists, this.props.sideToAssetToken, this.props.orderExpiryTimestamp, |