diff options
author | Fabio B <kandinsky454@protonmail.ch> | 2018-11-13 22:03:30 +0800 |
---|---|---|
committer | GitHub <noreply@github.com> | 2018-11-13 22:03:30 +0800 |
commit | 3fb29041b0e6b874709eceac28505706e7929774 (patch) | |
tree | c999df340871f1ef6d27570d73a2c529da24ea4a /packages | |
parent | 161a935003faba521e3c4be189d8ef07c224f3f1 (diff) | |
parent | 320460feb92cbd65a504aca6fb095b1233776e29 (diff) | |
download | dexon-0x-contracts-3fb29041b0e6b874709eceac28505706e7929774.tar.gz dexon-0x-contracts-3fb29041b0e6b874709eceac28505706e7929774.tar.zst dexon-0x-contracts-3fb29041b0e6b874709eceac28505706e7929774.zip |
Merge pull request #1248 from 0xProject/fixLowercaseAddressBug
Fix lowercase address bug in LedgerSubprovider and MnemonicSubprovider
Diffstat (limited to 'packages')
-rw-r--r-- | packages/subproviders/src/subproviders/ledger.ts | 1 | ||||
-rw-r--r-- | packages/subproviders/src/utils/wallet_utils.ts | 3 |
2 files changed, 2 insertions, 2 deletions
diff --git a/packages/subproviders/src/subproviders/ledger.ts b/packages/subproviders/src/subproviders/ledger.ts index 28e348f90..b5ca10ce1 100644 --- a/packages/subproviders/src/subproviders/ledger.ts +++ b/packages/subproviders/src/subproviders/ledger.ts @@ -32,7 +32,6 @@ const DEFAULT_ADDRESS_SEARCH_LIMIT = 1000; */ export class LedgerSubprovider extends BaseWalletSubprovider { // tslint:disable-next-line:no-unused-variable - private readonly _nonceLock = new Lock(); private readonly _connectionLock = new Lock(); private readonly _networkId: number; private _baseDerivationPath: string; diff --git a/packages/subproviders/src/utils/wallet_utils.ts b/packages/subproviders/src/utils/wallet_utils.ts index 4c233645b..7027ca8a0 100644 --- a/packages/subproviders/src/utils/wallet_utils.ts +++ b/packages/subproviders/src/utils/wallet_utils.ts @@ -56,10 +56,11 @@ export const walletUtils = { parentDerivedKeyInfo: DerivedHDKeyInfo, searchLimit: number, ): DerivedHDKeyInfo | undefined { + const lowercaseAddress = address.toLowerCase(); let matchedKey: DerivedHDKeyInfo | undefined; const derivedKeyIterator = new DerivedHDKeyInfoIterator(parentDerivedKeyInfo, searchLimit); for (const key of derivedKeyIterator) { - if (key.address === address) { + if (key.address === lowercaseAddress) { matchedKey = key; break; } |