diff options
| author | Leonid Logvinov <logvinov.leon@gmail.com> | 2017-05-26 18:17:31 +0800 |
|---|---|---|
| committer | Leonid Logvinov <logvinov.leon@gmail.com> | 2017-05-26 18:17:31 +0800 |
| commit | 3195741ebcfc95f4622aebcdc23fc5b8630efe39 (patch) | |
| tree | 2d90199df90974be6a596eace3503281889c29f4 /src/ts/0x.js.ts | |
| parent | 183e8a71389737dc1c535b3625c949307607b9b9 (diff) | |
| download | dexon-0x-contracts-3195741ebcfc95f4622aebcdc23fc5b8630efe39.tar.gz dexon-0x-contracts-3195741ebcfc95f4622aebcdc23fc5b8630efe39.tar.zst dexon-0x-contracts-3195741ebcfc95f4622aebcdc23fc5b8630efe39.zip | |
Address feedback
Diffstat (limited to 'src/ts/0x.js.ts')
| -rw-r--r-- | src/ts/0x.js.ts | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/src/ts/0x.js.ts b/src/ts/0x.js.ts index 893d95de6..ba922d3db 100644 --- a/src/ts/0x.js.ts +++ b/src/ts/0x.js.ts @@ -132,8 +132,9 @@ export class ZeroEx { /** * Converts BigNumber instance to BN - * We do it because ethABI accepts only BN's - * We should be consistent about using BigNumbers in our codebase and not use BN anywhere else + * The only we convert to BN is to remain compatible with `ethABI. soliditySHA3 ` that + * expects values of Solidity type `uint` to be of type `BN`. + * We do not use BN anywhere else in the codebase. */ private static bigNumberToBN(value: BigNumber.BigNumber) { return new BN(value.toString(), 10); |