From 7bd3d87f7a7d7c54b08e3e62b8075ec569498c63 Mon Sep 17 00:00:00 2001 From: Leonid Logvinov Date: Mon, 29 May 2017 15:54:52 +0200 Subject: Address feedback --- package.json | 2 +- src/globals.d.ts | 2 +- webpack.config.js | 7 ++++--- 3 files changed, 6 insertions(+), 5 deletions(-) diff --git a/package.json b/package.json index 7f92dbb9a..3b29795a8 100644 --- a/package.json +++ b/package.json @@ -20,7 +20,7 @@ "docs:generate": "typedoc --out docs .", "docs:open": "opn docs/index.html", - "clean": "shx rm -rf _bundles lib", + "clean": "shx rm -rf _bundles lib test_temp", "build:dev": "npm run clean && run-p build:*:dev", "build:umd:dev": "webpack", "build:umd:prod": "webpack -p", diff --git a/src/globals.d.ts b/src/globals.d.ts index 4c9adcd48..0062a05cb 100644 --- a/src/globals.d.ts +++ b/src/globals.d.ts @@ -15,7 +15,7 @@ declare interface Schema { declare namespace Chai { interface Assertion { bignumber: Assertion; - // HACK: In order t comply with chai-as-promised we make eventually a PromisedAssertion not an assertion + // HACK: In order to comply with chai-as-promised we make eventually a `PromisedAssertion` not an `Assertion` eventually: PromisedAssertion; } } diff --git a/webpack.config.js b/webpack.config.js index 9718477aa..03a7c6cac 100644 --- a/webpack.config.js +++ b/webpack.config.js @@ -1,15 +1,16 @@ /** * This is to generate the umd bundle only */ +const lodash = require('lodash'); const webpack = require('webpack'); const path = require('path'); -const PROD = process.env.NODE_ENV === 'production'; +const production = process.env.NODE_ENV === 'production'; let entry = { '0x': './src/0x.js.ts', }; -if (PROD) { - entry = Object.assign({}, entry, {'0x.min': './src/0x.js.ts'}); +if (production) { + entry = _.assign({}, entry, {'0x.min': './src/0x.js.ts'}); } module.exports = { -- cgit