From 84d836f22b4bc5410c5d96137eff261b698b622e Mon Sep 17 00:00:00 2001 From: Amir Bandeali Date: Mon, 9 Apr 2018 10:44:39 -0700 Subject: Add back require statements and tests (will move to another PR) --- packages/contracts/test/exchange/core.ts | 42 ++++++++++++++++++++++++++++++++ 1 file changed, 42 insertions(+) (limited to 'packages/contracts/test') diff --git a/packages/contracts/test/exchange/core.ts b/packages/contracts/test/exchange/core.ts index df4915403..ef3b3b9ee 100644 --- a/packages/contracts/test/exchange/core.ts +++ b/packages/contracts/test/exchange/core.ts @@ -501,6 +501,32 @@ describe('Exchange', () => { return expect(exWrapper.fillOrderAsync(signedOrder, takerAddress)).to.be.rejectedWith(constants.REVERT); }); + it('should throw if makerTokenAmount is 0', async () => { + signedOrder = orderFactory.newSignedOrder({ + makerTokenAmount: new BigNumber(0), + }); + + return expect(exWrapper.fillOrderAsync(signedOrder, takerAddress)).to.be.rejectedWith(constants.REVERT); + }); + + it('should throw if takerTokenAmount is 0', async () => { + signedOrder = orderFactory.newSignedOrder({ + takerTokenAmount: new BigNumber(0), + }); + + return expect(exWrapper.fillOrderAsync(signedOrder, takerAddress)).to.be.rejectedWith(constants.REVERT); + }); + + it('should throw if takerTokenFillAmount is 0', async () => { + signedOrder = orderFactory.newSignedOrder(); + + return expect( + exWrapper.fillOrderAsync(signedOrder, takerAddress, { + takerTokenFillAmount: new BigNumber(0), + }), + ).to.be.rejectedWith(constants.REVERT); + }); + it('should throw if maker balances are too low to fill order', async () => { signedOrder = orderFactory.newSignedOrder({ makerTokenAmount: ZeroEx.toBaseUnitAmount(new BigNumber(100000), 18), @@ -581,6 +607,22 @@ describe('Exchange', () => { return expect(exWrapper.cancelOrderAsync(signedOrder, takerAddress)).to.be.rejectedWith(constants.REVERT); }); + it('should throw if makerTokenAmount is 0', async () => { + signedOrder = orderFactory.newSignedOrder({ + makerTokenAmount: new BigNumber(0), + }); + + return expect(exWrapper.cancelOrderAsync(signedOrder, makerAddress)).to.be.rejectedWith(constants.REVERT); + }); + + it('should throw if takerTokenAmount is 0', async () => { + signedOrder = orderFactory.newSignedOrder({ + takerTokenAmount: new BigNumber(0), + }); + + return expect(exWrapper.cancelOrderAsync(signedOrder, makerAddress)).to.be.rejectedWith(constants.REVERT); + }); + it('should be able to cancel a full order', async () => { await exWrapper.cancelOrderAsync(signedOrder, makerAddress); await exWrapper.fillOrderAsync(signedOrder, takerAddress, { -- cgit