From 3adc6b6daa16bb1dc80a8c4109b0bed56f937ea0 Mon Sep 17 00:00:00 2001
From: Steve Klebanoff <steve.klebanoff@gmail.com>
Date: Thu, 25 Oct 2018 13:36:45 -0700
Subject: Making failure txHash required

---
 packages/instant/src/components/buy_button.tsx               | 2 +-
 packages/instant/src/containers/selected_asset_buy_button.ts | 5 +++--
 packages/instant/src/types.ts                                | 2 +-
 3 files changed, 5 insertions(+), 4 deletions(-)

(limited to 'packages/instant/src')

diff --git a/packages/instant/src/components/buy_button.tsx b/packages/instant/src/components/buy_button.tsx
index 841a9593b..6fe333dc7 100644
--- a/packages/instant/src/components/buy_button.tsx
+++ b/packages/instant/src/components/buy_button.tsx
@@ -15,7 +15,7 @@ export interface BuyButtonProps {
     onSignatureDenied: (buyQuote: BuyQuote, preventedError: Error) => void;
     onBuyProcessing: (buyQuote: BuyQuote, txHash: string) => void;
     onBuySuccess: (buyQuote: BuyQuote, txHash: string) => void;
-    onBuyFailure: (buyQuote: BuyQuote, txHash?: string) => void; // TODO: make this non-optional
+    onBuyFailure: (buyQuote: BuyQuote, txHash: string) => void;
 }
 
 export class BuyButton extends React.Component<BuyButtonProps> {
diff --git a/packages/instant/src/containers/selected_asset_buy_button.ts b/packages/instant/src/containers/selected_asset_buy_button.ts
index 8d60715be..adcbd61bc 100644
--- a/packages/instant/src/containers/selected_asset_buy_button.ts
+++ b/packages/instant/src/containers/selected_asset_buy_button.ts
@@ -22,7 +22,7 @@ interface ConnectedDispatch {
     onSignatureDenied: (buyQuote: BuyQuote, error: Error) => void;
     onBuyProcessing: (buyQuote: BuyQuote, txHash: string) => void;
     onBuySuccess: (buyQuote: BuyQuote, txHash: string) => void;
-    onBuyFailure: (buyQuote: BuyQuote) => void;
+    onBuyFailure: (buyQuote: BuyQuote, txHash: string) => void;
 }
 
 const mapStateToProps = (state: State, _ownProps: SelectedAssetBuyButtonProps): ConnectedState => ({
@@ -41,7 +41,8 @@ const mapDispatchToProps = (dispatch: Dispatch<Action>, ownProps: SelectedAssetB
     },
     onBuySuccess: (buyQuote: BuyQuote, txHash: string) =>
         dispatch(actions.updateBuyOrderState({ processState: OrderProcessState.SUCCESS, txHash })),
-    onBuyFailure: buyQuote => dispatch(actions.updateBuyOrderState({ processState: OrderProcessState.FAILURE })),
+    onBuyFailure: (buyQuote: BuyQuote, txHash: string) =>
+        dispatch(actions.updateBuyOrderState({ processState: OrderProcessState.FAILURE, txHash })),
     onSignatureDenied: (buyQuote, error) => {
         dispatch(actions.resetAmount());
         dispatch(actions.setError(error));
diff --git a/packages/instant/src/types.ts b/packages/instant/src/types.ts
index 255aee1eb..ad8794c94 100644
--- a/packages/instant/src/types.ts
+++ b/packages/instant/src/types.ts
@@ -29,7 +29,7 @@ interface SuccessfulOrderState {
 }
 interface FailureOrderState {
     processState: OrderProcessState.FAILURE;
-    txHash?: string;
+    txHash: string;
 }
 export type OrderState = RegularOrderState | ProcessingOrderState | SuccessfulOrderState | FailureOrderState;
 
-- 
cgit