From 9384c507ac29043d0d2f68bef3dde94a43282d09 Mon Sep 17 00:00:00 2001
From: fragosti <francesco.agosti93@gmail.com>
Date: Fri, 16 Nov 2018 16:33:02 -0800
Subject: feat: add isInstantRendered check to safeguard against double renders
 and double removes

---
 packages/instant/src/index.umd.ts | 18 +++++++++++++-----
 1 file changed, 13 insertions(+), 5 deletions(-)

(limited to 'packages/instant/src')

diff --git a/packages/instant/src/index.umd.ts b/packages/instant/src/index.umd.ts
index 34d893ad7..64f888e00 100644
--- a/packages/instant/src/index.umd.ts
+++ b/packages/instant/src/index.umd.ts
@@ -68,7 +68,9 @@ export const render = (config: ZeroExInstantConfig, selector: string = DEFAULT_Z
         return closeInstant;
     };
     if (config.shouldDisablePushToHistory) {
-        renderInstant();
+        if (!isInstantRendered()) {
+            renderInstant();
+        }
     } else {
         // Before we render, push to history saying that instant is showing for this part of the history.
         window.history.pushState({ zeroExInstantShowing: true }, '0x Instant');
@@ -83,12 +85,18 @@ export const render = (config: ZeroExInstantConfig, selector: string = DEFAULT_Z
             prevOnPopState(e);
             // e.state represents the new state
             if (e.state && e.state.zeroExInstantShowing) {
-                // The user pressed fowards, so re-render instant.
-                removeInstant = renderInstant();
+                // We have returned to a history state that expects instant to be rendered.
+                if (!isInstantRendered()) {
+                    removeInstant = renderInstant();
+                }
             } else {
-                // User pressed back, so close instant.
-                removeInstant();
+                // History has changed to a different state.
+                if (isInstantRendered()) {
+                    removeInstant();
+                }
             }
         };
     }
 };
+
+const isInstantRendered = (): boolean => !!document.getElementById(INJECTED_DIV_ID);
-- 
cgit