From 30622631ff588b4b87a05e4ce3ca2906ed1edf9f Mon Sep 17 00:00:00 2001
From: "F. Eugene Aumson" <gene@aumson.org>
Date: Mon, 17 Sep 2018 19:03:44 -0400
Subject: use Array.join rather than string concatenation

---
 packages/sol-doc/src/solidity_doc_generator.ts | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

(limited to 'packages/sol-doc')

diff --git a/packages/sol-doc/src/solidity_doc_generator.ts b/packages/sol-doc/src/solidity_doc_generator.ts
index 6c67f921d..78c56e7fa 100644
--- a/packages/sol-doc/src/solidity_doc_generator.ts
+++ b/packages/sol-doc/src/solidity_doc_generator.ts
@@ -231,8 +231,6 @@ function _genMethodParamsDoc(
     devdocIfExists: DevdocOutput | undefined,
 ): { parameters: Parameter[]; methodSignature: string } {
     const parameters: Parameter[] = [];
-    let methodSignature = `${name}(`;
-
     for (const abiParam of abiParams) {
         const parameter: Parameter = {
             name: abiParam.name,
@@ -241,13 +239,13 @@ function _genMethodParamsDoc(
             type: { name: abiParam.type, typeDocType: TypeDocTypes.Intrinsic },
         };
         parameters.push(parameter);
-        methodSignature = `${methodSignature}${abiParam.type},`;
     }
 
-    if (methodSignature.slice(-1) === ',') {
-        methodSignature = methodSignature.slice(0, -1);
-    }
-    methodSignature += ')';
+    const methodSignature = `${name}(${abiParams
+        .map(abiParam => {
+            return abiParam.type;
+        })
+        .join(',')})`;
 
     if (!_.isUndefined(devdocIfExists)) {
         const devdocMethodIfExists = devdocIfExists.methods[methodSignature];
-- 
cgit