diff options
| author | Fabio Berger <me@fabioberger.com> | 2017-12-19 17:23:35 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2017-12-19 17:23:35 +0800 |
| commit | c63f76dde7267c54328d2f12f401d94484e5a91a (patch) | |
| tree | c0c11d24adf10394119e393d00dd229336c5a1f6 | |
| parent | 79bd416c61d9ecabd8fc7903203b5a2cd5ee0936 (diff) | |
| parent | edbe6915e07a516f5fad2a38eb8ffe96a7b28318 (diff) | |
| download | dexon-sol-tools-c63f76dde7267c54328d2f12f401d94484e5a91a.tar.gz dexon-sol-tools-c63f76dde7267c54328d2f12f401d94484e5a91a.tar.zst dexon-sol-tools-c63f76dde7267c54328d2f12f401d94484e5a91a.zip | |
Merge pull request #268 from 0xProject/fix/codeSelectingInDocs
Fix code selection bug in docs
| -rw-r--r-- | package.json | 1 | ||||
| -rw-r--r-- | packages/website/ts/pages/shared/markdown_code_block.tsx | 29 |
2 files changed, 20 insertions, 10 deletions
diff --git a/package.json b/package.json index e6230bf18..e702c1d90 100644 --- a/package.json +++ b/package.json @@ -7,6 +7,7 @@ "scripts": { "testrpc": "testrpc -p 8545 --networkId 50 -m \"${npm_package_config_mnemonic}\"", "lerna:run": "lerna run", + "lerna:rebuild": "lerna run clean; lerna run build;", "lerna:publish": "yarn install; lerna run clean; lerna run build; lerna publish --registry=https://registry.npmjs.org/" }, "config": { diff --git a/packages/website/ts/pages/shared/markdown_code_block.tsx b/packages/website/ts/pages/shared/markdown_code_block.tsx index 621e5b606..aded15f0c 100644 --- a/packages/website/ts/pages/shared/markdown_code_block.tsx +++ b/packages/website/ts/pages/shared/markdown_code_block.tsx @@ -7,14 +7,23 @@ interface MarkdownCodeBlockProps { language: string; } -export function MarkdownCodeBlock(props: MarkdownCodeBlockProps) { - return ( - <span style={{fontSize: 16}}> - <HighLight - className={props.language || 'js'} - > - {props.literal} - </HighLight> - </span> - ); +interface MarkdownCodeBlockState {} + +export class MarkdownCodeBlock extends React.Component<MarkdownCodeBlockProps, MarkdownCodeBlockState> { + // Re-rendering a codeblock causes any use selection to become de-selected. This is annoying when trying + // to copy-paste code examples. We therefore noop re-renders on this component if it's props haven't changed. + public shouldComponentUpdate(nextProps: MarkdownCodeBlockProps, nextState: MarkdownCodeBlockState) { + return nextProps.literal !== this.props.literal || nextProps.language !== this.props.language; + } + public render() { + return ( + <span style={{fontSize: 16}}> + <HighLight + className={this.props.language || 'javascript'} + > + {this.props.literal} + </HighLight> + </span> + ); + } } |