diff options
| author | Francesco Agosti <francesco.agosti93@gmail.com> | 2018-11-17 03:47:58 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2018-11-17 03:47:58 +0800 |
| commit | d64bc28ba63cc768493c6e5f3ebf5d344e9432b7 (patch) | |
| tree | b51320c929cc0e7efdae8d06b192503dd5a3822c | |
| parent | e00c41ad88d56fdf9b73128130c181b59de458bd (diff) | |
| parent | b6e6607c46609919fd92bbddc5806645b433a9e8 (diff) | |
| download | dexon-sol-tools-d64bc28ba63cc768493c6e5f3ebf5d344e9432b7.tar.gz dexon-sol-tools-d64bc28ba63cc768493c6e5f3ebf5d344e9432b7.tar.zst dexon-sol-tools-d64bc28ba63cc768493c6e5f3ebf5d344e9432b7.zip | |
Merge pull request #1275 from 0xProject/feature/instant/productionize-publish-flow
[instant] Productionize publish flow
| -rw-r--r-- | package.json | 2 | ||||
| -rw-r--r-- | packages/instant/.dogfood.discharge.json | 2 | ||||
| -rw-r--r-- | packages/instant/.gitignore | 5 | ||||
| -rw-r--r-- | packages/instant/.npmignore | 5 | ||||
| -rw-r--r-- | packages/instant/.staging.discharge.json | 2 | ||||
| -rw-r--r-- | packages/instant/package.json | 9 | ||||
| -rw-r--r-- | packages/instant/public/index.html | 2 | ||||
| -rw-r--r-- | packages/instant/webpack.config.js | 9 |
8 files changed, 22 insertions, 14 deletions
diff --git a/package.json b/package.json index 96c18a2c8..801657f5d 100644 --- a/package.json +++ b/package.json @@ -49,7 +49,7 @@ "maxSize": "700kB" }, { - "path": "packages/instant/public/main.bundle.js", + "path": "packages/instant/umd/instant.js", "maxSize": "1000kB" } ], diff --git a/packages/instant/.dogfood.discharge.json b/packages/instant/.dogfood.discharge.json index 9ade97d01..ca36b3861 100644 --- a/packages/instant/.dogfood.discharge.json +++ b/packages/instant/.dogfood.discharge.json @@ -1,6 +1,6 @@ { "domain": "0x-instant-dogfood", - "build_command": "yarn build:umd:prod", + "build_command": "WEBPACK_OUTPUT_PATH=public yarn build:umd:prod", "upload_directory": "public", "index_key": "index.html", "error_key": "index.html", diff --git a/packages/instant/.gitignore b/packages/instant/.gitignore index e1ce60fa2..a99cea187 100644 --- a/packages/instant/.gitignore +++ b/packages/instant/.gitignore @@ -1,2 +1,3 @@ -public/main.bundle.js -public/main.bundle.js.map
\ No newline at end of file +public/instant.js +public/instant.js.map +umd/*
\ No newline at end of file diff --git a/packages/instant/.npmignore b/packages/instant/.npmignore new file mode 100644 index 000000000..579d65af0 --- /dev/null +++ b/packages/instant/.npmignore @@ -0,0 +1,5 @@ +.* +* +*/ +!lib/src/**/* +!umd/**/*
\ No newline at end of file diff --git a/packages/instant/.staging.discharge.json b/packages/instant/.staging.discharge.json index 1026b9986..c917a650b 100644 --- a/packages/instant/.staging.discharge.json +++ b/packages/instant/.staging.discharge.json @@ -1,6 +1,6 @@ { "domain": "0x-instant-staging", - "build_command": "yarn build:umd:prod", + "build_command": "WEBPACK_OUTPUT_PATH=public yarn build:umd:prod", "upload_directory": "public", "index_key": "index.html", "error_key": "index.html", diff --git a/packages/instant/package.json b/packages/instant/package.json index 6caa3902b..59e357765 100644 --- a/packages/instant/package.json +++ b/packages/instant/package.json @@ -1,10 +1,9 @@ { "name": "@0x/instant", - "version": "0.0.7", + "version": "1.0.0", "engines": { "node": ">=6.12" }, - "private": true, "description": "0x Instant React Component", "main": "lib/src/index.js", "types": "lib/src/index.d.ts", @@ -29,8 +28,8 @@ "config": { "postpublish": { "assets": [ - "packages/instant/public/index.js", - "packages/instant/public/index.min.js" + "packages/instant/umd/instant.js", + "packages/instant/umd/instant.min.js" ] } }, @@ -98,6 +97,6 @@ "webpack-dev-server": "^3.1.9" }, "publishConfig": { - "access": "private" + "access": "public" } } diff --git a/packages/instant/public/index.html b/packages/instant/public/index.html index f6c809e33..253cbb194 100644 --- a/packages/instant/public/index.html +++ b/packages/instant/public/index.html @@ -6,7 +6,7 @@ <meta name="viewport" content="width=device-width, initial-scale=1"> <title>0x Instant Dev Environment</title> <link rel="stylesheet" href="/external.css"> - <script type="text/javascript" src="/main.bundle.js" charset="utf-8"></script> + <script type="text/javascript" src="/instant.js" charset="utf-8"></script> <script type="text/javascript" src="https://unpkg.com/jsuri@1.3.1/Uri.js" charset="utf-8"></script> <script type="text/javascript" src="https://unpkg.com/bignumber.js@4.1.0/bignumber.js" charset="utf-8"></script> <style> diff --git a/packages/instant/webpack.config.js b/packages/instant/webpack.config.js index 3129e13a6..239950866 100644 --- a/packages/instant/webpack.config.js +++ b/packages/instant/webpack.config.js @@ -2,11 +2,14 @@ const path = require('path'); const ip = require('ip'); // The common js bundle (not this one) is built using tsc. // The umd bundle (this one) has a different entrypoint. +const outputPath = process.env.WEBPACK_OUTPUT_PATH || 'umd'; const config = { - entry: './src/index.umd.ts', + entry: { + instant: './src/index.umd.ts', + }, output: { - filename: '[name].bundle.js', - path: path.resolve(__dirname, 'public'), + filename: '[name].js', + path: path.resolve(__dirname, outputPath), library: 'zeroExInstant', libraryTarget: 'umd', }, |