aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorFabio B <kandinsky454@protonmail.ch>2018-11-13 03:43:00 +0800
committerGitHub <noreply@github.com>2018-11-13 03:43:00 +0800
commitadd1cfd26132465ad51a3f9cf2ae8362fc301fcf (patch)
tree21ac4408af9b68c4ce4b195c120b8d62632c5aa7
parent0ebbbdfca49028f196853bbfb082a1378c09f441 (diff)
parentcdf78494d5884f44b7459e350e41109beea20d43 (diff)
downloaddexon-sol-tools-add1cfd26132465ad51a3f9cf2ae8362fc301fcf.tar.gz
dexon-sol-tools-add1cfd26132465ad51a3f9cf2ae8362fc301fcf.tar.zst
dexon-sol-tools-add1cfd26132465ad51a3f9cf2ae8362fc301fcf.zip
Merge pull request #1227 from WyseNynja/patch-1
[web3-wrapper] start jsonRpcRequestId at 1, not 0
-rw-r--r--packages/order-watcher/CHANGELOG.json9
-rw-r--r--packages/web3-wrapper/src/web3_wrapper.ts2
2 files changed, 10 insertions, 1 deletions
diff --git a/packages/order-watcher/CHANGELOG.json b/packages/order-watcher/CHANGELOG.json
index 1255bd25a..dbb4824fc 100644
--- a/packages/order-watcher/CHANGELOG.json
+++ b/packages/order-watcher/CHANGELOG.json
@@ -1,5 +1,14 @@
[
{
+ "version": "2.2.3",
+ "changes": [
+ {
+ "note": "Start jsonRpcRequestId at 1, not 0 as 0 breaks the web3.js websocket RPC provider",
+ "pr": 1227
+ }
+ ]
+ },
+ {
"timestamp": 1542028948,
"version": "2.2.2",
"changes": [
diff --git a/packages/web3-wrapper/src/web3_wrapper.ts b/packages/web3-wrapper/src/web3_wrapper.ts
index 23204e616..be1713f20 100644
--- a/packages/web3-wrapper/src/web3_wrapper.ts
+++ b/packages/web3-wrapper/src/web3_wrapper.ts
@@ -157,7 +157,7 @@ export class Web3Wrapper {
this.abiDecoder = new AbiDecoder([]);
this._provider = provider;
this._txDefaults = txDefaults || {};
- this._jsonRpcRequestId = 0;
+ this._jsonRpcRequestId = 1;
}
/**
* Get the contract defaults set to the Web3Wrapper instance