diff options
| author | Brandon Millman <brandon.millman@gmail.com> | 2018-08-22 04:52:27 +0800 |
|---|---|---|
| committer | Brandon Millman <brandon.millman@gmail.com> | 2018-08-23 06:39:03 +0800 |
| commit | c2454d142841aa3a78a489f055692233f2fa93de (patch) | |
| tree | 326b8c4cda216f9767b7a2b731affdc772012aa7 | |
| parent | 7e0e195c88c407f030754b6050b07698d1868d24 (diff) | |
| download | dexon-sol-tools-c2454d142841aa3a78a489f055692233f2fa93de.tar.gz dexon-sol-tools-c2454d142841aa3a78a489f055692233f2fa93de.tar.zst dexon-sol-tools-c2454d142841aa3a78a489f055692233f2fa93de.zip | |
Add more TODO items
| -rw-r--r-- | packages/forwarder-helper/src/forwarder_helper_impl.ts | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/packages/forwarder-helper/src/forwarder_helper_impl.ts b/packages/forwarder-helper/src/forwarder_helper_impl.ts index 39e84b477..43b2962da 100644 --- a/packages/forwarder-helper/src/forwarder_helper_impl.ts +++ b/packages/forwarder-helper/src/forwarder_helper_impl.ts @@ -56,6 +56,7 @@ export class ForwarderHelperImpl implements ForwarderHelper { orders, remainingFillableMakerAssetAmounts, ); + // TODO: provide a feeRate to the sorting function to more accurately sort based on the current market for ZRX tokens const sortedOrderWithAmounts = sortingUtils.sortOrdersByFeeAdjustedRate(orderWithAmounts); const unbundledSortedOrderWithAmounts = ForwarderHelperImpl._unbundleSignedOrderWithAmounts( sortedOrderWithAmounts, @@ -108,6 +109,7 @@ export class ForwarderHelperImpl implements ForwarderHelper { throw new Error(ForwarderHelperError.InsufficientZrxLiquidity); } // TODO: calculate min and max eth usage + // TODO: optimize orders call data return { makerAssetFillAmount, orders: resultOrders, |