From db7f74f99f7790297e737165a0fc9742fe3daf06 Mon Sep 17 00:00:00 2001
From: Steve Klebanoff <steve.klebanoff@gmail.com>
Date: Fri, 16 Nov 2018 10:10:55 -0800
Subject: Switch heap id on environment, and make sure app id is what we expect

---
 packages/instant/src/constants.ts |  3 ++-
 packages/instant/src/util/heap.ts | 16 ++++++++++++++--
 2 files changed, 16 insertions(+), 3 deletions(-)

diff --git a/packages/instant/src/constants.ts b/packages/instant/src/constants.ts
index f46b0ca21..80c93c431 100644
--- a/packages/instant/src/constants.ts
+++ b/packages/instant/src/constants.ts
@@ -16,8 +16,9 @@ export const BUY_QUOTE_UPDATE_INTERVAL_TIME_MS = ONE_SECOND_MS * 15;
 export const DEFAULT_GAS_PRICE = GWEI_IN_WEI.mul(6);
 export const DEFAULT_ESTIMATED_TRANSACTION_TIME_MS = ONE_MINUTE_MS * 2;
 export const ETH_GAS_STATION_API_BASE_URL = 'https://ethgasstation.info';
-export const ANALYTICS_ENABLED = true; // TODO: change when we can switch on dev
+export const ANALYTICS_ENABLED = process.env.NODE_ENV === 'production' || process.env.ENABLE_HEAP;
 export const HEAP_ANALYTICS_DEVELOPMENT_APP_ID = '507265531';
+export const HEAP_ANALYTICS_PRODUCTION_APP_ID = '2323640988';
 export const COINBASE_API_BASE_URL = 'https://api.coinbase.com/v2';
 export const PROGRESS_STALL_AT_WIDTH = '95%';
 export const PROGRESS_FINISH_ANIMATION_TIME_MS = 200;
diff --git a/packages/instant/src/util/heap.ts b/packages/instant/src/util/heap.ts
index e697562e4..88f65c1ab 100644
--- a/packages/instant/src/util/heap.ts
+++ b/packages/instant/src/util/heap.ts
@@ -1,12 +1,13 @@
 import { ObjectMap } from '@0x/types';
 import { logUtils } from '@0x/utils';
 
-import { ANALYTICS_ENABLED, HEAP_ANALYTICS_DEVELOPMENT_APP_ID } from '../constants';
+import { ANALYTICS_ENABLED, HEAP_ANALYTICS_DEVELOPMENT_APP_ID, HEAP_ANALYTICS_PRODUCTION_APP_ID } from '../constants';
 
 import { AnalyticsEventOptions, AnalyticsUserOptions } from './analytics';
 
 export interface HeapAnalytics {
     loaded: boolean;
+    appid: string;
     identify(id: string, idType: string): void;
     track(eventName: string, eventProperties?: ObjectMap<string | number>): void;
     resetIdentity(): void;
@@ -23,6 +24,13 @@ const getWindow = (): ModifiedWindow => {
     return window as ModifiedWindow;
 };
 
+const getHeapAppId = (): string => {
+    if (process.env.NODE_ENV === 'production') {
+        return HEAP_ANALYTICS_PRODUCTION_APP_ID;
+    }
+    return HEAP_ANALYTICS_DEVELOPMENT_APP_ID;
+};
+
 const setupZeroExInstantHeap = () => {
     const curWindow = getWindow();
     // Set property to specify that this is zeroEx's heap
@@ -64,7 +72,7 @@ const setupZeroExInstantHeap = () => {
                 (window as any).heap[p[c]] = o(p[c]);
         });
     // TODO: use production heap id once environment utils merged
-    (window as any).heap.load(HEAP_ANALYTICS_DEVELOPMENT_APP_ID);
+    (window as any).heap.load(getHeapAppId());
     /* tslint:enable */
 
     return curWindow.heap as HeapAnalytics;
@@ -93,6 +101,10 @@ export const heapUtil = {
         const curHeap = heapUtil.getHeap();
         if (curHeap) {
             try {
+                if (curHeap.appid !== getHeapAppId()) {
+                    // Integrator has included heap after us and reset the app id
+                    return;
+                }
                 heapFunctionCall(curHeap);
             } catch (e) {
                 // We never want analytics to crash our React component
-- 
cgit