diff options
| author | Alex Beregszaszi <alex@rtfs.hu> | 2018-06-06 23:32:08 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2018-06-06 23:32:08 +0800 |
| commit | 24ca596c66ce93b3c1c5de530709ae491322275d (patch) | |
| tree | 4e3654f131b225df56c1de6c7744c7f571077d1c | |
| parent | d97aca77f204a18b0903d9c968f466a2c5011835 (diff) | |
| parent | 0f572159ec42a5d073985b4646916050bf646f2b (diff) | |
| download | dexon-solidity-24ca596c66ce93b3c1c5de530709ae491322275d.tar.gz dexon-solidity-24ca596c66ce93b3c1c5de530709ae491322275d.tar.zst dexon-solidity-24ca596c66ce93b3c1c5de530709ae491322275d.zip | |
Merge pull request #4241 from ethereum/show-named-arg
Show named argument name in error
| -rw-r--r-- | Changelog.md | 2 | ||||
| -rw-r--r-- | libsolidity/analysis/TypeChecker.cpp | 2 | ||||
| -rw-r--r-- | test/libsolidity/syntaxTests/nameAndTypeResolution/103_invalid_parameter_names_in_named_args.sol | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/Changelog.md b/Changelog.md index 6877ae22..f28278b3 100644 --- a/Changelog.md +++ b/Changelog.md @@ -20,7 +20,7 @@ Bugfixes: Features: - + * Type Checker: Show named argument in case of error. Bugfixes: diff --git a/libsolidity/analysis/TypeChecker.cpp b/libsolidity/analysis/TypeChecker.cpp index 60cde33c..521e8bd9 100644 --- a/libsolidity/analysis/TypeChecker.cpp +++ b/libsolidity/analysis/TypeChecker.cpp @@ -1918,7 +1918,7 @@ bool TypeChecker::visit(FunctionCall const& _functionCall) if (!found) m_errorReporter.typeError( _functionCall.location(), - "Named argument does not match function declaration." + "Named argument \"" + *argumentNames[i] + "\" does not match function declaration." ); } } diff --git a/test/libsolidity/syntaxTests/nameAndTypeResolution/103_invalid_parameter_names_in_named_args.sol b/test/libsolidity/syntaxTests/nameAndTypeResolution/103_invalid_parameter_names_in_named_args.sol index fa39736d..bed15186 100644 --- a/test/libsolidity/syntaxTests/nameAndTypeResolution/103_invalid_parameter_names_in_named_args.sol +++ b/test/libsolidity/syntaxTests/nameAndTypeResolution/103_invalid_parameter_names_in_named_args.sol @@ -8,4 +8,4 @@ contract test { } // ---- // Warning: (31-37): This declaration shadows an existing declaration. -// TypeError: (153-168): Named argument does not match function declaration. +// TypeError: (153-168): Named argument "c" does not match function declaration. |