diff options
| author | chriseth <chris@ethereum.org> | 2018-02-01 20:54:51 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2018-02-01 20:54:51 +0800 |
| commit | 07f8f96c94cd2a2602226dee2aa08597c1bd21d6 (patch) | |
| tree | b3a2872738768ae7fdbf4190b2587b206a21f936 /libsolidity | |
| parent | cc1c461fc05255f0efc3a36f6c90336092c66aae (diff) | |
| parent | b545987ec7916209f0a1dfe196d78b49cdf2ddae (diff) | |
| download | dexon-solidity-07f8f96c94cd2a2602226dee2aa08597c1bd21d6.tar.gz dexon-solidity-07f8f96c94cd2a2602226dee2aa08597c1bd21d6.tar.zst dexon-solidity-07f8f96c94cd2a2602226dee2aa08597c1bd21d6.zip | |
Merge pull request #3450 from ethereum/interface-public-visibility
Issue warning for using public visibility for interface functions
Diffstat (limited to 'libsolidity')
| -rw-r--r-- | libsolidity/analysis/TypeChecker.cpp | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/libsolidity/analysis/TypeChecker.cpp b/libsolidity/analysis/TypeChecker.cpp index 191f78e9..d67142e4 100644 --- a/libsolidity/analysis/TypeChecker.cpp +++ b/libsolidity/analysis/TypeChecker.cpp @@ -604,6 +604,8 @@ bool TypeChecker::visit(FunctionDefinition const& _function) { if (_function.visibility() < FunctionDefinition::Visibility::Public) m_errorReporter.typeError(_function.location(), "Functions in interfaces cannot be internal or private."); + else if (_function.visibility() != FunctionDefinition::Visibility::External) + m_errorReporter.warning(_function.location(), "Functions in interfaces should be declared external."); } if (_function.isConstructor()) m_errorReporter.typeError(_function.location(), "Constructor cannot be defined in interfaces."); |