aboutsummaryrefslogtreecommitdiffstats
path: root/libsolidity
diff options
context:
space:
mode:
authorchriseth <chris@ethereum.org>2018-08-09 06:49:04 +0800
committerchriseth <chris@ethereum.org>2018-08-13 20:38:12 +0800
commitbd567a22c9e901d2c7ae73a63f63dc56896b9461 (patch)
tree12ee1ec678075ee62fc10154a0e1bda64a9898c4 /libsolidity
parenta2c754b3fed422b3d8027a5298624bcfed3744a5 (diff)
downloaddexon-solidity-bd567a22c9e901d2c7ae73a63f63dc56896b9461.tar.gz
dexon-solidity-bd567a22c9e901d2c7ae73a63f63dc56896b9461.tar.zst
dexon-solidity-bd567a22c9e901d2c7ae73a63f63dc56896b9461.zip
Defaul data location for type conversions is memory.
Diffstat (limited to 'libsolidity')
-rw-r--r--libsolidity/analysis/TypeChecker.cpp9
1 files changed, 6 insertions, 3 deletions
diff --git a/libsolidity/analysis/TypeChecker.cpp b/libsolidity/analysis/TypeChecker.cpp
index bcc3757a..f9462ae4 100644
--- a/libsolidity/analysis/TypeChecker.cpp
+++ b/libsolidity/analysis/TypeChecker.cpp
@@ -1626,10 +1626,13 @@ bool TypeChecker::visit(FunctionCall const& _functionCall)
else
{
TypePointer const& argType = type(*arguments.front());
+ // Resulting data location is memory unless we are converting from a reference
+ // type with a different data location.
+ // (data location cannot yet be specified for type conversions)
+ DataLocation dataLoc = DataLocation::Memory;
if (auto argRefType = dynamic_cast<ReferenceType const*>(argType.get()))
- // do not change the data location when converting
- // (data location cannot yet be specified for type conversions)
- resultType = ReferenceType::copyForLocationIfReference(argRefType->location(), resultType);
+ dataLoc = argRefType->location();
+ resultType = ReferenceType::copyForLocationIfReference(dataLoc, resultType);
if (!argType->isExplicitlyConvertibleTo(*resultType))
m_errorReporter.typeError(
_functionCall.location(),