diff options
| author | chriseth <chris@ethereum.org> | 2018-04-12 03:53:41 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2018-04-12 03:53:41 +0800 |
| commit | ae3fca6db21e78ff8859a03929983570fe98570e (patch) | |
| tree | 23780e2564b06c09394d39efc1e838898b5420e6 /libsolidity | |
| parent | 8d355df14c0acd8846162790536b8d9992617d3c (diff) | |
| parent | 928ce088456987431143262dcde2d02553b68192 (diff) | |
| download | dexon-solidity-ae3fca6db21e78ff8859a03929983570fe98570e.tar.gz dexon-solidity-ae3fca6db21e78ff8859a03929983570fe98570e.tar.zst dexon-solidity-ae3fca6db21e78ff8859a03929983570fe98570e.zip | |
Merge pull request #3863 from ethereum/fixGasEstimation
Correctly ignore costs of fallback for other functions.
Diffstat (limited to 'libsolidity')
| -rw-r--r-- | libsolidity/interface/GasEstimator.cpp | 9 |
1 files changed, 8 insertions, 1 deletions
diff --git a/libsolidity/interface/GasEstimator.cpp b/libsolidity/interface/GasEstimator.cpp index 2139395f..a496cc21 100644 --- a/libsolidity/interface/GasEstimator.cpp +++ b/libsolidity/interface/GasEstimator.cpp @@ -136,12 +136,19 @@ GasEstimator::GasConsumption GasEstimator::functionalEstimation( ExpressionClasses& classes = state->expressionClasses(); using Id = ExpressionClasses::Id; using Ids = vector<Id>; + // div(calldataload(0), 1 << 224) equals to hashValue Id hashValue = classes.find(u256(FixedHash<4>::Arith(FixedHash<4>(dev::keccak256(_signature))))); Id calldata = classes.find(Instruction::CALLDATALOAD, Ids{classes.find(u256(0))}); classes.forceEqual(hashValue, Instruction::DIV, Ids{ calldata, - classes.find(u256(1) << (8 * 28)) + classes.find(u256(1) << 224) }); + // lt(calldatasize(), 4) equals to 0 (ignore the shortcut for fallback functions) + classes.forceEqual( + classes.find(u256(0)), + Instruction::LT, + Ids{classes.find(Instruction::CALLDATASIZE), classes.find(u256(4))} + ); } PathGasMeter meter(_items, m_evmVersion); |