aboutsummaryrefslogtreecommitdiffstats
path: root/libyul
diff options
context:
space:
mode:
authorchriseth <chris@ethereum.org>2018-12-13 22:53:19 +0800
committerchriseth <chris@ethereum.org>2018-12-13 23:51:10 +0800
commitbc22a25a603296a0f40a4df75287b6d2f51ed4ac (patch)
treeb1869bc693de9d3f6ccd9ec734a5d9746fe5cd6d /libyul
parent6c6a53a439de11ebae0b09d8a18c30018b3d89b4 (diff)
downloaddexon-solidity-bc22a25a603296a0f40a4df75287b6d2f51ed4ac.tar.gz
dexon-solidity-bc22a25a603296a0f40a4df75287b6d2f51ed4ac.tar.zst
dexon-solidity-bc22a25a603296a0f40a4df75287b6d2f51ed4ac.zip
Remove VarDeclPropagator.
Diffstat (limited to 'libyul')
-rw-r--r--libyul/CMakeLists.txt1
-rw-r--r--libyul/optimiser/Suite.cpp7
-rw-r--r--libyul/optimiser/VarDeclPropagator.cpp126
-rw-r--r--libyul/optimiser/VarDeclPropagator.h60
4 files changed, 0 insertions, 194 deletions
diff --git a/libyul/CMakeLists.txt b/libyul/CMakeLists.txt
index 9dee5348..5a86d2a2 100644
--- a/libyul/CMakeLists.txt
+++ b/libyul/CMakeLists.txt
@@ -43,7 +43,6 @@ add_library(yul
optimiser/SyntacticalEquality.cpp
optimiser/UnusedPruner.cpp
optimiser/Utilities.cpp
- optimiser/VarDeclPropagator.cpp
optimiser/VarDeclInitializer.cpp
)
target_link_libraries(yul PUBLIC evmasm devcore langutil)
diff --git a/libyul/optimiser/Suite.cpp b/libyul/optimiser/Suite.cpp
index 16df6d3c..bfba8dfc 100644
--- a/libyul/optimiser/Suite.cpp
+++ b/libyul/optimiser/Suite.cpp
@@ -36,7 +36,6 @@
#include <libyul/optimiser/SSATransform.h>
#include <libyul/optimiser/StructuralSimplifier.h>
#include <libyul/optimiser/RedundantAssignEliminator.h>
-#include <libyul/optimiser/VarDeclPropagator.h>
#include <libyul/AsmAnalysisInfo.h>
#include <libyul/AsmData.h>
#include <libyul/AsmPrinter.h>
@@ -70,7 +69,6 @@ void OptimiserSuite::run(
ExpressionSplitter{dispenser}(ast);
SSATransform::run(ast, dispenser);
RedundantAssignEliminator::run(ast);
- VarDeclPropagator{}(ast);
RedundantAssignEliminator::run(ast);
CommonSubexpressionEliminator{}(ast);
@@ -97,27 +95,22 @@ void OptimiserSuite::run(
RedundantAssignEliminator::run(ast);
CommonSubexpressionEliminator{}(ast);
FullInliner{ast, dispenser}.run();
- VarDeclPropagator{}(ast);
SSATransform::run(ast, dispenser);
RedundantAssignEliminator::run(ast);
- VarDeclPropagator{}(ast);
RedundantAssignEliminator::run(ast);
ExpressionSimplifier::run(ast);
StructuralSimplifier{}(ast);
CommonSubexpressionEliminator{}(ast);
SSATransform::run(ast, dispenser);
RedundantAssignEliminator::run(ast);
- VarDeclPropagator{}(ast);
RedundantAssignEliminator::run(ast);
UnusedPruner::runUntilStabilised(ast, reservedIdentifiers);
}
ExpressionJoiner::run(ast);
- VarDeclPropagator{}(ast);
UnusedPruner::runUntilStabilised(ast);
ExpressionJoiner::run(ast);
UnusedPruner::runUntilStabilised(ast);
ExpressionJoiner::run(ast);
- VarDeclPropagator{}(ast);
UnusedPruner::runUntilStabilised(ast);
ExpressionJoiner::run(ast);
UnusedPruner::runUntilStabilised(ast);
diff --git a/libyul/optimiser/VarDeclPropagator.cpp b/libyul/optimiser/VarDeclPropagator.cpp
deleted file mode 100644
index bf974f44..00000000
--- a/libyul/optimiser/VarDeclPropagator.cpp
+++ /dev/null
@@ -1,126 +0,0 @@
-/*
- This file is part of solidity.
-
- solidity is free software: you can redistribute it and/or modify
- it under the terms of the GNU General Public License as published by
- the Free Software Foundation, either version 3 of the License, or
- (at your option) any later version.
-
- solidity is distributed in the hope that it will be useful,
- but WITHOUT ANY WARRANTY; without even the implied warranty of
- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- GNU General Public License for more details.
-
- You should have received a copy of the GNU General Public License
- along with solidity. If not, see <http://www.gnu.org/licenses/>.
-*/
-
-#include <libyul/optimiser/VarDeclPropagator.h>
-#include <libyul/AsmData.h>
-#include <libdevcore/CommonData.h>
-#include <boost/range/algorithm_ext/erase.hpp>
-#include <algorithm>
-#include <map>
-
-using namespace std;
-using namespace dev;
-using namespace yul;
-
-void VarDeclPropagator::operator()(Block& _block)
-{
- map<YulString, TypedName> outerEmptyVarDecls;
- map<YulString, TypedName> outerLazyInitializedVarDecls;
- swap(m_emptyVarDecls, outerEmptyVarDecls);
- swap(m_lazyInitializedVarDecls, outerLazyInitializedVarDecls);
-
- ASTModifier::operator()(_block);
-
- iterateReplacing(
- _block.statements,
- [this](Statement& _stmt) -> boost::optional<vector<Statement>>
- {
- if (_stmt.type() == typeid(VariableDeclaration))
- {
- VariableDeclaration& varDecl = boost::get<VariableDeclaration>(_stmt);
- boost::remove_erase_if(
- varDecl.variables,
- [&](TypedName const& _typedName) { return m_lazyInitializedVarDecls.count(_typedName.name); }
- );
- if (varDecl.variables.empty())
- return vector<Statement>{};
- else
- return {};
- }
- else if (_stmt.type() == typeid(Assignment))
- {
- Assignment& assignment = boost::get<Assignment>(_stmt);
- if (isFullyLazyInitialized(assignment.variableNames))
- return vector<Statement>{recreateVariableDeclaration(assignment)};
- else
- return {};
- }
- else
- return {};
- }
- );
-
- swap(m_emptyVarDecls, outerEmptyVarDecls);
- swap(m_lazyInitializedVarDecls, outerLazyInitializedVarDecls);
-}
-
-void VarDeclPropagator::operator()(VariableDeclaration& _varDecl)
-{
- if (_varDecl.value)
- visit(*_varDecl.value);
- else
- for (TypedName const& typedName: _varDecl.variables)
- m_emptyVarDecls[typedName.name] = typedName;
-}
-
-void VarDeclPropagator::operator()(Assignment& _assignment)
-{
- visit(*_assignment.value);
-
- if (allVarNamesUninitialized(_assignment.variableNames))
- for (Identifier const& ident: _assignment.variableNames)
- m_lazyInitializedVarDecls[ident.name] = m_emptyVarDecls[ident.name];
-
- for (Identifier& name: _assignment.variableNames)
- (*this)(name);
-}
-
-void VarDeclPropagator::operator()(Identifier& _ident)
-{
- m_emptyVarDecls.erase(_ident.name);
-}
-
-bool VarDeclPropagator::allVarNamesUninitialized(vector<Identifier> const& _variableNames) const
-{
- return all_of(
- begin(_variableNames),
- end(_variableNames),
- [&](Identifier const& _ident) -> bool { return m_emptyVarDecls.count(_ident.name); }
- );
-}
-
-bool VarDeclPropagator::isFullyLazyInitialized(vector<Identifier> const& _variableNames) const
-{
- return all_of(
- begin(_variableNames),
- end(_variableNames),
- [&](Identifier const& ident) -> bool { return m_lazyInitializedVarDecls.count(ident.name); }
- );
-}
-
-VariableDeclaration VarDeclPropagator::recreateVariableDeclaration(Assignment& _assignment)
-{
- TypedNameList variables;
-
- for (Identifier const& varName: _assignment.variableNames)
- {
- variables.emplace_back(move(m_lazyInitializedVarDecls.at(varName.name)));
- m_lazyInitializedVarDecls.erase(varName.name);
- }
-
- return VariableDeclaration{move(_assignment.location), move(variables), std::move(_assignment.value)};
-}
diff --git a/libyul/optimiser/VarDeclPropagator.h b/libyul/optimiser/VarDeclPropagator.h
deleted file mode 100644
index 1908c214..00000000
--- a/libyul/optimiser/VarDeclPropagator.h
+++ /dev/null
@@ -1,60 +0,0 @@
-/*
- This file is part of solidity.
-
- solidity is free software: you can redistribute it and/or modify
- it under the terms of the GNU General Public License as published by
- the Free Software Foundation, either version 3 of the License, or
- (at your option) any later version.
-
- solidity is distributed in the hope that it will be useful,
- but WITHOUT ANY WARRANTY; without even the implied warranty of
- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- GNU General Public License for more details.
-
- You should have received a copy of the GNU General Public License
- along with solidity. If not, see <http://www.gnu.org/licenses/>.
-*/
-
-#pragma once
-
-#include <libyul/AsmDataForward.h>
-#include <libyul/optimiser/ASTWalker.h>
-#include <libyul/Exceptions.h>
-#include <libyul/AsmDataForward.h>
-#include <vector>
-#include <set>
-#include <map>
-
-namespace yul
-{
-
-/**
- * Rewrites Assignment statements into VariableDeclaration when the assignment's LHS
- * variables had no value yet.
- *
- * It recursively walks through the AST and moves each declaration of variables to
- * the first assignment within the same block (if possible)..
- */
-class VarDeclPropagator: public ASTModifier
-{
-public:
- using ASTModifier::operator();
- void operator()(Block& _block) override;
- void operator()(VariableDeclaration& _varDecl) override;
- void operator()(Assignment& _assignment) override;
- void operator()(Identifier& _ident) override;
-
-private:
- bool allVarNamesUninitialized(std::vector<Identifier> const& _variableNames) const;
- bool isFullyLazyInitialized(std::vector<Identifier> const& _variableNames) const;
- VariableDeclaration recreateVariableDeclaration(Assignment& _assignment);
-
-private:
- /// Holds a list of variables from current Block that have no value assigned yet.
- std::map<YulString, TypedName> m_emptyVarDecls;
-
- /// Holds a list variables (and their TypedName) within the current block.
- std::map<YulString, TypedName> m_lazyInitializedVarDecls;
-};
-
-}