From ace601b8f6ebe8097b9c587c96494058d51b3e8f Mon Sep 17 00:00:00 2001
From: chriseth <chris@ethereum.org>
Date: Thu, 20 Dec 2018 17:39:52 +0100
Subject: Tests.

---
 test/libyul/ObjectParser.cpp                       | 30 ++++++++++++++++++++++
 .../object_access.yul                              | 23 +++++++++++++++++
 .../expressionSplitter/object_access.yul           | 21 +++++++++++++++
 3 files changed, 74 insertions(+)
 create mode 100644 test/libyul/yulOptimizerTests/commonSubexpressionEliminator/object_access.yul
 create mode 100644 test/libyul/yulOptimizerTests/expressionSplitter/object_access.yul

diff --git a/test/libyul/ObjectParser.cpp b/test/libyul/ObjectParser.cpp
index bb88e4da..13a95788 100644
--- a/test/libyul/ObjectParser.cpp
+++ b/test/libyul/ObjectParser.cpp
@@ -250,6 +250,36 @@ BOOST_AUTO_TEST_CASE(to_string)
 	BOOST_CHECK_EQUAL(asmStack.print(), expectation);
 }
 
+BOOST_AUTO_TEST_CASE(arg_to_dataoffset_must_be_literal)
+{
+	string code = R"(
+		object "outer" {
+			code { let x := "outer" let y := dataoffset(x) }
+		}
+	)";
+	CHECK_ERROR(code, TypeError, "Function expects direct literals as arguments.");
+}
+
+BOOST_AUTO_TEST_CASE(arg_to_datasize_must_be_literal)
+{
+	string code = R"(
+		object "outer" {
+			code { let x := "outer" let y := datasize(x) }
+		}
+	)";
+	CHECK_ERROR(code, TypeError, "Function expects direct literals as arguments.");
+}
+
+BOOST_AUTO_TEST_CASE(args_to_datacopy_are_arbitrary)
+{
+	string code = R"(
+		object "outer" {
+			code { let x := 0 let y := 2 let s := 3 datacopy(x, y, s) }
+		}
+	)";
+	BOOST_CHECK(successParse(code));
+}
+
 BOOST_AUTO_TEST_SUITE_END()
 
 }
diff --git a/test/libyul/yulOptimizerTests/commonSubexpressionEliminator/object_access.yul b/test/libyul/yulOptimizerTests/commonSubexpressionEliminator/object_access.yul
new file mode 100644
index 00000000..5cfa3e6e
--- /dev/null
+++ b/test/libyul/yulOptimizerTests/commonSubexpressionEliminator/object_access.yul
@@ -0,0 +1,23 @@
+{
+    // Arguments to ``datasize`` and ``dataoffset`` need to be
+    // literals. We cannot simplify their arguments, but we can
+    // simplify them as a full expression.
+    // ``datacopy`` does not have this restriction.
+    let r := "abc"
+    let a := datasize("abc")
+    let x := dataoffset("abc")
+    // should be replaced by a
+    let y := datasize("abc")
+    datacopy("abc", x, y)
+    mstore(a, x)
+}
+// ----
+// commonSubexpressionEliminator
+// {
+//     let r := "abc"
+//     let a := datasize("abc")
+//     let x := dataoffset("abc")
+//     let y := a
+//     datacopy(r, x, a)
+//     mstore(a, x)
+// }
diff --git a/test/libyul/yulOptimizerTests/expressionSplitter/object_access.yul b/test/libyul/yulOptimizerTests/expressionSplitter/object_access.yul
new file mode 100644
index 00000000..2689ab6f
--- /dev/null
+++ b/test/libyul/yulOptimizerTests/expressionSplitter/object_access.yul
@@ -0,0 +1,21 @@
+{
+    // We should never split arguments to ``dataoffset``
+    // or ``datasize`` because they need to be literals
+    let x := dataoffset("abc")
+    let y := datasize("abc")
+    // datacopy is fine, though
+    datacopy(mload(0), mload(1), mload(2))
+}
+// ----
+// expressionSplitter
+// {
+//     let x := dataoffset("abc")
+//     let y := datasize("abc")
+//     let _1 := 2
+//     let _2 := mload(_1)
+//     let _3 := 1
+//     let _4 := mload(_3)
+//     let _5 := 0
+//     let _6 := mload(_5)
+//     datacopy(_6, _4, _2)
+// }
-- 
cgit