From e7ef227226fb3548ecea59d44108a5923afeffc6 Mon Sep 17 00:00:00 2001 From: chriseth Date: Wed, 22 Nov 2017 11:11:48 +0100 Subject: Function inliner. --- libjulia/optimiser/FunctionalInliner.cpp | 71 ++++++++++++++++++++++++++ libjulia/optimiser/FunctionalInliner.h | 69 +++++++++++++++++++++++++ libjulia/optimiser/InlinableFunctionFilter.cpp | 2 + 3 files changed, 142 insertions(+) create mode 100644 libjulia/optimiser/FunctionalInliner.cpp create mode 100644 libjulia/optimiser/FunctionalInliner.h (limited to 'libjulia/optimiser') diff --git a/libjulia/optimiser/FunctionalInliner.cpp b/libjulia/optimiser/FunctionalInliner.cpp new file mode 100644 index 00000000..0544ee5d --- /dev/null +++ b/libjulia/optimiser/FunctionalInliner.cpp @@ -0,0 +1,71 @@ +/* + This file is part of solidity. + + solidity is free software: you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation, either version 3 of the License, or + (at your option) any later version. + + solidity is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with solidity. If not, see . +*/ +/** + * Optimiser component that performs function inlining. + */ + +#include + +#include +#include +#include + +#include + +#include + +using namespace std; +using namespace dev; +using namespace dev::julia; +using namespace dev::solidity; + +void FunctionalInliner::run() +{ + InlinableFunctionFilter filter; + filter(m_block); + m_inlinableFunctions = filter.inlinableFunctions(); + + (*this)(m_block); +} + + +void FunctionalInliner::visit(Expression& _expression) +{ + ASTModifier::visit(_expression); + if (_expression.type() == typeid(FunctionCall)) + { + FunctionCall& funCall = boost::get(_expression); + + bool movable = boost::algorithm::all_of( + funCall.arguments, + [=](Expression const& _arg) { return MovableChecker(_arg).movable(); } + ); + if (m_inlinableFunctions.count(funCall.functionName.name) && movable) + { + FunctionDefinition const& fun = *m_inlinableFunctions.at(funCall.functionName.name); + map substitutions; + for (size_t i = 0; i < fun.parameters.size(); ++i) + substitutions[fun.parameters[i].name] = &funCall.arguments[i]; + _expression = Substitution(substitutions).translate(*boost::get(fun.body.statements.front()).value); + + // TODO actually in the process of inlining, we could also make a function non-inlinable + // because it could now call itself + + // If two functions call each other, we have to exit after some iterations. + } + } +} diff --git a/libjulia/optimiser/FunctionalInliner.h b/libjulia/optimiser/FunctionalInliner.h new file mode 100644 index 00000000..30c972ff --- /dev/null +++ b/libjulia/optimiser/FunctionalInliner.h @@ -0,0 +1,69 @@ +/* + This file is part of solidity. + + solidity is free software: you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation, either version 3 of the License, or + (at your option) any later version. + + solidity is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with solidity. If not, see . +*/ +/** + * Optimiser component that performs function inlining. + */ +#pragma once + +#include + +#include + +#include + +#include +#include + +#include + +namespace dev +{ +namespace julia +{ + +/** + * Optimiser component that modifies an AST in place, inlining functions that can be + * inlined inside functional expressions, i.e. functions that + * - return a single value + * - have a body like r := + * - neither reference themselves nor r in the right hand side + * + * Furthermore, the arguments of the function call cannot have any side-effects. + * + * This component can only be used on sources with unique names. + */ +class FunctionalInliner: public ASTModifier +{ +public: + FunctionalInliner(Block& _block): + m_block(_block) + {} + + void run(); + +private: + virtual void visit(Expression& _expression) override; + + std::map m_inlinableFunctions; + std::map m_varReplacements; + + Block& m_block; +}; + + +} +} diff --git a/libjulia/optimiser/InlinableFunctionFilter.cpp b/libjulia/optimiser/InlinableFunctionFilter.cpp index db9f812d..37e21f0d 100644 --- a/libjulia/optimiser/InlinableFunctionFilter.cpp +++ b/libjulia/optimiser/InlinableFunctionFilter.cpp @@ -51,6 +51,8 @@ void InlinableFunctionFilter::operator()(FunctionDefinition const& _function) Assignment const& assignment = boost::get(bodyStatement); if (assignment.variableNames.size() == 1 && assignment.variableNames.front().name == retVariable) { + // FIXME: use code size metric here + // We cannot overwrite previous settings, because this function definition // would not be valid here if we were searching inside a functionally inlinable // function body. -- cgit