From 25a64c7f8f35833b9dec6068232be6e0ce9d2e78 Mon Sep 17 00:00:00 2001 From: chriseth Date: Fri, 24 Jun 2016 16:41:17 +0200 Subject: Only warn about unused return in low-level functions. --- libsolidity/analysis/TypeChecker.cpp | 21 +++++++++++++++------ 1 file changed, 15 insertions(+), 6 deletions(-) (limited to 'libsolidity/analysis') diff --git a/libsolidity/analysis/TypeChecker.cpp b/libsolidity/analysis/TypeChecker.cpp index c2fd3e7e..6b2c1cb8 100644 --- a/libsolidity/analysis/TypeChecker.cpp +++ b/libsolidity/analysis/TypeChecker.cpp @@ -831,12 +831,21 @@ void TypeChecker::endVisit(ExpressionStatement const& _statement) if (!dynamic_cast(*type(_statement.expression())).mobileType()) typeError(_statement.expression().location(), "Invalid rational number."); - bool unusedReturnValue = true; - if (auto t = dynamic_cast(type(_statement.expression()).get())) - if (t->components().empty()) - unusedReturnValue = false; - if (unusedReturnValue) - warning(_statement.location(), "Unused return value."); + if (auto call = dynamic_cast(&_statement.expression())) + { + if (auto callType = dynamic_cast(type(call->expression()).get())) + { + using Location = FunctionType::Location; + Location location = callType->location(); + if ( + location == Location::Bare || + location == Location::BareCallCode || + location == Location::BareDelegateCall || + location == Location::Send + ) + warning(_statement.location(), "Return value of low-level calls not used."); + } + } } bool TypeChecker::visit(Conditional const& _conditional) -- cgit