From 5ae9b8dab180b94bbbc5a7a791ddd9701f1108f0 Mon Sep 17 00:00:00 2001 From: Alex Beregszaszi Date: Tue, 12 Sep 2017 11:22:29 +0100 Subject: Do not report overload conflicts for every line excessively --- libsolidity/analysis/TypeChecker.cpp | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) (limited to 'libsolidity/analysis') diff --git a/libsolidity/analysis/TypeChecker.cpp b/libsolidity/analysis/TypeChecker.cpp index 3564ff32..87750c6e 100644 --- a/libsolidity/analysis/TypeChecker.cpp +++ b/libsolidity/analysis/TypeChecker.cpp @@ -173,13 +173,17 @@ void TypeChecker::checkContractDuplicateFunctions(ContractDefinition const& _con for (auto const& it: functions) { vector const& overloads = it.second; - for (size_t i = 0; i < overloads.size(); ++i) + set reported; + for (size_t i = 0; i < overloads.size() && !reported.count(i); ++i) { SecondarySourceLocation ssl; for (size_t j = i + 1; j < overloads.size(); ++j) if (FunctionType(*overloads[i]).hasEqualArgumentTypes(FunctionType(*overloads[j]))) + { ssl.append("Other declaration is here:", overloads[j]->location()); + reported.insert(j); + } if (ssl.infos.size() > 0) m_errorReporter.declarationError( -- cgit