From e130bc7e7cc647b15c448133f725a060910da587 Mon Sep 17 00:00:00 2001 From: Lu Guanqun Date: Thu, 14 Jan 2016 01:58:09 +0000 Subject: check whether break/continue is in the loop --- libsolidity/analysis/SyntaxChecker.cpp | 87 ++++++++++++++++++++++++++++++++++ libsolidity/analysis/SyntaxChecker.h | 58 +++++++++++++++++++++++ 2 files changed, 145 insertions(+) create mode 100644 libsolidity/analysis/SyntaxChecker.cpp create mode 100644 libsolidity/analysis/SyntaxChecker.h (limited to 'libsolidity/analysis') diff --git a/libsolidity/analysis/SyntaxChecker.cpp b/libsolidity/analysis/SyntaxChecker.cpp new file mode 100644 index 00000000..92743461 --- /dev/null +++ b/libsolidity/analysis/SyntaxChecker.cpp @@ -0,0 +1,87 @@ +/* + This file is part of cpp-ethereum. + + cpp-ethereum is free software: you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation, either version 3 of the License, or + (at your option) any later version. + + cpp-ethereum is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with cpp-ethereum. If not, see . +*/ + +#include +#include +#include + +using namespace std; +using namespace dev; +using namespace dev::solidity; + + +bool SyntaxChecker::checkSyntax(SourceUnit const& _sourceUnit) +{ + _sourceUnit.accept(*this); + return m_errors.empty(); +} + +void SyntaxChecker::syntaxError(SourceLocation const& _location, std::string const& _description) +{ + auto err = make_shared(Error::Type::SyntaxError); + *err << + errinfo_sourceLocation(_location) << + errinfo_comment(_description); + + m_errors.push_back(err); +} + +bool SyntaxChecker::visit(WhileStatement const& _whileStatement) +{ + _whileStatement.body().annotation().isInLoop = true; + return true; +} + +bool SyntaxChecker::visit(ForStatement const& _forStatement) +{ + _forStatement.body().annotation().isInLoop = true; + return true; +} + +bool SyntaxChecker::visit(Block const& _blockStatement) +{ + bool inLoop = _blockStatement.annotation().isInLoop; + for (auto& statement : _blockStatement.statements()) + statement->annotation().isInLoop = inLoop; + return true; +} + +bool SyntaxChecker::visit(IfStatement const& _ifStatement) +{ + bool inLoop = _ifStatement.annotation().isInLoop; + _ifStatement.trueStatement().annotation().isInLoop = inLoop; + if (_ifStatement.falseStatement()) + _ifStatement.falseStatement()->annotation().isInLoop = inLoop; + return true; +} + +bool SyntaxChecker::visit(Continue const& _continueStatement) +{ + if (!_continueStatement.annotation().isInLoop) + // we're not in a for/while loop, report syntax error + syntaxError(_continueStatement.location(), "\"continue\" has to be in a \"for\" or \"while\" loop."); + return true; +} + +bool SyntaxChecker::visit(Break const& _breakStatement) +{ + if (!_breakStatement.annotation().isInLoop) + // we're not in a for/while loop, report syntax error + syntaxError(_breakStatement.location(), "\"break\" has to be in a \"for\" or \"while\" loop."); + return true; +} + diff --git a/libsolidity/analysis/SyntaxChecker.h b/libsolidity/analysis/SyntaxChecker.h new file mode 100644 index 00000000..66f6d94d --- /dev/null +++ b/libsolidity/analysis/SyntaxChecker.h @@ -0,0 +1,58 @@ +/* + This file is part of cpp-ethereum. + + cpp-ethereum is free software: you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation, either version 3 of the License, or + (at your option) any later version. + + cpp-ethereum is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with cpp-ethereum. If not, see . +*/ + +#pragma once + +#include +#include +#include +#include +#include + +namespace dev +{ +namespace solidity +{ + +/** + * The module that performs syntax analysis on the AST: + * - whether continue/break is in a for/while loop. + */ +class SyntaxChecker : private ASTConstVisitor +{ +public: + /// @param _errors the reference to the list of errors and warnings to add them found during type checking. + SyntaxChecker(ErrorList& _errors): m_errors(_errors) {} + + bool checkSyntax(SourceUnit const& _sourceUnit); + +private: + /// Adds a new error to the list of errors. + void syntaxError(SourceLocation const& _location, std::string const& _description); + + virtual bool visit(WhileStatement const& _whileStatement) override; + virtual bool visit(ForStatement const& _forStatement) override; + virtual bool visit(Block const& _blockStatement) override; + virtual bool visit(IfStatement const& _ifStatement) override; + virtual bool visit(Continue const& _continueStatement) override; + virtual bool visit(Break const& _breakStatement) override; + + ErrorList& m_errors; +}; + +} +} -- cgit