From 384c4546f172f8a0615036be9555774de6592fbc Mon Sep 17 00:00:00 2001 From: Yoichi Hirai Date: Thu, 24 Nov 2016 16:45:17 +0100 Subject: interface: move searchForSubstring out of Error class into a separate file --- test/libsolidity/ErrorCheck.cpp | 32 ++++++++++++++++++++++ test/libsolidity/ErrorCheck.h | 32 ++++++++++++++++++++++ test/libsolidity/SolidityNameAndTypeResolution.cpp | 5 ++-- 3 files changed, 67 insertions(+), 2 deletions(-) create mode 100644 test/libsolidity/ErrorCheck.cpp create mode 100644 test/libsolidity/ErrorCheck.h (limited to 'test/libsolidity') diff --git a/test/libsolidity/ErrorCheck.cpp b/test/libsolidity/ErrorCheck.cpp new file mode 100644 index 00000000..6dddda70 --- /dev/null +++ b/test/libsolidity/ErrorCheck.cpp @@ -0,0 +1,32 @@ +/* + This file is part of solidity. + + solidity is free software: you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation, either version 3 of the License, or + (at your option) any later version. + + solidity is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with solidity. If not, see . +*/ +/** @file ErrorCheck.cpp + * @author Yoichi Hirai + * @date 2016 + */ + +#include +#include + +#include + +bool dev::solidity::searchErrorMessage(Error const& _err, std::string const& _substr) +{ + if (const std::string* errorMessage = boost::get_error_info(_err)) + return errorMessage->find(_substr) != std::string::npos; + return _substr.empty(); +} diff --git a/test/libsolidity/ErrorCheck.h b/test/libsolidity/ErrorCheck.h new file mode 100644 index 00000000..a309a9d3 --- /dev/null +++ b/test/libsolidity/ErrorCheck.h @@ -0,0 +1,32 @@ +/* + This file is part of solidity. + + solidity is free software: you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation, either version 3 of the License, or + (at your option) any later version. + + solidity is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with solidity. If not, see . +*/ +/** @file ErrorCheck.h + * @author Yoichi Hirai + * @date 2016 + */ + +#pragma once + +#include + +namespace dev +{ +namespace solidity +{ +bool searchErrorMessage(Error const& _err, std::string const& _substr); +} +} diff --git a/test/libsolidity/SolidityNameAndTypeResolution.cpp b/test/libsolidity/SolidityNameAndTypeResolution.cpp index 0022dfb2..5671b00b 100644 --- a/test/libsolidity/SolidityNameAndTypeResolution.cpp +++ b/test/libsolidity/SolidityNameAndTypeResolution.cpp @@ -31,6 +31,7 @@ #include #include #include "../TestHelper.h" +#include "ErrorCheck.h" using namespace std; @@ -165,7 +166,7 @@ do \ { \ Error err = expectError((text), (warning)); \ BOOST_CHECK(err.type() == (Error::Type::typ)); \ - BOOST_CHECK(err.searchForSubstring(substring)); \ + BOOST_CHECK(searchErrorMessage(err, substring)); \ } while(0) // [checkError(text, type, substring)] asserts that the compilation down to typechecking @@ -4104,7 +4105,7 @@ BOOST_AUTO_TEST_CASE(warn_nonpresent_pragma) auto sourceAndError = parseAnalyseAndReturnError(text, true, false); BOOST_REQUIRE(!!sourceAndError.second); BOOST_REQUIRE(!!sourceAndError.first); - BOOST_CHECK(sourceAndError.second->searchForSubstring("Source file does not specify required compiler version!")); + BOOST_CHECK(searchErrorMessage(*sourceAndError.second, "Source file does not specify required compiler version!")); } BOOST_AUTO_TEST_CASE(unsatisfied_version) -- cgit