From 3ddbf1617fb8d981131d2df5a48fa0a2615f83a2 Mon Sep 17 00:00:00 2001 From: Alex Beregszaszi Date: Mon, 12 Feb 2018 22:09:14 +0000 Subject: Do not use var where not neccessary in tests --- test/libsolidity/SolidityNameAndTypeResolution.cpp | 2 +- test/libsolidity/ViewPureChecker.cpp | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) (limited to 'test') diff --git a/test/libsolidity/SolidityNameAndTypeResolution.cpp b/test/libsolidity/SolidityNameAndTypeResolution.cpp index b3a21671..950bca38 100644 --- a/test/libsolidity/SolidityNameAndTypeResolution.cpp +++ b/test/libsolidity/SolidityNameAndTypeResolution.cpp @@ -7349,7 +7349,7 @@ BOOST_AUTO_TEST_CASE(warn_about_sha3) char const* text = R"( contract test { function f() pure public { - var x = sha3(uint8(1)); + bytes32 x = sha3(uint8(1)); x; } } diff --git a/test/libsolidity/ViewPureChecker.cpp b/test/libsolidity/ViewPureChecker.cpp index debeb4dc..837f9aa9 100644 --- a/test/libsolidity/ViewPureChecker.cpp +++ b/test/libsolidity/ViewPureChecker.cpp @@ -282,9 +282,9 @@ BOOST_AUTO_TEST_CASE(builtin_functions) require(this.call()); } function g() pure public { - var x = keccak256("abc"); - var y = sha256("abc"); - var z = ecrecover(1, 2, 3, 4); + bytes32 x = keccak256("abc"); + bytes32 y = sha256("abc"); + address z = ecrecover(1, 2, 3, 4); require(true); assert(true); x; y; z; -- cgit From 573aa01fd2a208a119a77fe75129d76a59392abc Mon Sep 17 00:00:00 2001 From: Alex Beregszaszi Date: Mon, 12 Feb 2018 22:26:13 +0000 Subject: Adjust tests for multiple errors with the var keyword --- test/libsolidity/SolidityNameAndTypeResolution.cpp | 30 ++++++++++++++-------- test/libsolidity/ViewPureChecker.cpp | 8 +++--- 2 files changed, 25 insertions(+), 13 deletions(-) (limited to 'test') diff --git a/test/libsolidity/SolidityNameAndTypeResolution.cpp b/test/libsolidity/SolidityNameAndTypeResolution.cpp index 950bca38..1953195c 100644 --- a/test/libsolidity/SolidityNameAndTypeResolution.cpp +++ b/test/libsolidity/SolidityNameAndTypeResolution.cpp @@ -1844,7 +1844,10 @@ BOOST_AUTO_TEST_CASE(warn_var_from_zero) } } )"; - CHECK_WARNING(sourceCode, "uint8, which can hold values between 0 and 255"); + CHECK_WARNING_ALLOW_MULTI(sourceCode, (std::vector{ + "uint8, which can hold values between 0 and 255", + "Use of the \"var\" keyword is deprecated." + })); sourceCode = R"( contract test { function f() pure public { @@ -1853,7 +1856,10 @@ BOOST_AUTO_TEST_CASE(warn_var_from_zero) } } )"; - CHECK_WARNING(sourceCode, "uint256, which can hold values between 0 and 115792089237316195423570985008687907853269984665640564039457584007913129639935"); + CHECK_WARNING_ALLOW_MULTI(sourceCode, (std::vector{ + "uint256, which can hold values between 0 and 115792089237316195423570985008687907853269984665640564039457584007913129639935", + "Use of the \"var\" keyword is deprecated." + })); sourceCode = R"( contract test { function f() pure public { @@ -1862,7 +1868,10 @@ BOOST_AUTO_TEST_CASE(warn_var_from_zero) } } )"; - CHECK_WARNING(sourceCode, "int8, which can hold values between -128 and 127"); + CHECK_WARNING_ALLOW_MULTI(sourceCode, (std::vector{ + "int8, which can hold values between -128 and 127", + "Use of the \"var\" keyword is deprecated." + })); sourceCode = R"( contract test { function f() pure public { @@ -1870,7 +1879,10 @@ BOOST_AUTO_TEST_CASE(warn_var_from_zero) } } )"; - CHECK_WARNING(sourceCode, "uint8, which can hold"); + CHECK_WARNING_ALLOW_MULTI(sourceCode, (std::vector{ + "uint8, which can hold", + "Use of the \"var\" keyword is deprecated." + })); } BOOST_AUTO_TEST_CASE(enum_member_access) @@ -4887,8 +4899,7 @@ BOOST_AUTO_TEST_CASE(warn_about_callcode) char const* text = R"( contract test { function f() pure public { - var x = address(0x12).callcode; - x; + address(0x12).callcode; } } )"; @@ -4897,8 +4908,7 @@ BOOST_AUTO_TEST_CASE(warn_about_callcode) pragma experimental "v0.5.0"; contract test { function f() pure public { - var x = address(0x12).callcode; - x; + address(0x12).callcode; } } )"; @@ -6918,7 +6928,7 @@ BOOST_AUTO_TEST_CASE(function_types_sig) } } )"; - CHECK_SUCCESS_NO_WARNINGS(text); + CHECK_WARNING(text, "Use of the \"var\" keyword is deprecated."); text = R"( contract C { function h() pure external { @@ -6941,7 +6951,7 @@ BOOST_AUTO_TEST_CASE(function_types_sig) } } )"; - CHECK_SUCCESS_NO_WARNINGS(text); + CHECK_WARNING(text, "Use of the \"var\" keyword is deprecated."); } BOOST_AUTO_TEST_CASE(using_this_in_constructor) diff --git a/test/libsolidity/ViewPureChecker.cpp b/test/libsolidity/ViewPureChecker.cpp index 837f9aa9..e91e713c 100644 --- a/test/libsolidity/ViewPureChecker.cpp +++ b/test/libsolidity/ViewPureChecker.cpp @@ -136,10 +136,12 @@ BOOST_AUTO_TEST_CASE(environment_access) } for (string const& x: pure) { - CHECK_WARNING( + CHECK_WARNING_ALLOW_MULTI( "contract C { function f() view public { var x = " + x + "; x; } }", - "restricted to pure" - ); + (std::vector{ + "Function state mutability can be restricted to pure", + "Use of the \"var\" keyword is deprecated." + })); } } -- cgit